From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:44474 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727519AbeJEBFz (ORCPT ); Thu, 4 Oct 2018 21:05:55 -0400 Date: Thu, 4 Oct 2018 11:11:29 -0700 From: Greg KH To: Jan Kiszka Cc: stable@vger.kernel.org Subject: Re: [PATCH 4.9/4.14] serial: mvebu-uart: Fix reporting of effective CSIZE to userspace Message-ID: <20181004181129.GC28484@kroah.com> References: <1538264491145150@kroah.com> <19d49982-1755-9bf0-8dd0-5819672c7838@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19d49982-1755-9bf0-8dd0-5819672c7838@siemens.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Oct 01, 2018 at 09:24:11AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > Commit e0bf2d4982fe7d9ddaf550dd023803ea286f47fc upstream. > > Apparently, this driver (or the hardware) does not support character > length settings. It's apparently running in 8-bit mode, but it makes > userspace believe it's in 5-bit mode. That makes tcsetattr with CS8 > incorrectly fail, breaking e.g. getty from busybox, thus the login shell > on ttyMVx. > > Fix by hard-wiring CS8 into c_cflag. > > Signed-off-by: Jan Kiszka > --- > drivers/tty/serial/mvebu-uart.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Now applied, thanks. greg k-h