From: "John W. Linville" <linville@tuxdriver.com>
To: Eran Ben Elisha <eranbe@mellanox.com>
Cc: netdev@vger.kernel.org,
Chris Preimesberger <chrisp@transition.com>,
Andrew Lunn <andrew@lunn.ch>, Neil Horman <nhorman@tuxdriver.com>,
Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
Subject: Re: [PATCH ethtool v2] ethtool: Fix uninitialized variable use at qsfp dump
Date: Thu, 4 Oct 2018 15:40:34 -0400 [thread overview]
Message-ID: <20181004194033.GD8557@tuxdriver.com> (raw)
In-Reply-To: <1538465059-24645-1-git-send-email-eranbe@mellanox.com>
On Tue, Oct 02, 2018 at 10:24:19AM +0300, Eran Ben Elisha wrote:
> Struct sff_diags can be used uninitialized at sff8636_show_dom, this
> caused the tool to show unreported fields (supports_alarms) by the lower
> level driver.
>
> In addition, make sure the same struct is being initialized at
> sff8472_parse_eeprom function, to avoid the same issue here.
>
> Fixes: a5e73bb05ee4 ("ethtool:QSFP Plus/QSFP28 Diagnostics Information Support")
> Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
OK, queued for next release...
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2018-10-05 2:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 7:24 [PATCH ethtool v2] ethtool: Fix uninitialized variable use at qsfp dump Eran Ben Elisha
2018-10-02 12:50 ` Andrew Lunn
2018-10-04 19:40 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004194033.GD8557@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=andrew@lunn.ch \
--cc=chrisp@transition.com \
--cc=eranbe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vidya@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.