From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v8,02/10] edac: synopsys: Rename the static functions to a shorter name From: Borislav Petkov Message-Id: <20181004203540.GD5149@zn.tnic> Date: Thu, 4 Oct 2018 22:35:40 +0200 To: Manish Narani Cc: robh+dt@kernel.org, mark.rutland@arm.com, michal.simek@xilinx.com, mchehab@kernel.org, sudeep.holla@arm.com, amit.kucheria@linaro.org, leoyang.li@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org List-ID: T24gVGh1LCBPY3QgMDQsIDIwMTggYXQgMDk6MDU6MjBQTSArMDUzMCwgTWFuaXNoIE5hcmFuaSB3 cm90ZToKPiBSZW5hbWUgdGhlIHN0YXRpYyBmdW5jdGlvbnMgdG8gYSBzaG9ydGVyIG5hbWUuIFNp bmNlIHRoaXMgaXMgU3lub3BzeXMKPiBFREFDIGRyaXZlciwgYmV0dGVyIHRvIHJlbW92ZSB1bm5l Y2Vzc2FyeSAnc3lucHNfJyBwcmVmaXggaW4gZnVuY3Rpb24KPiBuYW1lcy4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBNYW5pc2ggTmFyYW5pIDxtYW5pc2gubmFyYW5pQHhpbGlueC5jb20+Cj4gLS0tCj4g IGRyaXZlcnMvZWRhYy9zeW5vcHN5c19lZGFjLmMgfCA1NiArKysrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygr KSwgMjggZGVsZXRpb25zKC0pCgpPaywgbGV0J3MgZmxpcCB0aGUgcm9sZXMgLSBub3cgeW91IGdl dCB0byByZXZpZXcgd2hhdCBJJ3ZlIGNvbW1pdHRlZDoKLS0tCkZyb206IE1hbmlzaCBOYXJhbmkg PG1hbmlzaC5uYXJhbmlAeGlsaW54LmNvbT4KRGF0ZTogVGh1LCA0IE9jdCAyMDE4IDIxOjA1OjIw ICswNTMwClN1YmplY3Q6IFtQQVRDSCAxLzJdIEVEQUMsIHN5bm9wc3lzOiBTaG9ydGVuIHN0YXRp YyBmdW5jdGlvbiBuYW1lcwoKU2hvcnRlbiBzdGF0aWMgZnVuY3Rpb24gbmFtZXMsIHJlbW92ZSB0 aGUgdW5uZWNlc3NhcnkgJ3N5bnBzXycgcHJlZml4IGluCmZ1bmN0aW9uIG5hbWVzLgoKIFsgYnA6 IERyb3AgdGhlICJlZGFjXyIgcHJlZml4IHRvbyBhcyB0aGF0IHByZWZpeCBpcyByZXNlcnZlZCBm b3IKICAgRURBQyBjb3JlIGZ1bmN0aW9ucy4gXQoKU2lnbmVkLW9mZi1ieTogTWFuaXNoIE5hcmFu aSA8bWFuaXNoLm5hcmFuaUB4aWxpbnguY29tPgpTaWduZWQtb2ZmLWJ5OiBCb3Jpc2xhdiBQZXRr b3YgPGJwQHN1c2UuZGU+CkNDOiBNYXVybyBDYXJ2YWxobyBDaGVoYWIgPG1jaGVoYWJAa2VybmVs Lm9yZz4KQ0M6IE1pY2hhbCBTaW1layA8bWljaGFsLnNpbWVrQHhpbGlueC5jb20+CkNDOiBhbWl0 Lmt1Y2hlcmlhQGxpbmFyby5vcmcKQ0M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnCkNDOiBs ZW95YW5nLmxpQG54cC5jb20KQ0M6IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpDQzogbGludXgtZWRhYyA8bGludXgtZWRhY0B2Z2VyLmtlcm5lbC5vcmc+CkNDOiBtYXJrLnJ1 dGxhbmRAYXJtLmNvbQpDQzogcm9iaCtkdEBrZXJuZWwub3JnCkNDOiBzdWRlZXAuaG9sbGFAYXJt LmNvbQpMaW5rOiBodHRwOi8vbGttbC5rZXJuZWwub3JnL3IvMTUzODY2NzMyOC05NDY1LTMtZ2l0 LXNlbmQtZW1haWwtbWFuaXNoLm5hcmFuaUB4aWxpbnguY29tCi0tLQogZHJpdmVycy9lZGFjL3N5 bm9wc3lzX2VkYWMuYyB8IDc5ICsrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQog MSBmaWxlIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDQxIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2RyaXZlcnMvZWRhYy9zeW5vcHN5c19lZGFjLmMgYi9kcml2ZXJzL2VkYWMvc3lub3Bz eXNfZWRhYy5jCmluZGV4IDE5MzZjNzNmMWQxNS4uZmJhZjMzNTQwY2UzIDEwMDY0NAotLS0gYS9k cml2ZXJzL2VkYWMvc3lub3BzeXNfZWRhYy5jCisrKyBiL2RyaXZlcnMvZWRhYy9zeW5vcHN5c19l ZGFjLmMKQEAgLTE0Miw3ICsxNDIsNyBAQCBzdHJ1Y3Qgc3lucHNfZWRhY19wcml2IHsKIH07CiAK IC8qKgotICogc3lucHNfZWRhY19nZXRlcnJvcl9pbmZvIC0gR2V0IHRoZSBjdXJyZW50IGVjYyBl cnJvciBpbmZvCisgKiBnZXRfZXJyb3JfaW5mbyAtIEdldCB0aGUgY3VycmVudCBlY2MgZXJyb3Ig aW5mbwogICogQGJhc2U6CVBvaW50ZXIgdG8gdGhlIGJhc2UgYWRkcmVzcyBvZiB0aGUgZGRyIG1l bW9yeSBjb250cm9sbGVyCiAgKiBAcDoJCVBvaW50ZXIgdG8gdGhlIHN5bm9wc3lzIGVjYyBzdGF0 dXMgc3RydWN0dXJlCiAgKgpAQCAtMTUwLDggKzE1MCw3IEBAIHN0cnVjdCBzeW5wc19lZGFjX3By aXYgewogICoKICAqIFJldHVybjogb25lIGlmIHRoZXJlIGlzIG5vIGVycm9yIG90aGVyd2lzZSBy ZXR1cm5zIHplcm8KICAqLwotc3RhdGljIGludCBzeW5wc19lZGFjX2dldGVycm9yX2luZm8odm9p ZCBfX2lvbWVtICpiYXNlLAotCQkJCSAgICBzdHJ1Y3Qgc3lucHNfZWNjX3N0YXR1cyAqcCkKK3N0 YXRpYyBpbnQgZ2V0X2Vycm9yX2luZm8odm9pZCBfX2lvbWVtICpiYXNlLCBzdHJ1Y3Qgc3lucHNf ZWNjX3N0YXR1cyAqcCkKIHsKIAl1MzIgcmVndmFsLCBjbGVhcnZhbCA9IDA7CiAKQEAgLTE5Niwx NCArMTk1LDEzIEBAIHN0YXRpYyBpbnQgc3lucHNfZWRhY19nZXRlcnJvcl9pbmZvKHZvaWQgX19p b21lbSAqYmFzZSwKIH0KIAogLyoqCi0gKiBzeW5wc19lZGFjX2hhbmRsZV9lcnJvciAtIEhhbmRs ZSBjb250cm9sbGVyIGVycm9yIHR5cGVzIENFIGFuZCBVRQorICogaGFuZGxlX2Vycm9yIC0gSGFu ZGxlIGNvbnRyb2xsZXIgZXJyb3IgdHlwZXMgQ0UgYW5kIFVFCiAgKiBAbWNpOglQb2ludGVyIHRv IHRoZSBlZGFjIG1lbW9yeSBjb250cm9sbGVyIGluc3RhbmNlCiAgKiBAcDoJCVBvaW50ZXIgdG8g dGhlIHN5bm9wc3lzIGVjYyBzdGF0dXMgc3RydWN0dXJlCiAgKgotICogSGFuZGxlcyB0aGUgY29u dHJvbGxlciBFQ0MgY29ycmVjdGFibGUgYW5kIHVuIGNvcnJlY3RhYmxlIGVycm9yLgorICogSGFu ZGxlcyB0aGUgY29udHJvbGxlciBFQ0MgY29ycmVjdGFibGUgYW5kIHVuY29ycmVjdGFibGUgZXJy b3IuCiAgKi8KLXN0YXRpYyB2b2lkIHN5bnBzX2VkYWNfaGFuZGxlX2Vycm9yKHN0cnVjdCBtZW1f Y3RsX2luZm8gKm1jaSwKLQkJCQkgICAgc3RydWN0IHN5bnBzX2VjY19zdGF0dXMgKnApCitzdGF0 aWMgdm9pZCBoYW5kbGVfZXJyb3Ioc3RydWN0IG1lbV9jdGxfaW5mbyAqbWNpLCBzdHJ1Y3Qgc3lu cHNfZWNjX3N0YXR1cyAqcCkKIHsKIAlzdHJ1Y3Qgc3lucHNfZWRhY19wcml2ICpwcml2ID0gbWNp LT5wdnRfaW5mbzsKIAlzdHJ1Y3QgZWNjX2Vycm9yX2luZm8gKnBpbmY7CkBAIC0yMzIsMzAgKzIz MCwzMCBAQCBzdGF0aWMgdm9pZCBzeW5wc19lZGFjX2hhbmRsZV9lcnJvcihzdHJ1Y3QgbWVtX2N0 bF9pbmZvICptY2ksCiB9CiAKIC8qKgotICogc3lucHNfZWRhY19jaGVjayAtIENoZWNrIGNvbnRy b2xsZXIgZm9yIEVDQyBlcnJvcnMKKyAqIGNoZWNrX2Vycm9ycyAtIENoZWNrIGNvbnRyb2xsZXIg Zm9yIEVDQyBlcnJvcnMKICAqIEBtY2k6CVBvaW50ZXIgdG8gdGhlIGVkYWMgbWVtb3J5IGNvbnRy b2xsZXIgaW5zdGFuY2UKICAqCiAgKiBVc2VkIHRvIGNoZWNrIGFuZCBwb3N0IEVDQyBlcnJvcnMu IENhbGxlZCBieSB0aGUgcG9sbGluZyB0aHJlYWQKICAqLwotc3RhdGljIHZvaWQgc3lucHNfZWRh Y19jaGVjayhzdHJ1Y3QgbWVtX2N0bF9pbmZvICptY2kpCitzdGF0aWMgdm9pZCBjaGVja19lcnJv cnMoc3RydWN0IG1lbV9jdGxfaW5mbyAqbWNpKQogewogCXN0cnVjdCBzeW5wc19lZGFjX3ByaXYg KnByaXYgPSBtY2ktPnB2dF9pbmZvOwogCWludCBzdGF0dXM7CiAKLQlzdGF0dXMgPSBzeW5wc19l ZGFjX2dldGVycm9yX2luZm8ocHJpdi0+YmFzZWFkZHIsICZwcml2LT5zdGF0KTsKKwlzdGF0dXMg PSBnZXRfZXJyb3JfaW5mbyhwcml2LT5iYXNlYWRkciwgJnByaXYtPnN0YXQpOwogCWlmIChzdGF0 dXMpCiAJCXJldHVybjsKIAogCXByaXYtPmNlX2NudCArPSBwcml2LT5zdGF0LmNlX2NudDsKIAlw cml2LT51ZV9jbnQgKz0gcHJpdi0+c3RhdC51ZV9jbnQ7Ci0Jc3lucHNfZWRhY19oYW5kbGVfZXJy b3IobWNpLCAmcHJpdi0+c3RhdCk7CisJaGFuZGxlX2Vycm9yKG1jaSwgJnByaXYtPnN0YXQpOwog CiAJZWRhY19kYmcoMywgIlRvdGFsIGVycm9yIGNvdW50IENFICVkIFVFICVkXG4iLAogCQkgcHJp di0+Y2VfY250LCBwcml2LT51ZV9jbnQpOwogfQogCiAvKioKLSAqIHN5bnBzX2VkYWNfZ2V0X2R0 eXBlIC0gUmV0dXJuIHRoZSBjb250cm9sbGVyIG1lbW9yeSB3aWR0aAorICogZ2V0X2R0eXBlIC0g UmV0dXJuIHRoZSBjb250cm9sbGVyIG1lbW9yeSB3aWR0aAogICogQGJhc2U6CVBvaW50ZXIgdG8g dGhlIGRkciBtZW1vcnkgY29udHJvbGxlciBiYXNlIGFkZHJlc3MKICAqCiAgKiBHZXQgdGhlIEVE QUMgZGV2aWNlIHR5cGUgd2lkdGggYXBwcm9wcmlhdGUgZm9yIHRoZSBjdXJyZW50IGNvbnRyb2xs ZXIKQEAgLTI2Myw3ICsyNjEsNyBAQCBzdGF0aWMgdm9pZCBzeW5wc19lZGFjX2NoZWNrKHN0cnVj dCBtZW1fY3RsX2luZm8gKm1jaSkKICAqCiAgKiBSZXR1cm46IGEgZGV2aWNlIHR5cGUgd2lkdGgg ZW51bWVyYXRpb24uCiAgKi8KLXN0YXRpYyBlbnVtIGRldl90eXBlIHN5bnBzX2VkYWNfZ2V0X2R0 eXBlKGNvbnN0IHZvaWQgX19pb21lbSAqYmFzZSkKK3N0YXRpYyBlbnVtIGRldl90eXBlIGdldF9k dHlwZShjb25zdCB2b2lkIF9faW9tZW0gKmJhc2UpCiB7CiAJZW51bSBkZXZfdHlwZSBkdDsKIAl1 MzIgd2lkdGg7CkBAIC0yODYsMjAgKzI4NCwyMCBAQCBzdGF0aWMgZW51bSBkZXZfdHlwZSBzeW5w c19lZGFjX2dldF9kdHlwZShjb25zdCB2b2lkIF9faW9tZW0gKmJhc2UpCiB9CiAKIC8qKgotICog c3lucHNfZWRhY19nZXRfZWNjc3RhdGUgLSBSZXR1cm4gdGhlIGNvbnRyb2xsZXIgZWNjIGVuYWJs ZS9kaXNhYmxlIHN0YXR1cwotICogQGJhc2U6CVBvaW50ZXIgdG8gdGhlIGRkciBtZW1vcnkgY29u dHJvbGxlciBiYXNlIGFkZHJlc3MKKyAqIGdldF9lY2Nfc3RhdGUgLSBSZXR1cm4gdGhlIGNvbnRy b2xsZXIgRUNDIGVuYWJsZS9kaXNhYmxlIHN0YXR1cworICogQGJhc2U6CVBvaW50ZXIgdG8gdGhl IEREUiBtZW1vcnkgY29udHJvbGxlciBiYXNlIGFkZHJlc3MKICAqCi0gKiBHZXQgdGhlIEVDQyBl bmFibGUvZGlzYWJsZSBzdGF0dXMgZm9yIHRoZSBjb250cm9sbGVyCisgKiBHZXQgdGhlIEVDQyBl bmFibGUvZGlzYWJsZSBzdGF0dXMgZm9yIHRoZSBjb250cm9sbGVyLgogICoKLSAqIFJldHVybjog YSBlY2Mgc3RhdHVzIGJvb2xlYW4gaS5lIHRydWUvZmFsc2UgLSBlbmFibGVkL2Rpc2FibGVkLgor ICogUmV0dXJuOiBhIEVDQyBzdGF0dXMgYm9vbGVhbiBpLmUgdHJ1ZS9mYWxzZSAtIGVuYWJsZWQv ZGlzYWJsZWQuCiAgKi8KLXN0YXRpYyBib29sIHN5bnBzX2VkYWNfZ2V0X2VjY3N0YXRlKHZvaWQg X19pb21lbSAqYmFzZSkKK3N0YXRpYyBib29sIGdldF9lY2Nfc3RhdGUodm9pZCBfX2lvbWVtICpi YXNlKQogewogCWJvb2wgc3RhdGUgPSBmYWxzZTsKIAllbnVtIGRldl90eXBlIGR0OwogCXUzMiBl Y2N0eXBlOwogCi0JZHQgPSBzeW5wc19lZGFjX2dldF9kdHlwZShiYXNlKTsKKwlkdCA9IGdldF9k dHlwZShiYXNlKTsKIAlpZiAoZHQgPT0gREVWX1VOS05PV04pCiAJCXJldHVybiBzdGF0ZTsKIApA QCAtMzExLDExICszMDksMTEgQEAgc3RhdGljIGJvb2wgc3lucHNfZWRhY19nZXRfZWNjc3RhdGUo dm9pZCBfX2lvbWVtICpiYXNlKQogfQogCiAvKioKLSAqIHN5bnBzX2VkYWNfZ2V0X21lbXNpemUg LSByZWFkcyB0aGUgc2l6ZSBvZiB0aGUgYXR0YWNoZWQgbWVtb3J5IGRldmljZQorICogZ2V0X21l bXNpemUgLSByZWFkcyB0aGUgc2l6ZSBvZiB0aGUgYXR0YWNoZWQgbWVtb3J5IGRldmljZQogICoK ICAqIFJldHVybjogdGhlIG1lbW9yeSBzaXplIGluIGJ5dGVzCiAgKi8KLXN0YXRpYyB1MzIgc3lu cHNfZWRhY19nZXRfbWVtc2l6ZSh2b2lkKQorc3RhdGljIHUzMiBnZXRfbWVtc2l6ZSh2b2lkKQog ewogCXN0cnVjdCBzeXNpbmZvIGluZjsKIApAQCAtMzI1LDcgKzMyMyw3IEBAIHN0YXRpYyB1MzIg c3lucHNfZWRhY19nZXRfbWVtc2l6ZSh2b2lkKQogfQogCiAvKioKLSAqIHN5bnBzX2VkYWNfZ2V0 X210eXBlIC0gUmV0dXJucyBjb250cm9sbGVyIG1lbW9yeSB0eXBlCisgKiBnZXRfbXR5cGUgLSBS ZXR1cm5zIGNvbnRyb2xsZXIgbWVtb3J5IHR5cGUKICAqIEBiYXNlOglwb2ludGVyIHRvIHRoZSBz eW5vcHN5cyBlY2Mgc3RhdHVzIHN0cnVjdHVyZQogICoKICAqIEdldCB0aGUgRURBQyBtZW1vcnkg dHlwZSBhcHByb3ByaWF0ZSBmb3IgdGhlIGN1cnJlbnQgY29udHJvbGxlcgpAQCAtMzMzLDcgKzMz MSw3IEBAIHN0YXRpYyB1MzIgc3lucHNfZWRhY19nZXRfbWVtc2l6ZSh2b2lkKQogICoKICAqIFJl dHVybjogYSBtZW1vcnkgdHlwZSBlbnVtZXJhdGlvbi4KICAqLwotc3RhdGljIGVudW0gbWVtX3R5 cGUgc3lucHNfZWRhY19nZXRfbXR5cGUoY29uc3Qgdm9pZCBfX2lvbWVtICpiYXNlKQorc3RhdGlj IGVudW0gbWVtX3R5cGUgZ2V0X210eXBlKGNvbnN0IHZvaWQgX19pb21lbSAqYmFzZSkKIHsKIAll bnVtIG1lbV90eXBlIG10OwogCXUzMiBtZW10eXBlOwpAQCAtMzQ5LDcgKzM0Nyw3IEBAIHN0YXRp YyBlbnVtIG1lbV90eXBlIHN5bnBzX2VkYWNfZ2V0X210eXBlKGNvbnN0IHZvaWQgX19pb21lbSAq YmFzZSkKIH0KIAogLyoqCi0gKiBzeW5wc19lZGFjX2luaXRfY3Nyb3dzIC0gSW5pdGlhbGl6ZSB0 aGUgY3Mgcm93IGRhdGEKKyAqIGluaXRfY3Nyb3dzIC0gSW5pdGlhbGl6ZSB0aGUgY3Mgcm93IGRh dGEKICAqIEBtY2k6CVBvaW50ZXIgdG8gdGhlIGVkYWMgbWVtb3J5IGNvbnRyb2xsZXIgaW5zdGFu Y2UKICAqCiAgKiBJbml0aWFsaXplcyB0aGUgY2hpcCBzZWxlY3Qgcm93cyBhc3NvY2lhdGVkIHdp dGggdGhlIEVEQUMgbWVtb3J5CkBAIC0zNTcsNyArMzU1LDcgQEAgc3RhdGljIGVudW0gbWVtX3R5 cGUgc3lucHNfZWRhY19nZXRfbXR5cGUoY29uc3Qgdm9pZCBfX2lvbWVtICpiYXNlKQogICoKICAq IFJldHVybjogVW5jb25kaXRpb25hbGx5IDAuCiAgKi8KLXN0YXRpYyBpbnQgc3lucHNfZWRhY19p bml0X2Nzcm93cyhzdHJ1Y3QgbWVtX2N0bF9pbmZvICptY2kpCitzdGF0aWMgaW50IGluaXRfY3Ny b3dzKHN0cnVjdCBtZW1fY3RsX2luZm8gKm1jaSkKIHsKIAlzdHJ1Y3Qgc3lucHNfZWRhY19wcml2 ICpwcml2ID0gbWNpLT5wdnRfaW5mbzsKIAlzdHJ1Y3QgY3Nyb3dfaW5mbyAqY3NpOwpAQCAtMzY3 LDE1ICszNjUsMTUgQEAgc3RhdGljIGludCBzeW5wc19lZGFjX2luaXRfY3Nyb3dzKHN0cnVjdCBt ZW1fY3RsX2luZm8gKm1jaSkKIAogCWZvciAocm93ID0gMDsgcm93IDwgbWNpLT5ucl9jc3Jvd3M7 IHJvdysrKSB7CiAJCWNzaSA9IG1jaS0+Y3Nyb3dzW3Jvd107Ci0JCXNpemUgPSBzeW5wc19lZGFj X2dldF9tZW1zaXplKCk7CisJCXNpemUgPSBnZXRfbWVtc2l6ZSgpOwogCiAJCWZvciAoaiA9IDA7 IGogPCBjc2ktPm5yX2NoYW5uZWxzOyBqKyspIHsKIAkJCWRpbW0JCT0gY3NpLT5jaGFubmVsc1tq XS0+ZGltbTsKIAkJCWRpbW0tPmVkYWNfbW9kZQk9IEVEQUNfRkxBR19TRUNERUQ7Ci0JCQlkaW1t LT5tdHlwZQk9IHN5bnBzX2VkYWNfZ2V0X210eXBlKHByaXYtPmJhc2VhZGRyKTsKKwkJCWRpbW0t Pm10eXBlCT0gZ2V0X210eXBlKHByaXYtPmJhc2VhZGRyKTsKIAkJCWRpbW0tPm5yX3BhZ2VzCT0g KHNpemUgPj4gUEFHRV9TSElGVCkgLyBjc2ktPm5yX2NoYW5uZWxzOwogCQkJZGltbS0+Z3JhaW4J PSBTWU5QU19FREFDX0VSUl9HUkFJTjsKLQkJCWRpbW0tPmR0eXBlCT0gc3lucHNfZWRhY19nZXRf ZHR5cGUocHJpdi0+YmFzZWFkZHIpOworCQkJZGltbS0+ZHR5cGUJPSBnZXRfZHR5cGUocHJpdi0+ YmFzZWFkZHIpOwogCQl9CiAJfQogCkBAIC0zODMsNyArMzgxLDcgQEAgc3RhdGljIGludCBzeW5w c19lZGFjX2luaXRfY3Nyb3dzKHN0cnVjdCBtZW1fY3RsX2luZm8gKm1jaSkKIH0KIAogLyoqCi0g KiBzeW5wc19lZGFjX21jX2luaXQgLSBJbml0aWFsaXplIGRyaXZlciBpbnN0YW5jZQorICogbWNf aW5pdCAtIEluaXRpYWxpemUgZHJpdmVyIGluc3RhbmNlCiAgKiBAbWNpOglQb2ludGVyIHRvIHRo ZSBlZGFjIG1lbW9yeSBjb250cm9sbGVyIGluc3RhbmNlCiAgKiBAcGRldjoJUG9pbnRlciB0byB0 aGUgcGxhdGZvcm1fZGV2aWNlIHN0cnVjdAogICoKQEAgLTM5Myw4ICszOTEsNyBAQCBzdGF0aWMg aW50IHN5bnBzX2VkYWNfaW5pdF9jc3Jvd3Moc3RydWN0IG1lbV9jdGxfaW5mbyAqbWNpKQogICoK ICAqIFJldHVybjogQWx3YXlzIHplcm8uCiAgKi8KLXN0YXRpYyBpbnQgc3lucHNfZWRhY19tY19p bml0KHN0cnVjdCBtZW1fY3RsX2luZm8gKm1jaSwKLQkJCQkgc3RydWN0IHBsYXRmb3JtX2Rldmlj ZSAqcGRldikKK3N0YXRpYyBpbnQgbWNfaW5pdChzdHJ1Y3QgbWVtX2N0bF9pbmZvICptY2ksIHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiB7CiAJaW50IHN0YXR1czsKIAlzdHJ1Y3Qgc3lu cHNfZWRhY19wcml2ICpwcml2OwpAQCAtNDE1LDE2ICs0MTIsMTYgQEAgc3RhdGljIGludCBzeW5w c19lZGFjX21jX2luaXQoc3RydWN0IG1lbV9jdGxfaW5mbyAqbWNpLAogCW1jaS0+bW9kX25hbWUg PSBTWU5QU19FREFDX01PRF9WRVI7CiAKIAllZGFjX29wX3N0YXRlID0gRURBQ19PUFNUQVRFX1BP TEw7Ci0JbWNpLT5lZGFjX2NoZWNrID0gc3lucHNfZWRhY19jaGVjazsKKwltY2ktPmVkYWNfY2hl Y2sgPSBjaGVja19lcnJvcnM7CiAJbWNpLT5jdGxfcGFnZV90b19waHlzID0gTlVMTDsKIAotCXN0 YXR1cyA9IHN5bnBzX2VkYWNfaW5pdF9jc3Jvd3MobWNpKTsKKwlzdGF0dXMgPSBpbml0X2Nzcm93 cyhtY2kpOwogCiAJcmV0dXJuIHN0YXR1czsKIH0KIAogLyoqCi0gKiBzeW5wc19lZGFjX21jX3By b2JlIC0gQ2hlY2sgY29udHJvbGxlciBhbmQgYmluZCBkcml2ZXIKKyAqIG1jX3Byb2JlIC0gQ2hl Y2sgY29udHJvbGxlciBhbmQgYmluZCBkcml2ZXIKICAqIEBwZGV2OglQb2ludGVyIHRvIHRoZSBw bGF0Zm9ybV9kZXZpY2Ugc3RydWN0CiAgKgogICogUHJvYmVzIGEgc3BlY2lmaWMgY29udHJvbGxl ciBpbnN0YW5jZSBmb3IgYmluZGluZyB3aXRoIHRoZSBkcml2ZXIuCkBAIC00MzIsNyArNDI5LDcg QEAgc3RhdGljIGludCBzeW5wc19lZGFjX21jX2luaXQoc3RydWN0IG1lbV9jdGxfaW5mbyAqbWNp LAogICogUmV0dXJuOiAwIGlmIHRoZSBjb250cm9sbGVyIGluc3RhbmNlIHdhcyBzdWNjZXNzZnVs bHkgYm91bmQgdG8gdGhlCiAgKiBkcml2ZXI7IG90aGVyd2lzZSwgPCAwIG9uIGVycm9yLgogICov Ci1zdGF0aWMgaW50IHN5bnBzX2VkYWNfbWNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAq cGRldikKK3N0YXRpYyBpbnQgbWNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikK IHsKIAlzdHJ1Y3QgZWRhY19tY19sYXllciBsYXllcnNbMl07CiAJc3RydWN0IHN5bnBzX2VkYWNf cHJpdiAqcHJpdjsKQEAgLTQ0Niw3ICs0NDMsNyBAQCBzdGF0aWMgaW50IHN5bnBzX2VkYWNfbWNf cHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIAlpZiAoSVNfRVJSKGJhc2VhZGRy KSkKIAkJcmV0dXJuIFBUUl9FUlIoYmFzZWFkZHIpOwogCi0JaWYgKCFzeW5wc19lZGFjX2dldF9l Y2NzdGF0ZShiYXNlYWRkcikpIHsKKwlpZiAoIWdldF9lY2Nfc3RhdGUoYmFzZWFkZHIpKSB7CiAJ CWVkYWNfcHJpbnRrKEtFUk5fSU5GTywgRURBQ19NQywgIkVDQyBub3QgZW5hYmxlZFxuIik7CiAJ CXJldHVybiAtRU5YSU87CiAJfQpAQCAtNDY4LDcgKzQ2NSw3IEBAIHN0YXRpYyBpbnQgc3lucHNf ZWRhY19tY19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogCiAJcHJpdiA9IG1j aS0+cHZ0X2luZm87CiAJcHJpdi0+YmFzZWFkZHIgPSBiYXNlYWRkcjsKLQlyYyA9IHN5bnBzX2Vk YWNfbWNfaW5pdChtY2ksIHBkZXYpOworCXJjID0gbWNfaW5pdChtY2ksIHBkZXYpOwogCWlmIChy YykgewogCQllZGFjX3ByaW50ayhLRVJOX0VSUiwgRURBQ19NQywKIAkJCSAgICAiRmFpbGVkIHRv IGluaXRpYWxpemUgaW5zdGFuY2VcbiIpOwpAQCAtNDk2LDEyICs0OTMsMTIgQEAgc3RhdGljIGlu dCBzeW5wc19lZGFjX21jX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiB9CiAK IC8qKgotICogc3lucHNfZWRhY19tY19yZW1vdmUgLSBVbmJpbmQgZHJpdmVyIGZyb20gY29udHJv bGxlcgorICogbWNfcmVtb3ZlIC0gVW5iaW5kIGRyaXZlciBmcm9tIGNvbnRyb2xsZXIKICAqIEBw ZGV2OglQb2ludGVyIHRvIHRoZSBwbGF0Zm9ybV9kZXZpY2Ugc3RydWN0CiAgKgogICogUmV0dXJu OiBVbmNvbmRpdGlvbmFsbHkgMAogICovCi1zdGF0aWMgaW50IHN5bnBzX2VkYWNfbWNfcmVtb3Zl KHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCitzdGF0aWMgaW50IG1jX3JlbW92ZShzdHJ1 Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogewogCXN0cnVjdCBtZW1fY3RsX2luZm8gKm1jaSA9 IHBsYXRmb3JtX2dldF9kcnZkYXRhKHBkZXYpOwogCkBAIC01MjMsOCArNTIwLDggQEAgc3RhdGlj IHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgc3lucHNfZWRhY19tY19kcml2ZXIgPSB7CiAJCSAgIC5u YW1lID0gInN5bm9wc3lzLWVkYWMiLAogCQkgICAub2ZfbWF0Y2hfdGFibGUgPSBzeW5wc19lZGFj X21hdGNoLAogCQkgICB9LAotCS5wcm9iZSA9IHN5bnBzX2VkYWNfbWNfcHJvYmUsCi0JLnJlbW92 ZSA9IHN5bnBzX2VkYWNfbWNfcmVtb3ZlLAorCS5wcm9iZSA9IG1jX3Byb2JlLAorCS5yZW1vdmUg PSBtY19yZW1vdmUsCiB9OwogCiBtb2R1bGVfcGxhdGZvcm1fZHJpdmVyKHN5bnBzX2VkYWNfbWNf ZHJpdmVyKTsK From mboxrd@z Thu Jan 1 00:00:00 1970 From: bp@alien8.de (Borislav Petkov) Date: Thu, 4 Oct 2018 22:35:40 +0200 Subject: [PATCH v8 02/10] edac: synopsys: Rename the static functions to a shorter name In-Reply-To: <1538667328-9465-3-git-send-email-manish.narani@xilinx.com> References: <1538667328-9465-1-git-send-email-manish.narani@xilinx.com> <1538667328-9465-3-git-send-email-manish.narani@xilinx.com> Message-ID: <20181004203540.GD5149@zn.tnic> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Oct 04, 2018 at 09:05:20PM +0530, Manish Narani wrote: > Rename the static functions to a shorter name. Since this is Synopsys > EDAC driver, better to remove unnecessary 'synps_' prefix in function > names. > > Signed-off-by: Manish Narani > --- > drivers/edac/synopsys_edac.c | 56 ++++++++++++++++++++++---------------------- > 1 file changed, 28 insertions(+), 28 deletions(-) Ok, let's flip the roles - now you get to review what I've committed: --- From: Manish Narani Date: Thu, 4 Oct 2018 21:05:20 +0530 Subject: [PATCH 1/2] EDAC, synopsys: Shorten static function names Shorten static function names, remove the unnecessary 'synps_' prefix in function names. [ bp: Drop the "edac_" prefix too as that prefix is reserved for EDAC core functions. ] Signed-off-by: Manish Narani Signed-off-by: Borislav Petkov CC: Mauro Carvalho Chehab CC: Michal Simek CC: amit.kucheria at linaro.org CC: devicetree at vger.kernel.org CC: leoyang.li at nxp.com CC: linux-arm-kernel at lists.infradead.org CC: linux-edac CC: mark.rutland at arm.com CC: robh+dt at kernel.org CC: sudeep.holla at arm.com Link: http://lkml.kernel.org/r/1538667328-9465-3-git-send-email-manish.narani at xilinx.com --- drivers/edac/synopsys_edac.c | 79 +++++++++++++++++------------------- 1 file changed, 38 insertions(+), 41 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index 1936c73f1d15..fbaf33540ce3 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -142,7 +142,7 @@ struct synps_edac_priv { }; /** - * synps_edac_geterror_info - Get the current ecc error info + * get_error_info - Get the current ecc error info * @base: Pointer to the base address of the ddr memory controller * @p: Pointer to the synopsys ecc status structure * @@ -150,8 +150,7 @@ struct synps_edac_priv { * * Return: one if there is no error otherwise returns zero */ -static int synps_edac_geterror_info(void __iomem *base, - struct synps_ecc_status *p) +static int get_error_info(void __iomem *base, struct synps_ecc_status *p) { u32 regval, clearval = 0; @@ -196,14 +195,13 @@ static int synps_edac_geterror_info(void __iomem *base, } /** - * synps_edac_handle_error - Handle controller error types CE and UE + * handle_error - Handle controller error types CE and UE * @mci: Pointer to the edac memory controller instance * @p: Pointer to the synopsys ecc status structure * - * Handles the controller ECC correctable and un correctable error. + * Handles the controller ECC correctable and uncorrectable error. */ -static void synps_edac_handle_error(struct mem_ctl_info *mci, - struct synps_ecc_status *p) +static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) { struct synps_edac_priv *priv = mci->pvt_info; struct ecc_error_info *pinf; @@ -232,30 +230,30 @@ static void synps_edac_handle_error(struct mem_ctl_info *mci, } /** - * synps_edac_check - Check controller for ECC errors + * check_errors - Check controller for ECC errors * @mci: Pointer to the edac memory controller instance * * Used to check and post ECC errors. Called by the polling thread */ -static void synps_edac_check(struct mem_ctl_info *mci) +static void check_errors(struct mem_ctl_info *mci) { struct synps_edac_priv *priv = mci->pvt_info; int status; - status = synps_edac_geterror_info(priv->baseaddr, &priv->stat); + status = get_error_info(priv->baseaddr, &priv->stat); if (status) return; priv->ce_cnt += priv->stat.ce_cnt; priv->ue_cnt += priv->stat.ue_cnt; - synps_edac_handle_error(mci, &priv->stat); + handle_error(mci, &priv->stat); edac_dbg(3, "Total error count CE %d UE %d\n", priv->ce_cnt, priv->ue_cnt); } /** - * synps_edac_get_dtype - Return the controller memory width + * get_dtype - Return the controller memory width * @base: Pointer to the ddr memory controller base address * * Get the EDAC device type width appropriate for the current controller @@ -263,7 +261,7 @@ static void synps_edac_check(struct mem_ctl_info *mci) * * Return: a device type width enumeration. */ -static enum dev_type synps_edac_get_dtype(const void __iomem *base) +static enum dev_type get_dtype(const void __iomem *base) { enum dev_type dt; u32 width; @@ -286,20 +284,20 @@ static enum dev_type synps_edac_get_dtype(const void __iomem *base) } /** - * synps_edac_get_eccstate - Return the controller ecc enable/disable status - * @base: Pointer to the ddr memory controller base address + * get_ecc_state - Return the controller ECC enable/disable status + * @base: Pointer to the DDR memory controller base address * - * Get the ECC enable/disable status for the controller + * Get the ECC enable/disable status for the controller. * - * Return: a ecc status boolean i.e true/false - enabled/disabled. + * Return: a ECC status boolean i.e true/false - enabled/disabled. */ -static bool synps_edac_get_eccstate(void __iomem *base) +static bool get_ecc_state(void __iomem *base) { bool state = false; enum dev_type dt; u32 ecctype; - dt = synps_edac_get_dtype(base); + dt = get_dtype(base); if (dt == DEV_UNKNOWN) return state; @@ -311,11 +309,11 @@ static bool synps_edac_get_eccstate(void __iomem *base) } /** - * synps_edac_get_memsize - reads the size of the attached memory device + * get_memsize - reads the size of the attached memory device * * Return: the memory size in bytes */ -static u32 synps_edac_get_memsize(void) +static u32 get_memsize(void) { struct sysinfo inf; @@ -325,7 +323,7 @@ static u32 synps_edac_get_memsize(void) } /** - * synps_edac_get_mtype - Returns controller memory type + * get_mtype - Returns controller memory type * @base: pointer to the synopsys ecc status structure * * Get the EDAC memory type appropriate for the current controller @@ -333,7 +331,7 @@ static u32 synps_edac_get_memsize(void) * * Return: a memory type enumeration. */ -static enum mem_type synps_edac_get_mtype(const void __iomem *base) +static enum mem_type get_mtype(const void __iomem *base) { enum mem_type mt; u32 memtype; @@ -349,7 +347,7 @@ static enum mem_type synps_edac_get_mtype(const void __iomem *base) } /** - * synps_edac_init_csrows - Initialize the cs row data + * init_csrows - Initialize the cs row data * @mci: Pointer to the edac memory controller instance * * Initializes the chip select rows associated with the EDAC memory @@ -357,7 +355,7 @@ static enum mem_type synps_edac_get_mtype(const void __iomem *base) * * Return: Unconditionally 0. */ -static int synps_edac_init_csrows(struct mem_ctl_info *mci) +static int init_csrows(struct mem_ctl_info *mci) { struct synps_edac_priv *priv = mci->pvt_info; struct csrow_info *csi; @@ -367,15 +365,15 @@ static int synps_edac_init_csrows(struct mem_ctl_info *mci) for (row = 0; row < mci->nr_csrows; row++) { csi = mci->csrows[row]; - size = synps_edac_get_memsize(); + size = get_memsize(); for (j = 0; j < csi->nr_channels; j++) { dimm = csi->channels[j]->dimm; dimm->edac_mode = EDAC_FLAG_SECDED; - dimm->mtype = synps_edac_get_mtype(priv->baseaddr); + dimm->mtype = get_mtype(priv->baseaddr); dimm->nr_pages = (size >> PAGE_SHIFT) / csi->nr_channels; dimm->grain = SYNPS_EDAC_ERR_GRAIN; - dimm->dtype = synps_edac_get_dtype(priv->baseaddr); + dimm->dtype = get_dtype(priv->baseaddr); } } @@ -383,7 +381,7 @@ static int synps_edac_init_csrows(struct mem_ctl_info *mci) } /** - * synps_edac_mc_init - Initialize driver instance + * mc_init - Initialize driver instance * @mci: Pointer to the edac memory controller instance * @pdev: Pointer to the platform_device struct * @@ -393,8 +391,7 @@ static int synps_edac_init_csrows(struct mem_ctl_info *mci) * * Return: Always zero. */ -static int synps_edac_mc_init(struct mem_ctl_info *mci, - struct platform_device *pdev) +static int mc_init(struct mem_ctl_info *mci, struct platform_device *pdev) { int status; struct synps_edac_priv *priv; @@ -415,16 +412,16 @@ static int synps_edac_mc_init(struct mem_ctl_info *mci, mci->mod_name = SYNPS_EDAC_MOD_VER; edac_op_state = EDAC_OPSTATE_POLL; - mci->edac_check = synps_edac_check; + mci->edac_check = check_errors; mci->ctl_page_to_phys = NULL; - status = synps_edac_init_csrows(mci); + status = init_csrows(mci); return status; } /** - * synps_edac_mc_probe - Check controller and bind driver + * mc_probe - Check controller and bind driver * @pdev: Pointer to the platform_device struct * * Probes a specific controller instance for binding with the driver. @@ -432,7 +429,7 @@ static int synps_edac_mc_init(struct mem_ctl_info *mci, * Return: 0 if the controller instance was successfully bound to the * driver; otherwise, < 0 on error. */ -static int synps_edac_mc_probe(struct platform_device *pdev) +static int mc_probe(struct platform_device *pdev) { struct edac_mc_layer layers[2]; struct synps_edac_priv *priv; @@ -446,7 +443,7 @@ static int synps_edac_mc_probe(struct platform_device *pdev) if (IS_ERR(baseaddr)) return PTR_ERR(baseaddr); - if (!synps_edac_get_eccstate(baseaddr)) { + if (!get_ecc_state(baseaddr)) { edac_printk(KERN_INFO, EDAC_MC, "ECC not enabled\n"); return -ENXIO; } @@ -468,7 +465,7 @@ static int synps_edac_mc_probe(struct platform_device *pdev) priv = mci->pvt_info; priv->baseaddr = baseaddr; - rc = synps_edac_mc_init(mci, pdev); + rc = mc_init(mci, pdev); if (rc) { edac_printk(KERN_ERR, EDAC_MC, "Failed to initialize instance\n"); @@ -496,12 +493,12 @@ static int synps_edac_mc_probe(struct platform_device *pdev) } /** - * synps_edac_mc_remove - Unbind driver from controller + * mc_remove - Unbind driver from controller * @pdev: Pointer to the platform_device struct * * Return: Unconditionally 0 */ -static int synps_edac_mc_remove(struct platform_device *pdev) +static int mc_remove(struct platform_device *pdev) { struct mem_ctl_info *mci = platform_get_drvdata(pdev); @@ -523,8 +520,8 @@ static struct platform_driver synps_edac_mc_driver = { .name = "synopsys-edac", .of_match_table = synps_edac_match, }, - .probe = synps_edac_mc_probe, - .remove = synps_edac_mc_remove, + .probe = mc_probe, + .remove = mc_remove, }; module_platform_driver(synps_edac_mc_driver); -- 2.19.0.271.gfe8321ec057f -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v8 02/10] edac: synopsys: Rename the static functions to a shorter name Date: Thu, 4 Oct 2018 22:35:40 +0200 Message-ID: <20181004203540.GD5149@zn.tnic> References: <1538667328-9465-1-git-send-email-manish.narani@xilinx.com> <1538667328-9465-3-git-send-email-manish.narani@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1538667328-9465-3-git-send-email-manish.narani@xilinx.com> Sender: linux-kernel-owner@vger.kernel.org To: Manish Narani Cc: robh+dt@kernel.org, mark.rutland@arm.com, michal.simek@xilinx.com, mchehab@kernel.org, sudeep.holla@arm.com, amit.kucheria@linaro.org, leoyang.li@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu, Oct 04, 2018 at 09:05:20PM +0530, Manish Narani wrote: > Rename the static functions to a shorter name. Since this is Synopsys > EDAC driver, better to remove unnecessary 'synps_' prefix in function > names. > > Signed-off-by: Manish Narani > --- > drivers/edac/synopsys_edac.c | 56 ++++++++++++++++++++++---------------------- > 1 file changed, 28 insertions(+), 28 deletions(-) Ok, let's flip the roles - now you get to review what I've committed: --- From: Manish Narani Date: Thu, 4 Oct 2018 21:05:20 +0530 Subject: [PATCH 1/2] EDAC, synopsys: Shorten static function names Shorten static function names, remove the unnecessary 'synps_' prefix in function names. [ bp: Drop the "edac_" prefix too as that prefix is reserved for EDAC core functions. ] Signed-off-by: Manish Narani Signed-off-by: Borislav Petkov CC: Mauro Carvalho Chehab CC: Michal Simek CC: amit.kucheria@linaro.org CC: devicetree@vger.kernel.org CC: leoyang.li@nxp.com CC: linux-arm-kernel@lists.infradead.org CC: linux-edac CC: mark.rutland@arm.com CC: robh+dt@kernel.org CC: sudeep.holla@arm.com Link: http://lkml.kernel.org/r/1538667328-9465-3-git-send-email-manish.narani@xilinx.com --- drivers/edac/synopsys_edac.c | 79 +++++++++++++++++------------------- 1 file changed, 38 insertions(+), 41 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index 1936c73f1d15..fbaf33540ce3 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -142,7 +142,7 @@ struct synps_edac_priv { }; /** - * synps_edac_geterror_info - Get the current ecc error info + * get_error_info - Get the current ecc error info * @base: Pointer to the base address of the ddr memory controller * @p: Pointer to the synopsys ecc status structure * @@ -150,8 +150,7 @@ struct synps_edac_priv { * * Return: one if there is no error otherwise returns zero */ -static int synps_edac_geterror_info(void __iomem *base, - struct synps_ecc_status *p) +static int get_error_info(void __iomem *base, struct synps_ecc_status *p) { u32 regval, clearval = 0; @@ -196,14 +195,13 @@ static int synps_edac_geterror_info(void __iomem *base, } /** - * synps_edac_handle_error - Handle controller error types CE and UE + * handle_error - Handle controller error types CE and UE * @mci: Pointer to the edac memory controller instance * @p: Pointer to the synopsys ecc status structure * - * Handles the controller ECC correctable and un correctable error. + * Handles the controller ECC correctable and uncorrectable error. */ -static void synps_edac_handle_error(struct mem_ctl_info *mci, - struct synps_ecc_status *p) +static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) { struct synps_edac_priv *priv = mci->pvt_info; struct ecc_error_info *pinf; @@ -232,30 +230,30 @@ static void synps_edac_handle_error(struct mem_ctl_info *mci, } /** - * synps_edac_check - Check controller for ECC errors + * check_errors - Check controller for ECC errors * @mci: Pointer to the edac memory controller instance * * Used to check and post ECC errors. Called by the polling thread */ -static void synps_edac_check(struct mem_ctl_info *mci) +static void check_errors(struct mem_ctl_info *mci) { struct synps_edac_priv *priv = mci->pvt_info; int status; - status = synps_edac_geterror_info(priv->baseaddr, &priv->stat); + status = get_error_info(priv->baseaddr, &priv->stat); if (status) return; priv->ce_cnt += priv->stat.ce_cnt; priv->ue_cnt += priv->stat.ue_cnt; - synps_edac_handle_error(mci, &priv->stat); + handle_error(mci, &priv->stat); edac_dbg(3, "Total error count CE %d UE %d\n", priv->ce_cnt, priv->ue_cnt); } /** - * synps_edac_get_dtype - Return the controller memory width + * get_dtype - Return the controller memory width * @base: Pointer to the ddr memory controller base address * * Get the EDAC device type width appropriate for the current controller @@ -263,7 +261,7 @@ static void synps_edac_check(struct mem_ctl_info *mci) * * Return: a device type width enumeration. */ -static enum dev_type synps_edac_get_dtype(const void __iomem *base) +static enum dev_type get_dtype(const void __iomem *base) { enum dev_type dt; u32 width; @@ -286,20 +284,20 @@ static enum dev_type synps_edac_get_dtype(const void __iomem *base) } /** - * synps_edac_get_eccstate - Return the controller ecc enable/disable status - * @base: Pointer to the ddr memory controller base address + * get_ecc_state - Return the controller ECC enable/disable status + * @base: Pointer to the DDR memory controller base address * - * Get the ECC enable/disable status for the controller + * Get the ECC enable/disable status for the controller. * - * Return: a ecc status boolean i.e true/false - enabled/disabled. + * Return: a ECC status boolean i.e true/false - enabled/disabled. */ -static bool synps_edac_get_eccstate(void __iomem *base) +static bool get_ecc_state(void __iomem *base) { bool state = false; enum dev_type dt; u32 ecctype; - dt = synps_edac_get_dtype(base); + dt = get_dtype(base); if (dt == DEV_UNKNOWN) return state; @@ -311,11 +309,11 @@ static bool synps_edac_get_eccstate(void __iomem *base) } /** - * synps_edac_get_memsize - reads the size of the attached memory device + * get_memsize - reads the size of the attached memory device * * Return: the memory size in bytes */ -static u32 synps_edac_get_memsize(void) +static u32 get_memsize(void) { struct sysinfo inf; @@ -325,7 +323,7 @@ static u32 synps_edac_get_memsize(void) } /** - * synps_edac_get_mtype - Returns controller memory type + * get_mtype - Returns controller memory type * @base: pointer to the synopsys ecc status structure * * Get the EDAC memory type appropriate for the current controller @@ -333,7 +331,7 @@ static u32 synps_edac_get_memsize(void) * * Return: a memory type enumeration. */ -static enum mem_type synps_edac_get_mtype(const void __iomem *base) +static enum mem_type get_mtype(const void __iomem *base) { enum mem_type mt; u32 memtype; @@ -349,7 +347,7 @@ static enum mem_type synps_edac_get_mtype(const void __iomem *base) } /** - * synps_edac_init_csrows - Initialize the cs row data + * init_csrows - Initialize the cs row data * @mci: Pointer to the edac memory controller instance * * Initializes the chip select rows associated with the EDAC memory @@ -357,7 +355,7 @@ static enum mem_type synps_edac_get_mtype(const void __iomem *base) * * Return: Unconditionally 0. */ -static int synps_edac_init_csrows(struct mem_ctl_info *mci) +static int init_csrows(struct mem_ctl_info *mci) { struct synps_edac_priv *priv = mci->pvt_info; struct csrow_info *csi; @@ -367,15 +365,15 @@ static int synps_edac_init_csrows(struct mem_ctl_info *mci) for (row = 0; row < mci->nr_csrows; row++) { csi = mci->csrows[row]; - size = synps_edac_get_memsize(); + size = get_memsize(); for (j = 0; j < csi->nr_channels; j++) { dimm = csi->channels[j]->dimm; dimm->edac_mode = EDAC_FLAG_SECDED; - dimm->mtype = synps_edac_get_mtype(priv->baseaddr); + dimm->mtype = get_mtype(priv->baseaddr); dimm->nr_pages = (size >> PAGE_SHIFT) / csi->nr_channels; dimm->grain = SYNPS_EDAC_ERR_GRAIN; - dimm->dtype = synps_edac_get_dtype(priv->baseaddr); + dimm->dtype = get_dtype(priv->baseaddr); } } @@ -383,7 +381,7 @@ static int synps_edac_init_csrows(struct mem_ctl_info *mci) } /** - * synps_edac_mc_init - Initialize driver instance + * mc_init - Initialize driver instance * @mci: Pointer to the edac memory controller instance * @pdev: Pointer to the platform_device struct * @@ -393,8 +391,7 @@ static int synps_edac_init_csrows(struct mem_ctl_info *mci) * * Return: Always zero. */ -static int synps_edac_mc_init(struct mem_ctl_info *mci, - struct platform_device *pdev) +static int mc_init(struct mem_ctl_info *mci, struct platform_device *pdev) { int status; struct synps_edac_priv *priv; @@ -415,16 +412,16 @@ static int synps_edac_mc_init(struct mem_ctl_info *mci, mci->mod_name = SYNPS_EDAC_MOD_VER; edac_op_state = EDAC_OPSTATE_POLL; - mci->edac_check = synps_edac_check; + mci->edac_check = check_errors; mci->ctl_page_to_phys = NULL; - status = synps_edac_init_csrows(mci); + status = init_csrows(mci); return status; } /** - * synps_edac_mc_probe - Check controller and bind driver + * mc_probe - Check controller and bind driver * @pdev: Pointer to the platform_device struct * * Probes a specific controller instance for binding with the driver. @@ -432,7 +429,7 @@ static int synps_edac_mc_init(struct mem_ctl_info *mci, * Return: 0 if the controller instance was successfully bound to the * driver; otherwise, < 0 on error. */ -static int synps_edac_mc_probe(struct platform_device *pdev) +static int mc_probe(struct platform_device *pdev) { struct edac_mc_layer layers[2]; struct synps_edac_priv *priv; @@ -446,7 +443,7 @@ static int synps_edac_mc_probe(struct platform_device *pdev) if (IS_ERR(baseaddr)) return PTR_ERR(baseaddr); - if (!synps_edac_get_eccstate(baseaddr)) { + if (!get_ecc_state(baseaddr)) { edac_printk(KERN_INFO, EDAC_MC, "ECC not enabled\n"); return -ENXIO; } @@ -468,7 +465,7 @@ static int synps_edac_mc_probe(struct platform_device *pdev) priv = mci->pvt_info; priv->baseaddr = baseaddr; - rc = synps_edac_mc_init(mci, pdev); + rc = mc_init(mci, pdev); if (rc) { edac_printk(KERN_ERR, EDAC_MC, "Failed to initialize instance\n"); @@ -496,12 +493,12 @@ static int synps_edac_mc_probe(struct platform_device *pdev) } /** - * synps_edac_mc_remove - Unbind driver from controller + * mc_remove - Unbind driver from controller * @pdev: Pointer to the platform_device struct * * Return: Unconditionally 0 */ -static int synps_edac_mc_remove(struct platform_device *pdev) +static int mc_remove(struct platform_device *pdev) { struct mem_ctl_info *mci = platform_get_drvdata(pdev); @@ -523,8 +520,8 @@ static struct platform_driver synps_edac_mc_driver = { .name = "synopsys-edac", .of_match_table = synps_edac_match, }, - .probe = synps_edac_mc_probe, - .remove = synps_edac_mc_remove, + .probe = mc_probe, + .remove = mc_remove, }; module_platform_driver(synps_edac_mc_driver); -- 2.19.0.271.gfe8321ec057f -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.