From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v8,03/10] edac: synopsys: Modify the comments in the driver From: Borislav Petkov Message-Id: <20181004203621.GE5149@zn.tnic> Date: Thu, 4 Oct 2018 22:36:21 +0200 To: Manish Narani Cc: robh+dt@kernel.org, mark.rutland@arm.com, michal.simek@xilinx.com, mchehab@kernel.org, sudeep.holla@arm.com, amit.kucheria@linaro.org, leoyang.li@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org List-ID: T24gVGh1LCBPY3QgMDQsIDIwMTggYXQgMDk6MDU6MjFQTSArMDUzMCwgTWFuaXNoIE5hcmFuaSB3 cm90ZToKPiBUaGVyZSBhcmUgc29tZSBjb21tZW50cyB3aGljaCBjYW4gYmUgdXBkYXRlZCBmb3Ig YmV0dGVyIHJlYWRhYmlsaXR5IG9mCj4gdGhlIGRyaXZlci4gVXBkYXRlIGFiYnJldmlhdGlvbnMg dG8gY2FwaXRhbCBsZXR0ZXJzIGluIHRoZSBjb21tZW50cy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBN YW5pc2ggTmFyYW5pIDxtYW5pc2gubmFyYW5pQHhpbGlueC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv ZWRhYy9zeW5vcHN5c19lZGFjLmMgfCA5OCArKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNDggaW5zZXJ0aW9ucygrKSwgNTAgZGVs ZXRpb25zKC0pCgpGcm9tOiBNYW5pc2ggTmFyYW5pIDxtYW5pc2gubmFyYW5pQHhpbGlueC5jb20+ CkRhdGU6IFRodSwgNCBPY3QgMjAxOCAyMTowNToyMSArMDUzMApTdWJqZWN0OiBbUEFUQ0ggMi8y XSBFREFDLCBzeW5vcHN5czogQ29ycmVjdCBjb21tZW50cwoKU3BlbGxjaGVjayBhbmQgaW1wcm92 ZS9jb3JyZWN0IGNvbW1lbnRzLgoKU2lnbmVkLW9mZi1ieTogTWFuaXNoIE5hcmFuaSA8bWFuaXNo Lm5hcmFuaUB4aWxpbnguY29tPgpTaWduZWQtb2ZmLWJ5OiBCb3Jpc2xhdiBQZXRrb3YgPGJwQHN1 c2UuZGU+CkNDOiBNYXVybyBDYXJ2YWxobyBDaGVoYWIgPG1jaGVoYWJAa2VybmVsLm9yZz4KQ0M6 IE1pY2hhbCBTaW1layA8bWljaGFsLnNpbWVrQHhpbGlueC5jb20+CkNDOiBhbWl0Lmt1Y2hlcmlh QGxpbmFyby5vcmcKQ0M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnCkNDOiBsZW95YW5nLmxp QG54cC5jb20KQ0M6IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpDQzogbGlu dXgtZWRhYyA8bGludXgtZWRhY0B2Z2VyLmtlcm5lbC5vcmc+CkNDOiBtYXJrLnJ1dGxhbmRAYXJt LmNvbQpDQzogbWljaGFsLnNpbWVrQHhpbGlueC5jb20KQ0M6IHJvYmgrZHRAa2VybmVsLm9yZwpD Qzogc3VkZWVwLmhvbGxhQGFybS5jb20KTGluazogaHR0cDovL2xrbWwua2VybmVsLm9yZy9yLzE1 Mzg2NjczMjgtOTQ2NS00LWdpdC1zZW5kLWVtYWlsLW1hbmlzaC5uYXJhbmlAeGlsaW54LmNvbQot LS0KIGRyaXZlcnMvZWRhYy9zeW5vcHN5c19lZGFjLmMgfCAxMDQgKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA1MSBpbnNlcnRpb25zKCspLCA1MyBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2VkYWMvc3lub3BzeXNfZWRhYy5jIGIv ZHJpdmVycy9lZGFjL3N5bm9wc3lzX2VkYWMuYwppbmRleCBmYmFmMzM1NDBjZTMuLmI0NjY2MzEw YTVmNiAxMDA2NDQKLS0tIGEvZHJpdmVycy9lZGFjL3N5bm9wc3lzX2VkYWMuYworKysgYi9kcml2 ZXJzL2VkYWMvc3lub3BzeXNfZWRhYy5jCkBAIC05NiwxMiArOTYsMTIgQEAKICNkZWZpbmUgU0NS VUJfTU9ERV9TRUNERUQJCTB4NAogCiAvKioKLSAqIHN0cnVjdCBlY2NfZXJyb3JfaW5mbyAtIEVD QyBlcnJvciBsb2cgaW5mb3JtYXRpb24KLSAqIEByb3c6CVJvdyBudW1iZXIKLSAqIEBjb2w6CUNv bHVtbiBudW1iZXIKLSAqIEBiYW5rOglCYW5rIG51bWJlcgotICogQGJpdHBvczoJQml0IHBvc2l0 aW9uCi0gKiBAZGF0YToJRGF0YSBjYXVzaW5nIHRoZSBlcnJvcgorICogc3RydWN0IGVjY19lcnJv cl9pbmZvIC0gRUNDIGVycm9yIGxvZyBpbmZvcm1hdGlvbi4KKyAqIEByb3c6CVJvdyBudW1iZXIu CisgKiBAY29sOglDb2x1bW4gbnVtYmVyLgorICogQGJhbms6CUJhbmsgbnVtYmVyLgorICogQGJp dHBvczoJQml0IHBvc2l0aW9uLgorICogQGRhdGE6CURhdGEgY2F1c2luZyB0aGUgZXJyb3IuCiAg Ki8KIHN0cnVjdCBlY2NfZXJyb3JfaW5mbyB7CiAJdTMyIHJvdzsKQEAgLTExMiwxMSArMTEyLDEx IEBAIHN0cnVjdCBlY2NfZXJyb3JfaW5mbyB7CiB9OwogCiAvKioKLSAqIHN0cnVjdCBzeW5wc19l Y2Nfc3RhdHVzIC0gRUNDIHN0YXR1cyBpbmZvcm1hdGlvbiB0byByZXBvcnQKLSAqIEBjZV9jbnQ6 CUNvcnJlY3RhYmxlIGVycm9yIGNvdW50Ci0gKiBAdWVfY250OglVbmNvcnJlY3RhYmxlIGVycm9y IGNvdW50Ci0gKiBAY2VpbmZvOglDb3JyZWN0YWJsZSBlcnJvciBsb2cgaW5mb3JtYXRpb24KLSAq IEB1ZWluZm86CVVuY29ycmVjdGFibGUgZXJyb3IgbG9nIGluZm9ybWF0aW9uCisgKiBzdHJ1Y3Qg c3lucHNfZWNjX3N0YXR1cyAtIEVDQyBzdGF0dXMgaW5mb3JtYXRpb24gdG8gcmVwb3J0LgorICog QGNlX2NudDoJQ29ycmVjdGFibGUgZXJyb3IgY291bnQuCisgKiBAdWVfY250OglVbmNvcnJlY3Rh YmxlIGVycm9yIGNvdW50LgorICogQGNlaW5mbzoJQ29ycmVjdGFibGUgZXJyb3IgbG9nIGluZm9y bWF0aW9uLgorICogQHVlaW5mbzoJVW5jb3JyZWN0YWJsZSBlcnJvciBsb2cgaW5mb3JtYXRpb24u CiAgKi8KIHN0cnVjdCBzeW5wc19lY2Nfc3RhdHVzIHsKIAl1MzIgY2VfY250OwpAQCAtMTI2LDEy ICsxMjYsMTIgQEAgc3RydWN0IHN5bnBzX2VjY19zdGF0dXMgewogfTsKIAogLyoqCi0gKiBzdHJ1 Y3Qgc3lucHNfZWRhY19wcml2IC0gRERSIG1lbW9yeSBjb250cm9sbGVyIHByaXZhdGUgaW5zdGFu Y2UgZGF0YQotICogQGJhc2VhZGRyOglCYXNlIGFkZHJlc3Mgb2YgdGhlIEREUiBjb250cm9sbGVy Ci0gKiBAbWVzc2FnZToJQnVmZmVyIGZvciBmcmFtaW5nIHRoZSBldmVudCBzcGVjaWZpYyBpbmZv Ci0gKiBAc3RhdDoJRUNDIHN0YXR1cyBpbmZvcm1hdGlvbgotICogQGNlX2NudDoJQ29ycmVjdGFi bGUgRXJyb3IgY291bnQKLSAqIEB1ZV9jbnQ6CVVuY29ycmVjdGFibGUgRXJyb3IgY291bnQKKyAq IHN0cnVjdCBzeW5wc19lZGFjX3ByaXYgLSBERFIgbWVtb3J5IGNvbnRyb2xsZXIgcHJpdmF0ZSBp bnN0YW5jZSBkYXRhLgorICogQGJhc2VhZGRyOglCYXNlIGFkZHJlc3Mgb2YgdGhlIEREUiBjb250 cm9sbGVyLgorICogQG1lc3NhZ2U6CUJ1ZmZlciBmb3IgZnJhbWluZyB0aGUgZXZlbnQgc3BlY2lm aWMgaW5mby4KKyAqIEBzdGF0OglFQ0Mgc3RhdHVzIGluZm9ybWF0aW9uLgorICogQGNlX2NudDoJ Q29ycmVjdGFibGUgRXJyb3IgY291bnQuCisgKiBAdWVfY250OglVbmNvcnJlY3RhYmxlIEVycm9y IGNvdW50LgogICovCiBzdHJ1Y3Qgc3lucHNfZWRhY19wcml2IHsKIAl2b2lkIF9faW9tZW0gKmJh c2VhZGRyOwpAQCAtMTQyLDEzICsxNDIsMTEgQEAgc3RydWN0IHN5bnBzX2VkYWNfcHJpdiB7CiB9 OwogCiAvKioKLSAqIGdldF9lcnJvcl9pbmZvIC0gR2V0IHRoZSBjdXJyZW50IGVjYyBlcnJvciBp bmZvCi0gKiBAYmFzZToJUG9pbnRlciB0byB0aGUgYmFzZSBhZGRyZXNzIG9mIHRoZSBkZHIgbWVt b3J5IGNvbnRyb2xsZXIKLSAqIEBwOgkJUG9pbnRlciB0byB0aGUgc3lub3BzeXMgZWNjIHN0YXR1 cyBzdHJ1Y3R1cmUKKyAqIGdldF9lcnJvcl9pbmZvIC0gR2V0IHRoZSBjdXJyZW50IEVDQyBlcnJv ciBpbmZvLgorICogQGJhc2U6CUJhc2UgYWRkcmVzcyBvZiB0aGUgRERSIG1lbW9yeSBjb250cm9s bGVyLgorICogQHA6CQlTeW5vcHN5cyBFQ0Mgc3RhdHVzIHN0cnVjdHVyZS4KICAqCi0gKiBEZXRl cm1pbmVzIHRoZXJlIGlzIGFueSBlY2MgZXJyb3Igb3Igbm90Ci0gKgotICogUmV0dXJuOiBvbmUg aWYgdGhlcmUgaXMgbm8gZXJyb3Igb3RoZXJ3aXNlIHJldHVybnMgemVybworICogUmV0dXJuOiBv bmUgaWYgdGhlcmUgaXMgbm8gZXJyb3Igb3RoZXJ3aXNlIHplcm8uCiAgKi8KIHN0YXRpYyBpbnQg Z2V0X2Vycm9yX2luZm8odm9pZCBfX2lvbWVtICpiYXNlLCBzdHJ1Y3Qgc3lucHNfZWNjX3N0YXR1 cyAqcCkKIHsKQEAgLTE5NSwxMSArMTkzLDExIEBAIHN0YXRpYyBpbnQgZ2V0X2Vycm9yX2luZm8o dm9pZCBfX2lvbWVtICpiYXNlLCBzdHJ1Y3Qgc3lucHNfZWNjX3N0YXR1cyAqcCkKIH0KIAogLyoq Ci0gKiBoYW5kbGVfZXJyb3IgLSBIYW5kbGUgY29udHJvbGxlciBlcnJvciB0eXBlcyBDRSBhbmQg VUUKLSAqIEBtY2k6CVBvaW50ZXIgdG8gdGhlIGVkYWMgbWVtb3J5IGNvbnRyb2xsZXIgaW5zdGFu Y2UKLSAqIEBwOgkJUG9pbnRlciB0byB0aGUgc3lub3BzeXMgZWNjIHN0YXR1cyBzdHJ1Y3R1cmUK KyAqIGhhbmRsZV9lcnJvciAtIEhhbmRsZSBDb3JyZWN0YWJsZSBhbmQgVW5jb3JyZWN0YWJsZSBl cnJvcnMuCisgKiBAbWNpOglFREFDIG1lbW9yeSBjb250cm9sbGVyIGluc3RhbmNlLgorICogQHA6 CQlTeW5vcHN5cyBFQ0Mgc3RhdHVzIHN0cnVjdHVyZS4KICAqCi0gKiBIYW5kbGVzIHRoZSBjb250 cm9sbGVyIEVDQyBjb3JyZWN0YWJsZSBhbmQgdW5jb3JyZWN0YWJsZSBlcnJvci4KKyAqIEhhbmRs ZXMgRUNDIGNvcnJlY3RhYmxlIGFuZCB1bmNvcnJlY3RhYmxlIGVycm9ycy4KICAqLwogc3RhdGlj IHZvaWQgaGFuZGxlX2Vycm9yKHN0cnVjdCBtZW1fY3RsX2luZm8gKm1jaSwgc3RydWN0IHN5bnBz X2VjY19zdGF0dXMgKnApCiB7CkBAIC0yMzAsMTAgKzIyOCwxMCBAQCBzdGF0aWMgdm9pZCBoYW5k bGVfZXJyb3Ioc3RydWN0IG1lbV9jdGxfaW5mbyAqbWNpLCBzdHJ1Y3Qgc3lucHNfZWNjX3N0YXR1 cyAqcCkKIH0KIAogLyoqCi0gKiBjaGVja19lcnJvcnMgLSBDaGVjayBjb250cm9sbGVyIGZvciBF Q0MgZXJyb3JzCi0gKiBAbWNpOglQb2ludGVyIHRvIHRoZSBlZGFjIG1lbW9yeSBjb250cm9sbGVy IGluc3RhbmNlCisgKiBjaGVja19lcnJvcnMgLSBDaGVjayBjb250cm9sbGVyIGZvciBFQ0MgZXJy b3JzLgorICogQG1jaToJRURBQyBtZW1vcnkgY29udHJvbGxlciBpbnN0YW5jZS4KICAqCi0gKiBV c2VkIHRvIGNoZWNrIGFuZCBwb3N0IEVDQyBlcnJvcnMuIENhbGxlZCBieSB0aGUgcG9sbGluZyB0 aHJlYWQKKyAqIENoZWNrIGFuZCBwb3N0IEVDQyBlcnJvcnMuIENhbGxlZCBieSB0aGUgcG9sbGlu ZyB0aHJlYWQuCiAgKi8KIHN0YXRpYyB2b2lkIGNoZWNrX2Vycm9ycyhzdHJ1Y3QgbWVtX2N0bF9p bmZvICptY2kpCiB7CkBAIC0yNTMsOCArMjUxLDggQEAgc3RhdGljIHZvaWQgY2hlY2tfZXJyb3Jz KHN0cnVjdCBtZW1fY3RsX2luZm8gKm1jaSkKIH0KIAogLyoqCi0gKiBnZXRfZHR5cGUgLSBSZXR1 cm4gdGhlIGNvbnRyb2xsZXIgbWVtb3J5IHdpZHRoCi0gKiBAYmFzZToJUG9pbnRlciB0byB0aGUg ZGRyIG1lbW9yeSBjb250cm9sbGVyIGJhc2UgYWRkcmVzcworICogZ2V0X2R0eXBlIC0gUmV0dXJu IHRoZSBjb250cm9sbGVyIG1lbW9yeSB3aWR0aC4KKyAqIEBiYXNlOglERFIgbWVtb3J5IGNvbnRy b2xsZXIgYmFzZSBhZGRyZXNzLgogICoKICAqIEdldCB0aGUgRURBQyBkZXZpY2UgdHlwZSB3aWR0 aCBhcHByb3ByaWF0ZSBmb3IgdGhlIGN1cnJlbnQgY29udHJvbGxlcgogICogY29uZmlndXJhdGlv bi4KQEAgLTI4NCwxMiArMjgyLDEyIEBAIHN0YXRpYyBlbnVtIGRldl90eXBlIGdldF9kdHlwZShj b25zdCB2b2lkIF9faW9tZW0gKmJhc2UpCiB9CiAKIC8qKgotICogZ2V0X2VjY19zdGF0ZSAtIFJl dHVybiB0aGUgY29udHJvbGxlciBFQ0MgZW5hYmxlL2Rpc2FibGUgc3RhdHVzCi0gKiBAYmFzZToJ UG9pbnRlciB0byB0aGUgRERSIG1lbW9yeSBjb250cm9sbGVyIGJhc2UgYWRkcmVzcworICogZ2V0 X2VjY19zdGF0ZSAtIFJldHVybiB0aGUgY29udHJvbGxlciBFQ0MgZW5hYmxlL2Rpc2FibGUgc3Rh dHVzLgorICogQGJhc2U6CUREUiBtZW1vcnkgY29udHJvbGxlciBiYXNlIGFkZHJlc3MuCiAgKgot ICogR2V0IHRoZSBFQ0MgZW5hYmxlL2Rpc2FibGUgc3RhdHVzIGZvciB0aGUgY29udHJvbGxlci4K KyAqIEdldCB0aGUgRUNDIGVuYWJsZS9kaXNhYmxlIHN0YXR1cyBvZiB0aGUgY29udHJvbGxlci4K ICAqCi0gKiBSZXR1cm46IGEgRUNDIHN0YXR1cyBib29sZWFuIGkuZSB0cnVlL2ZhbHNlIC0gZW5h YmxlZC9kaXNhYmxlZC4KKyAqIFJldHVybjogdHJ1ZSBpZiBlbmFibGVkLCBvdGhlcndpc2UgZmFs c2UuCiAgKi8KIHN0YXRpYyBib29sIGdldF9lY2Nfc3RhdGUodm9pZCBfX2lvbWVtICpiYXNlKQog ewpAQCAtMzA5LDkgKzMwNyw5IEBAIHN0YXRpYyBib29sIGdldF9lY2Nfc3RhdGUodm9pZCBfX2lv bWVtICpiYXNlKQogfQogCiAvKioKLSAqIGdldF9tZW1zaXplIC0gcmVhZHMgdGhlIHNpemUgb2Yg dGhlIGF0dGFjaGVkIG1lbW9yeSBkZXZpY2UKKyAqIGdldF9tZW1zaXplIC0gUmVhZCB0aGUgc2l6 ZSBvZiB0aGUgYXR0YWNoZWQgbWVtb3J5IGRldmljZS4KICAqCi0gKiBSZXR1cm46IHRoZSBtZW1v cnkgc2l6ZSBpbiBieXRlcworICogUmV0dXJuOiB0aGUgbWVtb3J5IHNpemUgaW4gYnl0ZXMuCiAg Ki8KIHN0YXRpYyB1MzIgZ2V0X21lbXNpemUodm9pZCkKIHsKQEAgLTMyMyw4ICszMjEsOCBAQCBz dGF0aWMgdTMyIGdldF9tZW1zaXplKHZvaWQpCiB9CiAKIC8qKgotICogZ2V0X210eXBlIC0gUmV0 dXJucyBjb250cm9sbGVyIG1lbW9yeSB0eXBlCi0gKiBAYmFzZToJcG9pbnRlciB0byB0aGUgc3lu b3BzeXMgZWNjIHN0YXR1cyBzdHJ1Y3R1cmUKKyAqIGdldF9tdHlwZSAtIFJldHVybiB0aGUgY29u dHJvbGxlciBtZW1vcnkgdHlwZS4KKyAqIEBiYXNlOglTeW5vcHN5cyBFQ0Mgc3RhdHVzIHN0cnVj dHVyZS4KICAqCiAgKiBHZXQgdGhlIEVEQUMgbWVtb3J5IHR5cGUgYXBwcm9wcmlhdGUgZm9yIHRo ZSBjdXJyZW50IGNvbnRyb2xsZXIKICAqIGNvbmZpZ3VyYXRpb24uCkBAIC0zNDcsMTEgKzM0NSwx MSBAQCBzdGF0aWMgZW51bSBtZW1fdHlwZSBnZXRfbXR5cGUoY29uc3Qgdm9pZCBfX2lvbWVtICpi YXNlKQogfQogCiAvKioKLSAqIGluaXRfY3Nyb3dzIC0gSW5pdGlhbGl6ZSB0aGUgY3Mgcm93IGRh dGEKLSAqIEBtY2k6CVBvaW50ZXIgdG8gdGhlIGVkYWMgbWVtb3J5IGNvbnRyb2xsZXIgaW5zdGFu Y2UKKyAqIGluaXRfY3Nyb3dzIC0gSW5pdGlhbGl6ZSB0aGUgY3Nyb3cgZGF0YS4KKyAqIEBtY2k6 CUVEQUMgbWVtb3J5IGNvbnRyb2xsZXIgaW5zdGFuY2UuCiAgKgotICogSW5pdGlhbGl6ZXMgdGhl IGNoaXAgc2VsZWN0IHJvd3MgYXNzb2NpYXRlZCB3aXRoIHRoZSBFREFDIG1lbW9yeQotICogY29u dHJvbGxlciBpbnN0YW5jZQorICogSW5pdGlhbGl6ZSB0aGUgY2hpcCBzZWxlY3Qgcm93cyBhc3Nv Y2lhdGVkIHdpdGggdGhlIEVEQUMgbWVtb3J5CisgKiBjb250cm9sbGVyIGluc3RhbmNlLgogICoK ICAqIFJldHVybjogVW5jb25kaXRpb25hbGx5IDAuCiAgKi8KQEAgLTM4MSwxMSArMzc5LDExIEBA IHN0YXRpYyBpbnQgaW5pdF9jc3Jvd3Moc3RydWN0IG1lbV9jdGxfaW5mbyAqbWNpKQogfQogCiAv KioKLSAqIG1jX2luaXQgLSBJbml0aWFsaXplIGRyaXZlciBpbnN0YW5jZQotICogQG1jaToJUG9p bnRlciB0byB0aGUgZWRhYyBtZW1vcnkgY29udHJvbGxlciBpbnN0YW5jZQotICogQHBkZXY6CVBv aW50ZXIgdG8gdGhlIHBsYXRmb3JtX2RldmljZSBzdHJ1Y3QKKyAqIG1jX2luaXQgLSBJbml0aWFs aXplIG9uZSBkcml2ZXIgaW5zdGFuY2UuCisgKiBAbWNpOglFREFDIG1lbW9yeSBjb250cm9sbGVy IGluc3RhbmNlLgorICogQHBkZXY6CXBsYXRmb3JtIGRldmljZS4KICAqCi0gKiBQZXJmb3JtcyBp bml0aWFsaXphdGlvbiBvZiB0aGUgRURBQyBtZW1vcnkgY29udHJvbGxlciBpbnN0YW5jZSBhbmQK KyAqIFBlcmZvcm0gaW5pdGlhbGl6YXRpb24gb2YgdGhlIEVEQUMgbWVtb3J5IGNvbnRyb2xsZXIg aW5zdGFuY2UgYW5kCiAgKiByZWxhdGVkIGRyaXZlci1wcml2YXRlIGRhdGEgYXNzb2NpYXRlZCB3 aXRoIHRoZSBtZW1vcnkgY29udHJvbGxlciB0aGUKICAqIGluc3RhbmNlIGlzIGJvdW5kIHRvLgog ICoKQEAgLTQyMSwxMCArNDE5LDEwIEBAIHN0YXRpYyBpbnQgbWNfaW5pdChzdHJ1Y3QgbWVtX2N0 bF9pbmZvICptY2ksIHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCiB9CiAKIC8qKgotICog bWNfcHJvYmUgLSBDaGVjayBjb250cm9sbGVyIGFuZCBiaW5kIGRyaXZlcgotICogQHBkZXY6CVBv aW50ZXIgdG8gdGhlIHBsYXRmb3JtX2RldmljZSBzdHJ1Y3QKKyAqIG1jX3Byb2JlIC0gQ2hlY2sg Y29udHJvbGxlciBhbmQgYmluZCBkcml2ZXIuCisgKiBAcGRldjoJcGxhdGZvcm0gZGV2aWNlLgog ICoKLSAqIFByb2JlcyBhIHNwZWNpZmljIGNvbnRyb2xsZXIgaW5zdGFuY2UgZm9yIGJpbmRpbmcg d2l0aCB0aGUgZHJpdmVyLgorICogUHJvYmUgYSBzcGVjaWZpYyBjb250cm9sbGVyIGluc3RhbmNl IGZvciBiaW5kaW5nIHdpdGggdGhlIGRyaXZlci4KICAqCiAgKiBSZXR1cm46IDAgaWYgdGhlIGNv bnRyb2xsZXIgaW5zdGFuY2Ugd2FzIHN1Y2Nlc3NmdWxseSBib3VuZCB0byB0aGUKICAqIGRyaXZl cjsgb3RoZXJ3aXNlLCA8IDAgb24gZXJyb3IuCkBAIC00OTMsOCArNDkxLDggQEAgc3RhdGljIGlu dCBtY19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogfQogCiAvKioKLSAqIG1j X3JlbW92ZSAtIFVuYmluZCBkcml2ZXIgZnJvbSBjb250cm9sbGVyCi0gKiBAcGRldjoJUG9pbnRl ciB0byB0aGUgcGxhdGZvcm1fZGV2aWNlIHN0cnVjdAorICogbWNfcmVtb3ZlIC0gVW5iaW5kIGRy aXZlciBmcm9tIGNvbnRyb2xsZXIuCisgKiBAcGRldjoJUGxhdGZvcm0gZGV2aWNlLgogICoKICAq IFJldHVybjogVW5jb25kaXRpb25hbGx5IDAKICAqLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: bp@alien8.de (Borislav Petkov) Date: Thu, 4 Oct 2018 22:36:21 +0200 Subject: [PATCH v8 03/10] edac: synopsys: Modify the comments in the driver In-Reply-To: <1538667328-9465-4-git-send-email-manish.narani@xilinx.com> References: <1538667328-9465-1-git-send-email-manish.narani@xilinx.com> <1538667328-9465-4-git-send-email-manish.narani@xilinx.com> Message-ID: <20181004203621.GE5149@zn.tnic> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Oct 04, 2018 at 09:05:21PM +0530, Manish Narani wrote: > There are some comments which can be updated for better readability of > the driver. Update abbreviations to capital letters in the comments. > > Signed-off-by: Manish Narani > --- > drivers/edac/synopsys_edac.c | 98 ++++++++++++++++++++++---------------------- > 1 file changed, 48 insertions(+), 50 deletions(-) From: Manish Narani Date: Thu, 4 Oct 2018 21:05:21 +0530 Subject: [PATCH 2/2] EDAC, synopsys: Correct comments Spellcheck and improve/correct comments. Signed-off-by: Manish Narani Signed-off-by: Borislav Petkov CC: Mauro Carvalho Chehab CC: Michal Simek CC: amit.kucheria at linaro.org CC: devicetree at vger.kernel.org CC: leoyang.li at nxp.com CC: linux-arm-kernel at lists.infradead.org CC: linux-edac CC: mark.rutland at arm.com CC: michal.simek at xilinx.com CC: robh+dt at kernel.org CC: sudeep.holla at arm.com Link: http://lkml.kernel.org/r/1538667328-9465-4-git-send-email-manish.narani at xilinx.com --- drivers/edac/synopsys_edac.c | 104 +++++++++++++++++------------------ 1 file changed, 51 insertions(+), 53 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index fbaf33540ce3..b4666310a5f6 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -96,12 +96,12 @@ #define SCRUB_MODE_SECDED 0x4 /** - * struct ecc_error_info - ECC error log information - * @row: Row number - * @col: Column number - * @bank: Bank number - * @bitpos: Bit position - * @data: Data causing the error + * struct ecc_error_info - ECC error log information. + * @row: Row number. + * @col: Column number. + * @bank: Bank number. + * @bitpos: Bit position. + * @data: Data causing the error. */ struct ecc_error_info { u32 row; @@ -112,11 +112,11 @@ struct ecc_error_info { }; /** - * struct synps_ecc_status - ECC status information to report - * @ce_cnt: Correctable error count - * @ue_cnt: Uncorrectable error count - * @ceinfo: Correctable error log information - * @ueinfo: Uncorrectable error log information + * struct synps_ecc_status - ECC status information to report. + * @ce_cnt: Correctable error count. + * @ue_cnt: Uncorrectable error count. + * @ceinfo: Correctable error log information. + * @ueinfo: Uncorrectable error log information. */ struct synps_ecc_status { u32 ce_cnt; @@ -126,12 +126,12 @@ struct synps_ecc_status { }; /** - * struct synps_edac_priv - DDR memory controller private instance data - * @baseaddr: Base address of the DDR controller - * @message: Buffer for framing the event specific info - * @stat: ECC status information - * @ce_cnt: Correctable Error count - * @ue_cnt: Uncorrectable Error count + * struct synps_edac_priv - DDR memory controller private instance data. + * @baseaddr: Base address of the DDR controller. + * @message: Buffer for framing the event specific info. + * @stat: ECC status information. + * @ce_cnt: Correctable Error count. + * @ue_cnt: Uncorrectable Error count. */ struct synps_edac_priv { void __iomem *baseaddr; @@ -142,13 +142,11 @@ struct synps_edac_priv { }; /** - * get_error_info - Get the current ecc error info - * @base: Pointer to the base address of the ddr memory controller - * @p: Pointer to the synopsys ecc status structure + * get_error_info - Get the current ECC error info. + * @base: Base address of the DDR memory controller. + * @p: Synopsys ECC status structure. * - * Determines there is any ecc error or not - * - * Return: one if there is no error otherwise returns zero + * Return: one if there is no error otherwise zero. */ static int get_error_info(void __iomem *base, struct synps_ecc_status *p) { @@ -195,11 +193,11 @@ static int get_error_info(void __iomem *base, struct synps_ecc_status *p) } /** - * handle_error - Handle controller error types CE and UE - * @mci: Pointer to the edac memory controller instance - * @p: Pointer to the synopsys ecc status structure + * handle_error - Handle Correctable and Uncorrectable errors. + * @mci: EDAC memory controller instance. + * @p: Synopsys ECC status structure. * - * Handles the controller ECC correctable and uncorrectable error. + * Handles ECC correctable and uncorrectable errors. */ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) { @@ -230,10 +228,10 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) } /** - * check_errors - Check controller for ECC errors - * @mci: Pointer to the edac memory controller instance + * check_errors - Check controller for ECC errors. + * @mci: EDAC memory controller instance. * - * Used to check and post ECC errors. Called by the polling thread + * Check and post ECC errors. Called by the polling thread. */ static void check_errors(struct mem_ctl_info *mci) { @@ -253,8 +251,8 @@ static void check_errors(struct mem_ctl_info *mci) } /** - * get_dtype - Return the controller memory width - * @base: Pointer to the ddr memory controller base address + * get_dtype - Return the controller memory width. + * @base: DDR memory controller base address. * * Get the EDAC device type width appropriate for the current controller * configuration. @@ -284,12 +282,12 @@ static enum dev_type get_dtype(const void __iomem *base) } /** - * get_ecc_state - Return the controller ECC enable/disable status - * @base: Pointer to the DDR memory controller base address + * get_ecc_state - Return the controller ECC enable/disable status. + * @base: DDR memory controller base address. * - * Get the ECC enable/disable status for the controller. + * Get the ECC enable/disable status of the controller. * - * Return: a ECC status boolean i.e true/false - enabled/disabled. + * Return: true if enabled, otherwise false. */ static bool get_ecc_state(void __iomem *base) { @@ -309,9 +307,9 @@ static bool get_ecc_state(void __iomem *base) } /** - * get_memsize - reads the size of the attached memory device + * get_memsize - Read the size of the attached memory device. * - * Return: the memory size in bytes + * Return: the memory size in bytes. */ static u32 get_memsize(void) { @@ -323,8 +321,8 @@ static u32 get_memsize(void) } /** - * get_mtype - Returns controller memory type - * @base: pointer to the synopsys ecc status structure + * get_mtype - Return the controller memory type. + * @base: Synopsys ECC status structure. * * Get the EDAC memory type appropriate for the current controller * configuration. @@ -347,11 +345,11 @@ static enum mem_type get_mtype(const void __iomem *base) } /** - * init_csrows - Initialize the cs row data - * @mci: Pointer to the edac memory controller instance + * init_csrows - Initialize the csrow data. + * @mci: EDAC memory controller instance. * - * Initializes the chip select rows associated with the EDAC memory - * controller instance + * Initialize the chip select rows associated with the EDAC memory + * controller instance. * * Return: Unconditionally 0. */ @@ -381,11 +379,11 @@ static int init_csrows(struct mem_ctl_info *mci) } /** - * mc_init - Initialize driver instance - * @mci: Pointer to the edac memory controller instance - * @pdev: Pointer to the platform_device struct + * mc_init - Initialize one driver instance. + * @mci: EDAC memory controller instance. + * @pdev: platform device. * - * Performs initialization of the EDAC memory controller instance and + * Perform initialization of the EDAC memory controller instance and * related driver-private data associated with the memory controller the * instance is bound to. * @@ -421,10 +419,10 @@ static int mc_init(struct mem_ctl_info *mci, struct platform_device *pdev) } /** - * mc_probe - Check controller and bind driver - * @pdev: Pointer to the platform_device struct + * mc_probe - Check controller and bind driver. + * @pdev: platform device. * - * Probes a specific controller instance for binding with the driver. + * Probe a specific controller instance for binding with the driver. * * Return: 0 if the controller instance was successfully bound to the * driver; otherwise, < 0 on error. @@ -493,8 +491,8 @@ static int mc_probe(struct platform_device *pdev) } /** - * mc_remove - Unbind driver from controller - * @pdev: Pointer to the platform_device struct + * mc_remove - Unbind driver from controller. + * @pdev: Platform device. * * Return: Unconditionally 0 */ -- 2.19.0.271.gfe8321ec057f -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v8 03/10] edac: synopsys: Modify the comments in the driver Date: Thu, 4 Oct 2018 22:36:21 +0200 Message-ID: <20181004203621.GE5149@zn.tnic> References: <1538667328-9465-1-git-send-email-manish.narani@xilinx.com> <1538667328-9465-4-git-send-email-manish.narani@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1538667328-9465-4-git-send-email-manish.narani@xilinx.com> Sender: linux-kernel-owner@vger.kernel.org To: Manish Narani Cc: robh+dt@kernel.org, mark.rutland@arm.com, michal.simek@xilinx.com, mchehab@kernel.org, sudeep.holla@arm.com, amit.kucheria@linaro.org, leoyang.li@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu, Oct 04, 2018 at 09:05:21PM +0530, Manish Narani wrote: > There are some comments which can be updated for better readability of > the driver. Update abbreviations to capital letters in the comments. > > Signed-off-by: Manish Narani > --- > drivers/edac/synopsys_edac.c | 98 ++++++++++++++++++++++---------------------- > 1 file changed, 48 insertions(+), 50 deletions(-) From: Manish Narani Date: Thu, 4 Oct 2018 21:05:21 +0530 Subject: [PATCH 2/2] EDAC, synopsys: Correct comments Spellcheck and improve/correct comments. Signed-off-by: Manish Narani Signed-off-by: Borislav Petkov CC: Mauro Carvalho Chehab CC: Michal Simek CC: amit.kucheria@linaro.org CC: devicetree@vger.kernel.org CC: leoyang.li@nxp.com CC: linux-arm-kernel@lists.infradead.org CC: linux-edac CC: mark.rutland@arm.com CC: michal.simek@xilinx.com CC: robh+dt@kernel.org CC: sudeep.holla@arm.com Link: http://lkml.kernel.org/r/1538667328-9465-4-git-send-email-manish.narani@xilinx.com --- drivers/edac/synopsys_edac.c | 104 +++++++++++++++++------------------ 1 file changed, 51 insertions(+), 53 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index fbaf33540ce3..b4666310a5f6 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -96,12 +96,12 @@ #define SCRUB_MODE_SECDED 0x4 /** - * struct ecc_error_info - ECC error log information - * @row: Row number - * @col: Column number - * @bank: Bank number - * @bitpos: Bit position - * @data: Data causing the error + * struct ecc_error_info - ECC error log information. + * @row: Row number. + * @col: Column number. + * @bank: Bank number. + * @bitpos: Bit position. + * @data: Data causing the error. */ struct ecc_error_info { u32 row; @@ -112,11 +112,11 @@ struct ecc_error_info { }; /** - * struct synps_ecc_status - ECC status information to report - * @ce_cnt: Correctable error count - * @ue_cnt: Uncorrectable error count - * @ceinfo: Correctable error log information - * @ueinfo: Uncorrectable error log information + * struct synps_ecc_status - ECC status information to report. + * @ce_cnt: Correctable error count. + * @ue_cnt: Uncorrectable error count. + * @ceinfo: Correctable error log information. + * @ueinfo: Uncorrectable error log information. */ struct synps_ecc_status { u32 ce_cnt; @@ -126,12 +126,12 @@ struct synps_ecc_status { }; /** - * struct synps_edac_priv - DDR memory controller private instance data - * @baseaddr: Base address of the DDR controller - * @message: Buffer for framing the event specific info - * @stat: ECC status information - * @ce_cnt: Correctable Error count - * @ue_cnt: Uncorrectable Error count + * struct synps_edac_priv - DDR memory controller private instance data. + * @baseaddr: Base address of the DDR controller. + * @message: Buffer for framing the event specific info. + * @stat: ECC status information. + * @ce_cnt: Correctable Error count. + * @ue_cnt: Uncorrectable Error count. */ struct synps_edac_priv { void __iomem *baseaddr; @@ -142,13 +142,11 @@ struct synps_edac_priv { }; /** - * get_error_info - Get the current ecc error info - * @base: Pointer to the base address of the ddr memory controller - * @p: Pointer to the synopsys ecc status structure + * get_error_info - Get the current ECC error info. + * @base: Base address of the DDR memory controller. + * @p: Synopsys ECC status structure. * - * Determines there is any ecc error or not - * - * Return: one if there is no error otherwise returns zero + * Return: one if there is no error otherwise zero. */ static int get_error_info(void __iomem *base, struct synps_ecc_status *p) { @@ -195,11 +193,11 @@ static int get_error_info(void __iomem *base, struct synps_ecc_status *p) } /** - * handle_error - Handle controller error types CE and UE - * @mci: Pointer to the edac memory controller instance - * @p: Pointer to the synopsys ecc status structure + * handle_error - Handle Correctable and Uncorrectable errors. + * @mci: EDAC memory controller instance. + * @p: Synopsys ECC status structure. * - * Handles the controller ECC correctable and uncorrectable error. + * Handles ECC correctable and uncorrectable errors. */ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) { @@ -230,10 +228,10 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) } /** - * check_errors - Check controller for ECC errors - * @mci: Pointer to the edac memory controller instance + * check_errors - Check controller for ECC errors. + * @mci: EDAC memory controller instance. * - * Used to check and post ECC errors. Called by the polling thread + * Check and post ECC errors. Called by the polling thread. */ static void check_errors(struct mem_ctl_info *mci) { @@ -253,8 +251,8 @@ static void check_errors(struct mem_ctl_info *mci) } /** - * get_dtype - Return the controller memory width - * @base: Pointer to the ddr memory controller base address + * get_dtype - Return the controller memory width. + * @base: DDR memory controller base address. * * Get the EDAC device type width appropriate for the current controller * configuration. @@ -284,12 +282,12 @@ static enum dev_type get_dtype(const void __iomem *base) } /** - * get_ecc_state - Return the controller ECC enable/disable status - * @base: Pointer to the DDR memory controller base address + * get_ecc_state - Return the controller ECC enable/disable status. + * @base: DDR memory controller base address. * - * Get the ECC enable/disable status for the controller. + * Get the ECC enable/disable status of the controller. * - * Return: a ECC status boolean i.e true/false - enabled/disabled. + * Return: true if enabled, otherwise false. */ static bool get_ecc_state(void __iomem *base) { @@ -309,9 +307,9 @@ static bool get_ecc_state(void __iomem *base) } /** - * get_memsize - reads the size of the attached memory device + * get_memsize - Read the size of the attached memory device. * - * Return: the memory size in bytes + * Return: the memory size in bytes. */ static u32 get_memsize(void) { @@ -323,8 +321,8 @@ static u32 get_memsize(void) } /** - * get_mtype - Returns controller memory type - * @base: pointer to the synopsys ecc status structure + * get_mtype - Return the controller memory type. + * @base: Synopsys ECC status structure. * * Get the EDAC memory type appropriate for the current controller * configuration. @@ -347,11 +345,11 @@ static enum mem_type get_mtype(const void __iomem *base) } /** - * init_csrows - Initialize the cs row data - * @mci: Pointer to the edac memory controller instance + * init_csrows - Initialize the csrow data. + * @mci: EDAC memory controller instance. * - * Initializes the chip select rows associated with the EDAC memory - * controller instance + * Initialize the chip select rows associated with the EDAC memory + * controller instance. * * Return: Unconditionally 0. */ @@ -381,11 +379,11 @@ static int init_csrows(struct mem_ctl_info *mci) } /** - * mc_init - Initialize driver instance - * @mci: Pointer to the edac memory controller instance - * @pdev: Pointer to the platform_device struct + * mc_init - Initialize one driver instance. + * @mci: EDAC memory controller instance. + * @pdev: platform device. * - * Performs initialization of the EDAC memory controller instance and + * Perform initialization of the EDAC memory controller instance and * related driver-private data associated with the memory controller the * instance is bound to. * @@ -421,10 +419,10 @@ static int mc_init(struct mem_ctl_info *mci, struct platform_device *pdev) } /** - * mc_probe - Check controller and bind driver - * @pdev: Pointer to the platform_device struct + * mc_probe - Check controller and bind driver. + * @pdev: platform device. * - * Probes a specific controller instance for binding with the driver. + * Probe a specific controller instance for binding with the driver. * * Return: 0 if the controller instance was successfully bound to the * driver; otherwise, < 0 on error. @@ -493,8 +491,8 @@ static int mc_probe(struct platform_device *pdev) } /** - * mc_remove - Unbind driver from controller - * @pdev: Pointer to the platform_device struct + * mc_remove - Unbind driver from controller. + * @pdev: Platform device. * * Return: Unconditionally 0 */ -- 2.19.0.271.gfe8321ec057f -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.