From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Woods, Brian" Subject: Re: [PATCH 1/2] x86/SVM-IOMMU: Don't opencode memcpy() in queue_iommu_command() Date: Thu, 4 Oct 2018 23:03:32 +0000 Message-ID: <20181004230328.GB12026@amd.com> References: <1537786530-4625-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1537786530-4625-1-git-send-email-andrew.cooper3@citrix.com> Content-Language: en-US Content-ID: <60735BF7105CF44D827C08F3502E82FD@namprd12.prod.outlook.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andrew Cooper Cc: Wei Liu , Jan Beulich , Xen-devel , Paul Durrant , "Suthikulpanit, Suravee" , "Woods, Brian" , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBTZXAgMjQsIDIwMTggYXQgMTE6NTU6MjlBTSArMDEwMCwgQW5keSBDb29wZXIgd3Jv dGU6Cj4gSW4gcHJhY3RpY2UsIHRoaXMgYWxsb3dzIHRoZSBjb21waWxlciB0byByZXBsYWNlIHRo ZSBsb29wIHdpdGggYSBwYWlyIG9mIG1vdnMuCj4gCj4gTm8gZnVuY3Rpb25hbCBjaGFuZ2UuCj4g Cj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KClJldmlld2VkLWJ5OiBCcmlhbiBXb29kcyA8YnJpYW4ud29vZHNAYW1kLmNvbT4KCj4gLS0t Cj4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT4KPiBDQzogV2VpIExpdSA8d2Vp LmxpdTJAY2l0cml4LmNvbT4KPiBDQzogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp eC5jb20+Cj4gQ0M6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+Cj4gQ0M6 IFN1cmF2ZWUgU3V0aGlrdWxwYW5pdCA8c3VyYXZlZS5zdXRoaWt1bHBhbml0QGFtZC5jb20+Cj4g Q0M6IEJyaWFuIFdvb2RzIDxicmlhbi53b29kc0BhbWQuY29tPgo+IC0tLQo+ICB4ZW4vZHJpdmVy cy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfY21kLmMgICAgICB8IDEyICsrKystLS0tLS0tLQo+ICB4 ZW4vaW5jbHVkZS9hc20teDg2L2h2bS9zdm0vYW1kLWlvbW11LWRlZnMuaCB8ICAxIC0KPiAgMiBm aWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9jbWQuYyBiL3hlbi9kcml2 ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9jbWQuYwo+IGluZGV4IDA4MjQ3ZmEuLmM2YzBiNGYg MTAwNjQ0Cj4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2NtZC5jCj4g KysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2NtZC5jCj4gQEAgLTI0LDgg KzI0LDcgQEAKPiAgCj4gIHN0YXRpYyBpbnQgcXVldWVfaW9tbXVfY29tbWFuZChzdHJ1Y3QgYW1k X2lvbW11ICppb21tdSwgdTMyIGNtZFtdKQo+ICB7Cj4gLSAgICB1MzIgdGFpbCwgaGVhZCwgKmNt ZF9idWZmZXI7Cj4gLSAgICBpbnQgaTsKPiArICAgIHVpbnQzMl90IHRhaWwsIGhlYWQ7Cj4gIAo+ ICAgICAgdGFpbCA9IGlvbW11LT5jbWRfYnVmZmVyLnRhaWw7Cj4gICAgICBpZiAoICsrdGFpbCA9 PSBpb21tdS0+Y21kX2J1ZmZlci5lbnRyaWVzICkKPiBAQCAtMzUsMTIgKzM0LDkgQEAgc3RhdGlj IGludCBxdWV1ZV9pb21tdV9jb21tYW5kKHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LCB1MzIgY21k W10pCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSU9NTVVfQ01EX0JV RkZFUl9IRUFEX09GRlNFVCkpOwo+ICAgICAgaWYgKCBoZWFkICE9IHRhaWwgKQo+ICAgICAgewo+ IC0gICAgICAgIGNtZF9idWZmZXIgPSAodTMyICopKGlvbW11LT5jbWRfYnVmZmVyLmJ1ZmZlciAr Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGlvbW11LT5jbWRfYnVmZmVyLnRhaWwg Kgo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIElPTU1VX0NNRF9CVUZGRVJfRU5UUllf U0laRSkpOwo+IC0KPiAtICAgICAgICBmb3IgKCBpID0gMDsgaSA8IElPTU1VX0NNRF9CVUZGRVJf VTMyX1BFUl9FTlRSWTsgaSsrICkKPiAtICAgICAgICAgICAgY21kX2J1ZmZlcltpXSA9IGNtZFtp XTsKPiArICAgICAgICBtZW1jcHkoaW9tbXUtPmNtZF9idWZmZXIuYnVmZmVyICsKPiArICAgICAg ICAgICAgICAgKGlvbW11LT5jbWRfYnVmZmVyLnRhaWwgKiBJT01NVV9DTURfQlVGRkVSX0VOVFJZ X1NJWkUpLAo+ICsgICAgICAgICAgICAgICBjbWQsIElPTU1VX0NNRF9CVUZGRVJfRU5UUllfU0la RSk7Cj4gIAo+ICAgICAgICAgIGlvbW11LT5jbWRfYnVmZmVyLnRhaWwgPSB0YWlsOwo+ICAgICAg ICAgIHJldHVybiAxOwo+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L2h2bS9zdm0v YW1kLWlvbW11LWRlZnMuaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL3N2bS9hbWQtaW9tbXUt ZGVmcy5oCj4gaW5kZXggYzQ3OWYwYi4uMWYxOWNkMyAxMDA2NDQKPiAtLS0gYS94ZW4vaW5jbHVk ZS9hc20teDg2L2h2bS9zdm0vYW1kLWlvbW11LWRlZnMuaAo+ICsrKyBiL3hlbi9pbmNsdWRlL2Fz bS14ODYvaHZtL3N2bS9hbWQtaW9tbXUtZGVmcy5oCj4gQEAgLTE4Nyw3ICsxODcsNiBAQAo+ICAK PiAgI2RlZmluZSBJT01NVV9DTURfQlVGRkVSX0VOVFJZX1NJWkUJCQkxNgo+ICAjZGVmaW5lIElP TU1VX0NNRF9CVUZGRVJfUE9XRVJfT0YyX0VOVFJJRVNfUEVSX1BBR0UJOAo+IC0jZGVmaW5lIElP TU1VX0NNRF9CVUZGRVJfVTMyX1BFUl9FTlRSWSAJKElPTU1VX0NNRF9CVUZGRVJfRU5UUllfU0la RSAvIDQpCj4gIAo+ICAjZGVmaW5lIElPTU1VX0NNRF9PUENPREVfTUFTSwkJCTB4RjAwMDAwMDAK PiAgI2RlZmluZSBJT01NVV9DTURfT1BDT0RFX1NISUZUCQkJMjgKPiAtLSAKPiAyLjEuNAo+IAoK LS0gCkJyaWFuIFdvb2RzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRl dmVs