From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: linux-input@vger.kernel.org
Cc: Eric Dumazet <edumazet@google.com>,
"Paul E. McKenney" <paulmck@linux.ibm.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] Input: uinput - add a schedule point in uinput_inject_events()
Date: Thu, 4 Oct 2018 17:54:32 -0700 [thread overview]
Message-ID: <20181005005432.GA218507@dtor-ws> (raw)
Large writes to uinput interface may cause rcu stalls. Let's add
cond_resched() to the loop to avoid this.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/misc/uinput.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
index eb14ddf69346..8ec483e8688b 100644
--- a/drivers/input/misc/uinput.c
+++ b/drivers/input/misc/uinput.c
@@ -598,6 +598,7 @@ static ssize_t uinput_inject_events(struct uinput_device *udev,
input_event(udev->dev, ev.type, ev.code, ev.value);
bytes += input_event_size();
+ cond_resched();
}
return bytes;
--
2.19.0.605.g01d371f741-goog
--
Dmitry
next reply other threads:[~2018-10-05 0:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 0:54 Dmitry Torokhov [this message]
2018-10-05 4:09 ` [PATCH] Input: uinput - add a schedule point in uinput_inject_events() Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005005432.GA218507@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=edumazet@google.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.