From: Martin Jansa <martin.jansa@gmail.com>
To: Vyacheslav Yurkov <uvv.mail@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] ceres-solver: Removed empty package
Date: Fri, 5 Oct 2018 11:44:01 +0200 [thread overview]
Message-ID: <20181005094401.GA1334@jama> (raw)
In-Reply-To: <20181005091722.105122-1-uvv.mail@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1680 bytes --]
On Fri, Oct 05, 2018 at 11:17:22AM +0200, Vyacheslav Yurkov wrote:
> By default ceres-solver provides a static library and headers.
> This change removes an empty package and sets an implicit dependency
> on dev and dbg packages.
>
> It also addresses missing cmake configuration files in dev package.
>
> Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com>
> ---
> meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb b/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
> index ad7c8f2a3..13ca8efab 100644
> --- a/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
> +++ b/meta-oe/recipes-support/ceres-solver/ceres-solver_1.14.bb
> @@ -13,5 +13,8 @@ S = "${WORKDIR}/git"
>
> inherit cmake
>
> +FILES_${PN}-dev += "${libdir}/cmake/"
Why is this needed? cmake files are packaged automatically since oe-core
commit:
commit 543e39ad5e2baa0f1ece013a89483783e6b15dd9
Author: Andre McCurdy <armccurdy@gmail.com>
Date: Tue Jun 26 12:48:11 2018 -0700
bitbake.conf: handle cmake -dev files packaging with default rules
> +
> # Only a static library and headers are created
> -ALLOW_EMPTY_${PN} = "1"
> +RDEPENDS_${PN}-dev = ""
> +RRECOMMENDS_${PN}-dbg = "${PN}-dev (= ${EXTENDPKGV})"
> --
> 2.19.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
next prev parent reply other threads:[~2018-10-05 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 9:17 [meta-oe][PATCH] ceres-solver: Removed empty package Vyacheslav Yurkov
2018-10-05 9:44 ` Martin Jansa [this message]
2018-10-05 9:50 ` Vyacheslav Yurkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005094401.GA1334@jama \
--to=martin.jansa@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=uvv.mail@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.