All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Add patches from the upstream ltp-testsuite github repository to compile correctly.
Date: Fri, 5 Oct 2018 14:18:21 +0200	[thread overview]
Message-ID: <20181005121819.GB31472@dell5510> (raw)
In-Reply-To: <20181005064311.28557-1-F.LaRoche@pilz.de>

Hi Florian,

thanks for your patch.

> Signed-off-by: Florian La Roche <F.LaRoche@pilz.de>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> ---
>  package/ltp-testsuite/0002-execve05.patch | 44 +++++++++++++++++++++++
>  package/ltp-testsuite/0003-statx.patch    | 32 +++++++++++++++++
>  package/ltp-testsuite/0004-statx.patch    | 26 ++++++++++++++
>  3 files changed, 102 insertions(+)
>  create mode 100644 package/ltp-testsuite/0002-execve05.patch
>  create mode 100644 package/ltp-testsuite/0003-statx.patch
>  create mode 100644 package/ltp-testsuite/0004-statx.patch

IMHO it makes sense to add fix of execve05 in the runtest files (0004-statx.patch),
but in separate commit as it's not a compilation fix, just a runtime fix.

I'd prefer to drop 0003-statx.patch and use LTP_TESTSUITE_AUTORECONF = yes
But not sure what are buildroot convention for it.

Kind regards,
Petr

  reply	other threads:[~2018-10-05 12:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05  6:43 [Buildroot] [PATCH 1/1] Add patches from the upstream ltp-testsuite github repository to compile correctly Florian La Roche
2018-10-05 12:18 ` Petr Vorel [this message]
2018-10-08 15:52 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181005121819.GB31472@dell5510 \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.