From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
Colin Patrick McCabe <cmccabe@alumni.cmu.edu>
Subject: Re: [PATCH v3] tools/lib/traceevent: Replace str_error_r() with an open coded implementation
Date: Fri, 5 Oct 2018 12:37:31 -0300 [thread overview]
Message-ID: <20181005153731.GC20250@kernel.org> (raw)
In-Reply-To: <20181005113056.55b23c31@gandalf.local.home>
Em Fri, Oct 05, 2018 at 11:30:56AM -0400, Steven Rostedt escreveu:
> Bah, I now get warnings that sys_nerr and sys_errlist are deprecated.
>
> OK, so going back to just using the racy strerror() should be good
> enough, as this incompatibility with strerror_r() is a disaster!
I've been there, done that... ;-) Check:
tools/lib/str_error_r.c
tools/lib/bpf/str_error.c
The trick: have this function in a separate file, so that _GNU_SOURCE
doesn't get in the way...
- Arnaldo
next prev parent reply other threads:[~2018-10-05 22:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 21:55 [PATCH v3] tools/lib/traceevent: Replace str_error_r() with an open coded implementation Steven Rostedt
2018-10-05 15:30 ` Steven Rostedt
2018-10-05 15:37 ` Arnaldo Carvalho de Melo [this message]
2018-10-05 15:45 ` Steven Rostedt
2018-10-05 15:47 ` Arnaldo Carvalho de Melo
2018-10-05 15:58 ` Steven Rostedt
2018-10-05 16:09 ` Arnaldo Carvalho de Melo
2018-10-05 16:27 ` Colin McCabe
2018-10-05 16:34 ` Steven Rostedt
2018-10-05 19:47 ` Arnaldo Carvalho de Melo
2018-10-05 21:41 ` Colin McCabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005153731.GC20250@kernel.org \
--to=acme@kernel.org \
--cc=cmccabe@alumni.cmu.edu \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.