From: Borislav Petkov <bp@alien8.de>
To: Manish Narani <manish.narani@xilinx.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
michal.simek@xilinx.com, mchehab@kernel.org,
sudeep.holla@arm.com, amit.kucheria@linaro.org,
leoyang.li@nxp.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org
Subject: [v8,05/10] edac: synps: Add platform specific structures for ddrc controller
Date: Fri, 5 Oct 2018 18:53:51 +0200 [thread overview]
Message-ID: <20181005165351.GD10285@zn.tnic> (raw)
On Thu, Oct 04, 2018 at 09:05:23PM +0530, Manish Narani wrote:
> Add platform specific structures, so that we can add different IP
> support later using quirks.
>
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> ---
> drivers/edac/synopsys_edac.c | 91 +++++++++++++++++++++++++++++++-------------
> 1 file changed, 65 insertions(+), 26 deletions(-)
...
> @@ -423,6 +465,7 @@ static void edac_mc_init(struct mem_ctl_info *mci,
> */
> static int synps_edac_mc_probe(struct platform_device *pdev)
> {
> + const struct synps_platform_data *p_data;
> struct edac_mc_layer layers[2];
> struct synps_edac_priv *priv;
> struct mem_ctl_info *mci;
> @@ -435,7 +478,8 @@ static int synps_edac_mc_probe(struct platform_device *pdev)
> if (IS_ERR(baseaddr))
> return PTR_ERR(baseaddr);
>
> - if (!edac_get_eccstate(baseaddr)) {
> + p_data = of_device_get_match_data(&pdev->dev);
That of_device_get_match_data() does return NULL...
> + if (!p_data->get_eccstate(baseaddr)) {
... I'm sure you can imagine what happens here if so.
Anyway, I've pushed what I've applied so far, here:
https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=edac-for-4.20-synps
Please add the error handling ontop of the top patch on that branch and
send the diff to me.
Thx.
WARNING: multiple messages have this Message-ID (diff)
From: bp@alien8.de (Borislav Petkov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 05/10] edac: synps: Add platform specific structures for ddrc controller
Date: Fri, 5 Oct 2018 18:53:51 +0200 [thread overview]
Message-ID: <20181005165351.GD10285@zn.tnic> (raw)
In-Reply-To: <1538667328-9465-6-git-send-email-manish.narani@xilinx.com>
On Thu, Oct 04, 2018 at 09:05:23PM +0530, Manish Narani wrote:
> Add platform specific structures, so that we can add different IP
> support later using quirks.
>
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> ---
> drivers/edac/synopsys_edac.c | 91 +++++++++++++++++++++++++++++++-------------
> 1 file changed, 65 insertions(+), 26 deletions(-)
...
> @@ -423,6 +465,7 @@ static void edac_mc_init(struct mem_ctl_info *mci,
> */
> static int synps_edac_mc_probe(struct platform_device *pdev)
> {
> + const struct synps_platform_data *p_data;
> struct edac_mc_layer layers[2];
> struct synps_edac_priv *priv;
> struct mem_ctl_info *mci;
> @@ -435,7 +478,8 @@ static int synps_edac_mc_probe(struct platform_device *pdev)
> if (IS_ERR(baseaddr))
> return PTR_ERR(baseaddr);
>
> - if (!edac_get_eccstate(baseaddr)) {
> + p_data = of_device_get_match_data(&pdev->dev);
That of_device_get_match_data() does return NULL...
> + if (!p_data->get_eccstate(baseaddr)) {
... I'm sure you can imagine what happens here if so.
Anyway, I've pushed what I've applied so far, here:
https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=edac-for-4.20-synps
Please add the error handling ontop of the top patch on that branch and
send the diff to me.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Manish Narani <manish.narani@xilinx.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
michal.simek@xilinx.com, mchehab@kernel.org,
sudeep.holla@arm.com, amit.kucheria@linaro.org,
leoyang.li@nxp.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH v8 05/10] edac: synps: Add platform specific structures for ddrc controller
Date: Fri, 5 Oct 2018 18:53:51 +0200 [thread overview]
Message-ID: <20181005165351.GD10285@zn.tnic> (raw)
In-Reply-To: <1538667328-9465-6-git-send-email-manish.narani@xilinx.com>
On Thu, Oct 04, 2018 at 09:05:23PM +0530, Manish Narani wrote:
> Add platform specific structures, so that we can add different IP
> support later using quirks.
>
> Signed-off-by: Manish Narani <manish.narani@xilinx.com>
> ---
> drivers/edac/synopsys_edac.c | 91 +++++++++++++++++++++++++++++++-------------
> 1 file changed, 65 insertions(+), 26 deletions(-)
...
> @@ -423,6 +465,7 @@ static void edac_mc_init(struct mem_ctl_info *mci,
> */
> static int synps_edac_mc_probe(struct platform_device *pdev)
> {
> + const struct synps_platform_data *p_data;
> struct edac_mc_layer layers[2];
> struct synps_edac_priv *priv;
> struct mem_ctl_info *mci;
> @@ -435,7 +478,8 @@ static int synps_edac_mc_probe(struct platform_device *pdev)
> if (IS_ERR(baseaddr))
> return PTR_ERR(baseaddr);
>
> - if (!edac_get_eccstate(baseaddr)) {
> + p_data = of_device_get_match_data(&pdev->dev);
That of_device_get_match_data() does return NULL...
> + if (!p_data->get_eccstate(baseaddr)) {
... I'm sure you can imagine what happens here if so.
Anyway, I've pushed what I've applied so far, here:
https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=edac-for-4.20-synps
Please add the error handling ontop of the top patch on that branch and
send the diff to me.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next reply other threads:[~2018-10-05 16:53 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 16:53 Borislav Petkov [this message]
2018-10-05 16:53 ` [PATCH v8 05/10] edac: synps: Add platform specific structures for ddrc controller Borislav Petkov
2018-10-05 16:53 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2018-10-08 18:03 [v8,02/10] edac: synopsys: Rename the static functions to a shorter name Borislav Petkov
2018-10-08 18:03 ` [PATCH v8 02/10] " Borislav Petkov
2018-10-08 18:03 ` Borislav Petkov
2018-10-08 13:45 [v8,02/10] " Manish Narani
2018-10-08 13:45 ` [PATCH v8 02/10] " Manish Narani
2018-10-08 13:45 ` Manish Narani
2018-10-04 20:36 [v8,03/10] edac: synopsys: Modify the comments in the driver Borislav Petkov
2018-10-04 20:36 ` [PATCH v8 03/10] " Borislav Petkov
2018-10-04 20:36 ` Borislav Petkov
2018-10-04 20:35 [v8,02/10] edac: synopsys: Rename the static functions to a shorter name Borislav Petkov
2018-10-04 20:35 ` [PATCH v8 02/10] " Borislav Petkov
2018-10-04 20:35 ` Borislav Petkov
2018-10-04 15:35 [v8,10/10] edac: synopsys: Add Error Injection support for ZynqMP DDRC Manish Narani
2018-10-04 15:35 ` [PATCH v8 10/10] " Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 [v8,09/10] arm64: zynqmp: Add DDRC node Manish Narani
2018-10-04 15:35 ` [PATCH v8 09/10] " Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 [v8,08/10] edac: synopsys: Add EDAC ECC support for ZynqMP DDRC Manish Narani
2018-10-04 15:35 ` [PATCH v8 08/10] " Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 [v8,07/10] edac: synopsys: Add macro defines " Manish Narani
2018-10-04 15:35 ` [PATCH v8 07/10] " Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 [v8,06/10] dt: bindings: Document ZynqMP DDRC in Synopsys documentation Manish Narani
2018-10-04 15:35 ` [PATCH v8 06/10] " Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 [v8,05/10] edac: synps: Add platform specific structures for ddrc controller Manish Narani
2018-10-04 15:35 ` [PATCH v8 05/10] " Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 [v8,04/10] edac: synopsys: Make return type void for functions always returning 0 Manish Narani
2018-10-04 15:35 ` [PATCH v8 04/10] " Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 [v8,03/10] edac: synopsys: Modify the comments in the driver Manish Narani
2018-10-04 15:35 ` [PATCH v8 03/10] " Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 [v8,02/10] edac: synopsys: Rename the static functions to a shorter name Manish Narani
2018-10-04 15:35 ` [PATCH v8 02/10] " Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 [v8,01/10] edac: synopsys: Update the driver code for better readability Manish Narani
2018-10-04 15:35 ` [PATCH v8 01/10] " Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 [PATCH v8 00/10] EDAC: Enhancements to Synopsys EDAC driver Manish Narani
2018-10-04 15:35 ` Manish Narani
2018-10-04 15:35 ` Manish Narani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005165351.GD10285@zn.tnic \
--to=bp@alien8.de \
--cc=amit.kucheria@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.