From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v8,05/10] edac: synps: Add platform specific structures for ddrc controller From: Borislav Petkov Message-Id: <20181005165351.GD10285@zn.tnic> Date: Fri, 5 Oct 2018 18:53:51 +0200 To: Manish Narani Cc: robh+dt@kernel.org, mark.rutland@arm.com, michal.simek@xilinx.com, mchehab@kernel.org, sudeep.holla@arm.com, amit.kucheria@linaro.org, leoyang.li@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org List-ID: T24gVGh1LCBPY3QgMDQsIDIwMTggYXQgMDk6MDU6MjNQTSArMDUzMCwgTWFuaXNoIE5hcmFuaSB3 cm90ZToKPiBBZGQgcGxhdGZvcm0gc3BlY2lmaWMgc3RydWN0dXJlcywgc28gdGhhdCB3ZSBjYW4g YWRkIGRpZmZlcmVudCBJUAo+IHN1cHBvcnQgbGF0ZXIgdXNpbmcgcXVpcmtzLgo+IAo+IFNpZ25l ZC1vZmYtYnk6IE1hbmlzaCBOYXJhbmkgPG1hbmlzaC5uYXJhbmlAeGlsaW54LmNvbT4KPiAtLS0K PiAgZHJpdmVycy9lZGFjL3N5bm9wc3lzX2VkYWMuYyB8IDkxICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA2NSBpbnNlcnRpb25z KCspLCAyNiBkZWxldGlvbnMoLSkKCi4uLgoKPiBAQCAtNDIzLDYgKzQ2NSw3IEBAIHN0YXRpYyB2 b2lkIGVkYWNfbWNfaW5pdChzdHJ1Y3QgbWVtX2N0bF9pbmZvICptY2ksCj4gICAqLwo+ICBzdGF0 aWMgaW50IHN5bnBzX2VkYWNfbWNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikK PiAgewo+ICsJY29uc3Qgc3RydWN0IHN5bnBzX3BsYXRmb3JtX2RhdGEgKnBfZGF0YTsKPiAgCXN0 cnVjdCBlZGFjX21jX2xheWVyIGxheWVyc1syXTsKPiAgCXN0cnVjdCBzeW5wc19lZGFjX3ByaXYg KnByaXY7Cj4gIAlzdHJ1Y3QgbWVtX2N0bF9pbmZvICptY2k7Cj4gQEAgLTQzNSw3ICs0NzgsOCBA QCBzdGF0aWMgaW50IHN5bnBzX2VkYWNfbWNfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAq cGRldikKPiAgCWlmIChJU19FUlIoYmFzZWFkZHIpKQo+ICAJCXJldHVybiBQVFJfRVJSKGJhc2Vh ZGRyKTsKPiAgCj4gLQlpZiAoIWVkYWNfZ2V0X2VjY3N0YXRlKGJhc2VhZGRyKSkgewo+ICsJcF9k YXRhID0gb2ZfZGV2aWNlX2dldF9tYXRjaF9kYXRhKCZwZGV2LT5kZXYpOwoKVGhhdCBvZl9kZXZp Y2VfZ2V0X21hdGNoX2RhdGEoKSAgZG9lcyByZXR1cm4gTlVMTC4uLgoKPiArCWlmICghcF9kYXRh LT5nZXRfZWNjc3RhdGUoYmFzZWFkZHIpKSB7CgouLi4gSSdtIHN1cmUgeW91IGNhbiBpbWFnaW5l IHdoYXQgaGFwcGVucyBoZXJlIGlmIHNvLgoKQW55d2F5LCBJJ3ZlIHB1c2hlZCB3aGF0IEkndmUg YXBwbGllZCBzbyBmYXIsIGhlcmU6CgpodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGlu dXgva2VybmVsL2dpdC9icC9icC5naXQvbG9nLz9oPWVkYWMtZm9yLTQuMjAtc3lucHMKClBsZWFz ZSBhZGQgdGhlIGVycm9yIGhhbmRsaW5nIG9udG9wIG9mIHRoZSB0b3AgcGF0Y2ggb24gdGhhdCBi cmFuY2ggYW5kCnNlbmQgdGhlIGRpZmYgdG8gbWUuCgpUaHguCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: bp@alien8.de (Borislav Petkov) Date: Fri, 5 Oct 2018 18:53:51 +0200 Subject: [PATCH v8 05/10] edac: synps: Add platform specific structures for ddrc controller In-Reply-To: <1538667328-9465-6-git-send-email-manish.narani@xilinx.com> References: <1538667328-9465-1-git-send-email-manish.narani@xilinx.com> <1538667328-9465-6-git-send-email-manish.narani@xilinx.com> Message-ID: <20181005165351.GD10285@zn.tnic> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Oct 04, 2018 at 09:05:23PM +0530, Manish Narani wrote: > Add platform specific structures, so that we can add different IP > support later using quirks. > > Signed-off-by: Manish Narani > --- > drivers/edac/synopsys_edac.c | 91 +++++++++++++++++++++++++++++++------------- > 1 file changed, 65 insertions(+), 26 deletions(-) ... > @@ -423,6 +465,7 @@ static void edac_mc_init(struct mem_ctl_info *mci, > */ > static int synps_edac_mc_probe(struct platform_device *pdev) > { > + const struct synps_platform_data *p_data; > struct edac_mc_layer layers[2]; > struct synps_edac_priv *priv; > struct mem_ctl_info *mci; > @@ -435,7 +478,8 @@ static int synps_edac_mc_probe(struct platform_device *pdev) > if (IS_ERR(baseaddr)) > return PTR_ERR(baseaddr); > > - if (!edac_get_eccstate(baseaddr)) { > + p_data = of_device_get_match_data(&pdev->dev); That of_device_get_match_data() does return NULL... > + if (!p_data->get_eccstate(baseaddr)) { ... I'm sure you can imagine what happens here if so. Anyway, I've pushed what I've applied so far, here: https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=edac-for-4.20-synps Please add the error handling ontop of the top patch on that branch and send the diff to me. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v8 05/10] edac: synps: Add platform specific structures for ddrc controller Date: Fri, 5 Oct 2018 18:53:51 +0200 Message-ID: <20181005165351.GD10285@zn.tnic> References: <1538667328-9465-1-git-send-email-manish.narani@xilinx.com> <1538667328-9465-6-git-send-email-manish.narani@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1538667328-9465-6-git-send-email-manish.narani@xilinx.com> Sender: linux-kernel-owner@vger.kernel.org To: Manish Narani Cc: robh+dt@kernel.org, mark.rutland@arm.com, michal.simek@xilinx.com, mchehab@kernel.org, sudeep.holla@arm.com, amit.kucheria@linaro.org, leoyang.li@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu, Oct 04, 2018 at 09:05:23PM +0530, Manish Narani wrote: > Add platform specific structures, so that we can add different IP > support later using quirks. > > Signed-off-by: Manish Narani > --- > drivers/edac/synopsys_edac.c | 91 +++++++++++++++++++++++++++++++------------- > 1 file changed, 65 insertions(+), 26 deletions(-) ... > @@ -423,6 +465,7 @@ static void edac_mc_init(struct mem_ctl_info *mci, > */ > static int synps_edac_mc_probe(struct platform_device *pdev) > { > + const struct synps_platform_data *p_data; > struct edac_mc_layer layers[2]; > struct synps_edac_priv *priv; > struct mem_ctl_info *mci; > @@ -435,7 +478,8 @@ static int synps_edac_mc_probe(struct platform_device *pdev) > if (IS_ERR(baseaddr)) > return PTR_ERR(baseaddr); > > - if (!edac_get_eccstate(baseaddr)) { > + p_data = of_device_get_match_data(&pdev->dev); That of_device_get_match_data() does return NULL... > + if (!p_data->get_eccstate(baseaddr)) { ... I'm sure you can imagine what happens here if so. Anyway, I've pushed what I've applied so far, here: https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=edac-for-4.20-synps Please add the error handling ontop of the top patch on that branch and send the diff to me. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.