From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts Date: Fri, 5 Oct 2018 11:10:36 -0700 Message-ID: <20181005181034.GC4163@intel.com> References: <20181004205149.9286-1-dhinakaran.pandiyan@intel.com> <20181004230303.GA23914@ldmartin-desk.jf.intel.com> <20181004232835.GA4163@intel.com> <20181005002717.GB4163@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7756B6E02E for ; Fri, 5 Oct 2018 18:17:14 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMDQsIDIwMTggYXQgMDc6NTY6MzdQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBPbiBUaHUsIDIwMTgtMTAtMDQgYXQgMTc6MjcgLTA3MDAsIE1hbmFzaSBO YXZhcmUgd3JvdGU6Cj4gPiBPbiBUaHUsIE9jdCAwNCwgMjAxOCBhdCAwNTowMDowNlBNIC0wNzAw LCBEaGluYWthcmFuIFBhbmRpeWFuIHdyb3RlOgo+ID4gPiBPbiBUaHUsIDIwMTgtMTAtMDQgYXQg MTY6MjggLTA3MDAsIE1hbmFzaSBOYXZhcmUgd3JvdGU6Cj4gPiA+ID4gT24gVGh1LCBPY3QgMDQs IDIwMTggYXQgMDQ6MTM6MjZQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5kaXlhbgo+ID4gPiA+IHdy b3RlOgo+ID4gPiA+ID4gT24gVGh1LCAyMDE4LTEwLTA0IGF0IDE2OjAzIC0wNzAwLCBMdWNhcyBE ZSBNYXJjaGkgd3JvdGU6Cj4gPiA+ID4gPiA+IE9uIFRodSwgT2N0IDA0LCAyMDE4IGF0IDAxOjUx OjQ5UE0gLTA3MDAsIERoaW5ha2FyYW4gUGFuZGl5YW4KPiA+ID4gPiA+ID4gd3JvdGU6Cj4gPiA+ ID4gPiA+ID4gVGhlIHNoaWZ0cyBmb3IgVlNDX1NFTEVDVCBiaXRzIGFyZSB3cm9uZywgZml4IGl0 LiBHb29kCj4gPiA+ID4gPiA+ID4gdGhpbmcgaXMKPiA+ID4gPiA+ID4gPiB0aGUKPiA+ID4gPiA+ ID4gPiBkZWZpbml0aW9ucyBhcmUgdW51c2VkLgo+ID4gCj4gPiBObyBuZWVkIHRvIG1lbnRpb24g dGhhdCBkZWZzIGFyZSB1bnVzZWQgaW4gdGhlIGNvbW1pdCBzaW5jZSB0aGF0IHdpbGwKPiA+IG5v dCBtYWtlIHNlbnNlCj4gPiBvbmNlIHRoZSBwYXRjaGVzIGdldCBtZXJnZWQgdGhhdCBzdGFydCB1 c2luZyB0aGVzZS4KPiBXZWxsLCB0aGUgcGF0Y2ggaXMgYmFzZWQgb24gdGhlIGN1cnJlbnQgc3Rh dGUgb2YgdGhlIGNvZGUgYmFzZS4KPgoKV2VsbCBJTUhPIHRoYXQgc3RhdGVtZW50IGlzIHN0aWxs IHJlZHVuZGFudCBhbmQgbW9yZSBleHByZXNzaXZlIHRoYW4gaW5mb3JtYXRpdmUuCk1lbnRpb25p bmcgdGhhdCB0aGlzIGlzCmEgZml4IGZvciBWU0MgU0VMRUNUIHNob3VsZCBzdWZmaWNlLiBCdXQg dGhhdHMgYSBuaXRjcGljaywgc28gaXRzIHlvdXIgY2FsbC4KICAKPiA+IAo+ID4gTW9yZSBjb21t ZW50cyBiZWxvdwo+ID4gCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBJZiB0aGV5IGFyZSB1bnVz ZWQgd2h5IGFyZSB3ZSBmaXhpbmcgdGhlbSBpbnN0ZWFkIG9mCj4gPiA+ID4gPiA+IHJlbW92aW5n PyBPcgo+ID4gPiA+ID4gPiBiZXR0ZXIsCj4gPiA+ID4gPiA+IHdoeSBkaWQgd2UgYWRkIHRoZW0/ Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IEkgZ3Vlc3MgdGhlcmUgYXJlIHBsYW5zIHRvIG1ha2UgdXNl IG9mIHRoZW0sIG5vIGlkZWEuCj4gPiA+ID4gPiAKPiA+ID4gPiAKPiA+ID4gPiBZZXMsIHRoZSBW RElQX1JOQUJMRV9QUFMgYW5kIERJUCBlbmFibGVzIGdldCB1c2VkIGluIHRoZSBEU0MKPiA+ID4g PiBwYXRjaAo+ID4gPiA+IHNlcmllczoKPiA+ID4gPiAKPiA+ID4gPiBodHRwczovL3BhdGNod29y ay5mcmVlZGVza3RvcC5vcmcvc2VyaWVzLzQ3NTE0Lwo+ID4gPiA+IAo+ID4gPiA+IElmIHlvdSB3 YW50IEkgY2FuIGNvbWJpbmUgdGhpcyBmaXhlcyBwYXRjaCB3aXRoIHRoZSBuZXcgcmV2aXNpb24K PiA+ID4gPiBvZgo+ID4gPiA+IERTQyBwYXRjaHNlcmllcwo+ID4gPiA+IEkgYW0gYWJvdXQgdG8g c2VuZCBvdXQKPiA+ID4gCj4gPiA+IFRoYXQgbWlnaHQgY3JlYXRlIGFuIHVubmVjZXNzYXJ5IGRl cGVuZGVuY3kgb24gdGhlIHNlcmllcyBnZXR0aW5nCj4gPiA+IG1lcmdlZC4gV2UnbGwgaGF2ZSB0 byBwcm9ncmFtIHRoZXNlIGJpdHMgZm9yIFBTUjIgZnJvbSB0aGUgbG9va3Mgb2YKPiA+ID4gaXQu Cj4gPiA+IExldCdzIGdldCB0aGlzIGludG8gdGhlIHRyZWUgc29vbiwgY2FuIHlvdSBwbGVhc2Ug cmV2aWV3IHRoZSBmaXg/Cj4gPiA+IAo+ID4gPiAtREsKPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4g TWFuYXNpCj4gPiA+ID4gIAo+ID4gPiA+ID4gQ2M6IEFudXNoYSwgTWFuYXNpCj4gPiA+ID4gPiAK PiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IEx1Y2FzIERlIE1hcmNoaQo+ID4gPiA+ID4gPiAKPiA+ ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBDYzogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2 YXJlQGludGVsLmNvbT4KPiA+ID4gPiA+ID4gPiBDYzogQW51c2hhIFNyaXZhdHNhIDxhbnVzaGEu c3JpdmF0c2FAaW50ZWwuY29tPgo+ID4gPiA+ID4gPiA+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJp Z28udml2aUBpbnRlbC5jb20+Cj4gPiA+ID4gPiA+ID4gRml4ZXM6IDdhZjJiZTZkNTRkNCAoImRy bS9pOTE1L2ljbDogQWRkIFZJREVPX0RJUAo+ID4gPiA+ID4gPiA+IHJlZ2lzdGVycyIpCj4gPiA+ ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogRGhpbmFrYXJhbiBQYW5kaXlhbiA8Cj4gPiA+ID4gPiA+ ID4gZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gPiA+ID4gPiA+ID4gLS0tCj4gPiA+ ID4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggfCAxOCArKysrKysrKyst LS0tLS0tLS0KPiA+ID4gPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwg OSBkZWxldGlvbnMoLSkKPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gPiA+ID4gPiA+IGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gPiA+ID4gPiA+IGluZGV4IDI3ZTY1MGZlNTkxYi4u YTBhZDc3YjkyMTJiIDEwMDY0NAo+ID4gPiA+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfcmVnLmgKPiA+ID4gPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3JlZy5oCj4gPiA+ID4gPiA+ID4gQEAgLTQ1ODQsNiArNDU4NCwxNSBAQCBlbnVtIHsKPiA+ ID4gPiA+ID4gPiAgI2RlZmluZSAgIFZJREVPX0RJUF9GUkVRXzJWU1lOQwkJKDIgPDwgMTYpCj4g PiA+ID4gPiA+ID4gICNkZWZpbmUgICBWSURFT19ESVBfRlJFUV9NQVNLCQkoMyA8PCAxNikKPiA+ ID4gPiA+ID4gPiAgLyogSFNXIGFuZCBsYXRlcjogKi8KPiA+ID4gPiA+ID4gPiArI2RlZmluZSAg IERSTV9ESVBfRU5BQkxFCQkoMSA8PCAyOCkKPiA+ID4gPiA+ID4gPiArI2RlZmluZSAgIFBTUl9W U0NfQklUXzdfU0VUCQkoMSA8PCAyNykKPiA+ID4gPiA+ID4gPiArI2RlZmluZSAgIFZTQ19TRUxF Q1RfTUFTSwkJKDB4MyA8PCAyNSkKPiA+ID4gPiA+ID4gPiArI2RlZmluZSAgIFZTQ19TRUxFQ1Rf U0hJRlQJCTI1Cj4gPiA+ID4gPiA+ID4gKyNkZWZpbmUgICBWU0NfRElQX0hXX0hFQV9EQVRBCQko MCA8PCAyNSkKPiA+ID4gPiA+ID4gPiArI2RlZmluZSAgIFZTQ19ESVBfSFdfSEVBX1NXX0RBVEEJ KDEgPDwgMjUpCj4gPiA+ID4gPiA+ID4gKyNkZWZpbmUgICBWU0NfRElQX0hXX0RBVEFfU1dfSEVB CSgyIDw8IDI1KQo+ID4gPiA+ID4gPiA+ICsjZGVmaW5lICAgVlNDX0RJUF9TV19IRUFfREFUQQkJ KDMgPDwgMjUpCj4gPiA+ID4gPiA+ID4gKyNkZWZpbmUgICBWRElQX0VOQUJMRV9QUFMJCSgxIDw8 IDI0KQo+ID4gPiA+ID4gPiA+ICAjZGVmaW5lICAgVklERU9fRElQX0VOQUJMRV9WU0NfSFNXCSgx IDw8IDIwKQo+ID4gPiA+ID4gPiA+ICAjZGVmaW5lICAgVklERU9fRElQX0VOQUJMRV9HQ1BfSFNX CSgxIDw8IDE2KQo+ID4gPiA+ID4gPiA+ICAjZGVmaW5lICAgVklERU9fRElQX0VOQUJMRV9BVklf SFNXCSgxIDw8IDEyKQo+ID4gPiA+ID4gPiA+IEBAIC00NTkxLDE1ICs0NjAwLDYgQEAgZW51bSB7 Cj4gPiA+ID4gPiA+ID4gICNkZWZpbmUgICBWSURFT19ESVBfRU5BQkxFX0dNUF9IU1cJKDEgPDwg NCkKPiA+ID4gPiA+ID4gPiAgI2RlZmluZSAgIFZJREVPX0RJUF9FTkFCTEVfU1BEX0hTVwkoMSA8 PCAwKQo+ID4gPiA+ID4gPiA+ICAKPiA+ID4gPiA+ID4gPiAtI2RlZmluZSAgRFJNX0RJUF9FTkFC TEUJCQkoMSA8PCAyOCkKPiA+ID4gPiA+ID4gPiAtI2RlZmluZSAgUFNSX1ZTQ19CSVRfN19TRVQJ CSgxIDw8IDI3KQo+ID4gPiA+ID4gPiA+IC0jZGVmaW5lICBWU0NfU0VMRUNUX01BU0sJCSgweDMg PDwgMjYpCj4gPiA+ID4gPiA+ID4gLSNkZWZpbmUgIFZTQ19TRUxFQ1RfU0hJRlQJCTI2Cj4gPiA+ ID4gPiA+ID4gLSNkZWZpbmUgIFZTQ19ESVBfSFdfSEVBX0RBVEEJCSgwIDw8IDI2KQo+ID4gPiA+ ID4gPiA+IC0jZGVmaW5lICBWU0NfRElQX0hXX0hFQV9TV19EQVRBCQkoMSA8PCAyNikKPiA+ID4g PiA+ID4gPiAtI2RlZmluZSAgVlNDX0RJUF9IV19EQVRBX1NXX0hFQQkJKDIgPDwgMjYpCj4gPiA+ ID4gPiA+ID4gLSNkZWZpbmUgIFZTQ19ESVBfU1dfSEVBX0RBVEEJCSgzIDw8IDI2KQo+ID4gPiA+ ID4gPiA+IC0jZGVmaW5lICBWRElQX0VOQUJMRV9QUFMJCSgxIDw8IDI0KQo+ID4gCj4gPiBXaHkg ZG8geW91IG5lZWQgdG8gcmVtb3ZlIGFsbCBvZiB0aGVzZSBkZWZzPwo+ID4gRnJvbSB0aGUgc3Bl YywgdGhlIG9ubHkgc2hpZnQgdGhhdHMgd3JvbmcgaXMgOgo+ID4gVlNDX1NFTEVDVF9NQVNLICAg ICAgICAgICAgICgweDMgPDwgMjYpCj4gPiAjZGVmaW5lICBWU0NfU0VMRUNUX1NISUZUICAgICAg ICAgICAgMjYKPiA+ICNkZWZpbmUgIFZTQ19ESVBfSFdfSEVBX0RBVEEgICAgICAgICAoMCA8PCAy NikKPiA+IGRlZmluZSAgVlNDX0RJUF9IV19IRUFfU1dfREFUQSAgICAgICAgICAgICAgKDEgPDwg MjYpCj4gPiBkZWZpbmUgIFZTQ19ESVBfSFdfREFUQV9TV19IRUEgICAgICAgICAgICAgICgyIDw8 IDI2KQo+ID4gVlNDX0RJUF9TV19IRUFfREFUQSAgICAgICAgICgzIDw8IDI2KQo+ID4gCj4gPiBS ZW1vdmluZyBvdGhlcnMgYW5kIHJlZGVmaW5pbmcgdG8gYmUgdGhlIHNhbWUgaXMgbWlzbGVhZGlu Zwo+IAo+IFBsZWFzZSBzZWUgb3RoZXIgZGVmaW5pdGlvbnMgaW4gdGhlIGZpbGUgYW5kIHRoZSBk b2N1bWVudGF0aW9uIGFib3ZlLAo+IHdlIGdlbmVyYWxseSBvcmdhbml6ZSBiaXQgZGVmaW5pdGlv bnMgaW4gdGhlIGRlc2NlbmRpbmcgb3JkZXIgb2YgdGhlaXIKPiBwb3NpdGlvbi4KPgoKSSBzdGls bCBkb250IHNlZSB3aHkgeW91IGhhZCByZW1vdmUgZWFybGllciBkZWZzIGFuZCByZWRlZmluZSBz aW5jZQppdCB3YXMgYWxyZWFkeSBvcmdhbml6ZWQgaW4gZGVzY2VuZGluZyBvcmRlciBvZiB0aGVp ciBwb3NpdGlvbiBpbiB0aGUgb3JpZ2lubApwYXRjaGVzIHN0YXJ0aW5nIHdpdGggRFJNX0RJUF9F TkFCTEUgd2l0aCAxPDwgMjggYWxsIHRoZSB3YXkgdG8gVkRJUF9FTkFCTEVfUFBTIHdpdGgKMSA8 PCAyNCBhbmQgeW91ciBjaGFuZ2VzIGtlZXBzIHRoZSBzYW1lIG9yZGVyIHdpdGggdGhlIGZpeCBv ZiBWU0MgSFNJRlQgZnJvbSAyNiB0byAyNS4KU28gb25seSB0aG9zZSBWU0MgZGVmcyBzaG91bGQg YmUgY2hhbmdlZCBub3QgdGhlIGVudGlyZSBzZXQuCgpNYW5hc2kKIAo+IAo+ID4gCj4gPiBPdGhl ciB0aGFuIHRoYXQgdGhlIGFjdHVhbCBmaXhlcyBsb29rIGdvb2QsIGRvdWJsZSBjaGVja2VkIHdp dGggdGhlCj4gPiBzcGVjLgo+ID4gU28gYWZ0ZXIgdGhlIGFib3ZlIGZpeCBhbmQgdGhlIGNvbW1p dCBtZXNzYWdlIGZpeAo+ID4gCj4gPiBSZXZpZXdlZC1ieTogTWFuYXNpIE5hdmFyZSA8bWFuYXNp LmQubmF2YXJlQGludGVsLmNvbT4KPiA+IAo+ID4gTWFuYXNpCj4gPiAKPiA+ID4gPiA+ID4gPiAg Cj4gPiA+ID4gPiA+ID4gIC8qIFBhbmVsIHBvd2VyIHNlcXVlbmNpbmcgKi8KPiA+ID4gPiA+ID4g PiAgI2RlZmluZSBQUFNfQkFTRQkJCTB4NjEyMDAKPiA+ID4gPiA+ID4gPiAtLSAKPiA+ID4gPiA+ ID4gPiAyLjE0LjEKPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gPiA+ID4gPiA+IEludGVsLWdmeCBt YWlsaW5nIGxpc3QKPiA+ID4gPiA+ID4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gPiA+ID4gPiA+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==