From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Date: Fri, 05 Oct 2018 20:38:31 +0000 Subject: Re: [PATCH -next] EDAC: Fix debugfs_simple_attr.cocci warnings Message-Id: <20181005203831.GF10285@zn.tnic> List-Id: References: <1538736760-101310-1-git-send-email-yuehaibing@huawei.com> In-Reply-To: <1538736760-101310-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: YueHaibing Cc: Tony Luck , Mauro Carvalho Chehab , linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org On Fri, Oct 05, 2018 at 10:52:40AM +0000, YueHaibing wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to What significant overhead? This commit message needs to explain what is wrong with the use of DEFINE_DEBUGFS_ATTRIBUTE first. > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). Reading the comment over this function: * It is your responsibility to protect your struct file_operation * methods against file removals by means of debugfs_use_file_start() * and debugfs_use_file_finish(). ->open() is still protected by * debugfs though. doesn't sound like something I'd want to additionally pay attention to. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [-next] EDAC: Fix debugfs_simple_attr.cocci warnings From: Borislav Petkov Message-Id: <20181005203831.GF10285@zn.tnic> Date: Fri, 5 Oct 2018 22:38:31 +0200 To: YueHaibing Cc: Tony Luck , Mauro Carvalho Chehab , linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: T24gRnJpLCBPY3QgMDUsIDIwMTggYXQgMTA6NTI6NDBBTSArMDAwMCwgWXVlSGFpYmluZyB3cm90 ZToKPiBVc2UgREVGSU5FX0RFQlVHRlNfQVRUUklCVVRFIHJhdGhlciB0aGFuIERFRklORV9TSU1Q TEVfQVRUUklCVVRFCj4gZm9yIGRlYnVnZnMgZmlsZXMuCj4gCj4gU2VtYW50aWMgcGF0Y2ggaW5m b3JtYXRpb246Cj4gUmF0aW9uYWxlOiBERUZJTkVfU0lNUExFX0FUVFJJQlVURSArIGRlYnVnZnNf Y3JlYXRlX2ZpbGUoKQo+IGltcG9zZXMgc29tZSBzaWduaWZpY2FudCBvdmVyaGVhZCBhcyBjb21w YXJlZCB0bwoKV2hhdCBzaWduaWZpY2FudCBvdmVyaGVhZD8gVGhpcyBjb21taXQgbWVzc2FnZSBu ZWVkcyB0byBleHBsYWluIHdoYXQgaXMKd3Jvbmcgd2l0aCB0aGUgdXNlIG9mIERFRklORV9ERUJV R0ZTX0FUVFJJQlVURSBmaXJzdC4KCj4gREVGSU5FX0RFQlVHRlNfQVRUUklCVVRFICsgZGVidWdm c19jcmVhdGVfZmlsZV91bnNhZmUoKS4KClJlYWRpbmcgdGhlIGNvbW1lbnQgb3ZlciB0aGlzIGZ1 bmN0aW9uOgoKICogSXQgaXMgeW91ciByZXNwb25zaWJpbGl0eSB0byBwcm90ZWN0IHlvdXIgc3Ry dWN0IGZpbGVfb3BlcmF0aW9uCiAqIG1ldGhvZHMgYWdhaW5zdCBmaWxlIHJlbW92YWxzIGJ5IG1l YW5zIG9mIGRlYnVnZnNfdXNlX2ZpbGVfc3RhcnQoKQogKiBhbmQgZGVidWdmc191c2VfZmlsZV9m aW5pc2goKS4gLT5vcGVuKCkgaXMgc3RpbGwgcHJvdGVjdGVkIGJ5CiAqIGRlYnVnZnMgdGhvdWdo LgoKZG9lc24ndCBzb3VuZCBsaWtlIHNvbWV0aGluZyBJJ2Qgd2FudCB0byBhZGRpdGlvbmFsbHkg cGF5IGF0dGVudGlvbiB0by4K