From: Greg KH <gregkh@linuxfoundation.org>
To: Dror Levin <drorl@infinidat.com>
Cc: torvalds@linux-foundation.org,
Richard Weinberger <richard.weinberger@gmail.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-scsi@vger.kernel.org, hch@infradead.org, axboe@kernel.dk
Subject: Re: Recent removal of bsg read/write support
Date: Fri, 5 Oct 2018 15:35:26 -0700 [thread overview]
Message-ID: <20181005223526.GF13613@kroah.com> (raw)
In-Reply-To: <CAOuWhkYRtTqrnp1uyDWFqXFcTLhPbcqv8XzdV_jurJHstGQmuA@mail.gmail.com>
On Thu, Oct 04, 2018 at 09:58:37AM +0300, Dror Levin wrote:
> CC'ing Greg.
>
> On Mon, Sep 3, 2018 at 11:34 AM Dror Levin <drorl@infinidat.com> wrote:
> >
> > On Sun, Sep 2, 2018 at 8:55 PM Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:
> > >
> > > On Sun, Sep 2, 2018 at 4:44 AM Richard Weinberger
> > > <richard.weinberger@gmail.com> wrote:
> > > >
> > > > CC'ing relevant people. Otherwise your mail might get lost.
> > >
> > > Indeed.
> >
> > Sorry for that.
> >
> > > > On Sun, Sep 2, 2018 at 1:37 PM Dror Levin <drorl@infinidat.com> wrote:
> > > > >
> > > > > We have an internal tool that uses the bsg read/write interface to
> > > > > issue SCSI commands as part of a test suite for a storage device.
> > > > >
> > > > > After recently reading on LWN that this interface is to be removed we
> > > > > tried porting our code to use sg instead. However, that raises new
> > > > > issues - mainly getting ENOMEM over iSCSI for unknown reasons.
> > >
> > > Is there any chance that you can make more data available?
> >
> > Sure, I can try.
> >
> > We use writev() to send up to SG_MAX_QUEUE tasks at a time. Occasionally not
> > all tasks are written at which point we wait for tasks to return before
> > sending more, but then writev() fails with ENOMEM and we see this in the syslog:
> >
> > Sep 1 20:58:14 gdc-qa-io-017 kernel: sd 441:0:0:5: [sg73]
> > sg_common_write: start_req err=-12
> >
> > Failing tasks are reads of 128KiB.
> >
> > > I'd rather fix the sg interface (which while also broken garbage, we
> > > can't get rid of) than re-surrect the bsg interface.
>
> Discussion seems to have died down but release of 4.19 is drawing near.
>
> Is there still any chance removal of bsg can be reconsidered? Maybe
> postponed to the
> next version to allow more time to adjust?
>
> I'm especially concerned about the possibility of this being
> backported to stable kernels
> which might leave us very little time to fix our code.
What is being backported to what stable kernels and why?
Is there sg patches?
totally confused,
greg k-h
next prev parent reply other threads:[~2018-10-05 22:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-02 11:35 Recent removal of bsg read/write support Dror Levin
2018-09-02 11:44 ` Richard Weinberger
2018-09-02 17:55 ` Linus Torvalds
2018-09-03 8:34 ` Dror Levin
2018-09-04 4:10 ` Douglas Gilbert
2018-10-04 6:58 ` Dror Levin
2018-10-05 22:35 ` Greg KH [this message]
2018-10-05 23:27 ` Douglas Gilbert
2019-02-01 17:44 ` Douglas Gilbert
2018-09-02 19:16 ` Douglas Gilbert
2018-09-03 12:28 ` Michal Hocko
2018-09-04 3:38 ` Douglas Gilbert
2018-09-04 6:59 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005223526.GF13613@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=drorl@infinidat.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=richard.weinberger@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.