From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [net-next,09/19] net: usb: aqc111: Implement RX data path From: Andrew Lunn Message-Id: <20181006011843.GC32455@lunn.ch> Date: Sat, 6 Oct 2018 03:18:43 +0200 To: Igor Russkikh Cc: "David S . Miller" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , Dmitry Bezrukov List-ID: PiArc3RhdGljIGludCBhcWMxMTFfcnhfZml4dXAoc3RydWN0IHVzYm5ldCAqZGV2LCBzdHJ1Y3Qg c2tfYnVmZiAqc2tiKQo+ICt7Cj4gKwlzdHJ1Y3Qgc2tfYnVmZiAqbmV3X3NrYiA9IE5VTEw7Cj4g Kwl1MzIgc2tiX2xlbiA9IDA7Cj4gKwl1MzIgZGVzY19vZmZzZXQgPSAwOyAvKlJYIEhlYWRlciBP ZmZzZXQqLwo+ICsJdTMyIHN0YXJ0X29mX2Rlc2NzID0gMDsKPiArCXUxNiBwa3RfY291bnQgPSAw Owo+ICsJdTMyIHBrdF90b3RhbF9vZmZzZXQgPSAwOwo+ICsJc3RydWN0IGFxX3J4X3BhY2tldF9k ZXNjICpwa3RfZGVzYyA9IE5VTEw7Cj4gKwlzdHJ1Y3QgYXFfcnhfZGVzY19oZWFkZXIgZGVzY19o ZHI7Cj4gKwo+ICsJaWYgKCFza2IpCj4gKwkJZ290byBlcnI7Cj4gKwo+ICsJaWYgKHNrYi0+bGVu ID09IDApCj4gKwkJZ290byBlcnI7Cj4gKwo+ICsJc2tiX2xlbiA9IHNrYi0+bGVuOwo+ICsJLyog UlggT2Zmc2V0IEhlYWRlciAqLwo+ICsJc2tiX3RyaW0oc2tiLCBza2ItPmxlbiAtIHNpemVvZihz dHJ1Y3QgYXFfcnhfZGVzY19oZWFkZXIpKTsKPiArCW1lbWNweSgmZGVzY19oZHIsIHNrYl90YWls X3BvaW50ZXIoc2tiKSwKPiArCSAgICAgICBzaXplb2Yoc3RydWN0IGFxX3J4X2Rlc2NfaGVhZGVy KSk7Cj4gKwlsZTY0X3RvX2NwdXMoJmRlc2NfaGRyKTsKClNhbWUgcXVlc3Rpb24gYXMgZm9yIFRY LgoKPiArCj4gKwkvKiBDaGVjayB0aGVzZSBwYWNrZXRzICovCj4gKwlkZXNjX29mZnNldCA9ICh1 MzIpZGVzY19oZHIuZGVzY19vZmZzZXQ7CgpJIGRvbid0IHRoaW5rIHlvdSBuZWVkIHRoZSBjYXN0 IGhlcmUuCgpQbGVhc2UgcmV2aWV3IGFsbCB5b3VyIGNhc3RzIGFuZCByZW1vdmUgYW55IHRoYXQg YXJlIG5vdCBuZWVkZWQuCgogICAgICAgQW5kcmV3Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 09/19] net: usb: aqc111: Implement RX data path Date: Sat, 6 Oct 2018 03:18:43 +0200 Message-ID: <20181006011843.GC32455@lunn.ch> References: <81aef6c50a93d22c6b91e966c89d7520dcbaaf87.1538734658.git.igor.russkikh@aquantia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S . Miller" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , Dmitry Bezrukov To: Igor Russkikh Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:55555 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726830AbeJFIUF (ORCPT ); Sat, 6 Oct 2018 04:20:05 -0400 Content-Disposition: inline In-Reply-To: <81aef6c50a93d22c6b91e966c89d7520dcbaaf87.1538734658.git.igor.russkikh@aquantia.com> Sender: netdev-owner@vger.kernel.org List-ID: > +static int aqc111_rx_fixup(struct usbnet *dev, struct sk_buff *skb) > +{ > + struct sk_buff *new_skb = NULL; > + u32 skb_len = 0; > + u32 desc_offset = 0; /*RX Header Offset*/ > + u32 start_of_descs = 0; > + u16 pkt_count = 0; > + u32 pkt_total_offset = 0; > + struct aq_rx_packet_desc *pkt_desc = NULL; > + struct aq_rx_desc_header desc_hdr; > + > + if (!skb) > + goto err; > + > + if (skb->len == 0) > + goto err; > + > + skb_len = skb->len; > + /* RX Offset Header */ > + skb_trim(skb, skb->len - sizeof(struct aq_rx_desc_header)); > + memcpy(&desc_hdr, skb_tail_pointer(skb), > + sizeof(struct aq_rx_desc_header)); > + le64_to_cpus(&desc_hdr); Same question as for TX. > + > + /* Check these packets */ > + desc_offset = (u32)desc_hdr.desc_offset; I don't think you need the cast here. Please review all your casts and remove any that are not needed. Andrew