From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g8jKL-0005Nu-5f for kexec@lists.infradead.org; Sat, 06 Oct 2018 09:56:51 +0000 Date: Sat, 6 Oct 2018 11:56:27 +0200 From: Borislav Petkov Subject: Re: [PATCH v8 RESEND 0/4] Support kdump for AMD secure memory encryption(SME) Message-ID: <20181006095627.GA30555@zn.tnic> References: <20180930031033.22110-1-lijiang@redhat.com> <20181002114012.GB29859@zn.tnic> <43da68b1-fda0-c033-39e1-907d01f13354@redhat.com> <20181003113435.GB4436@zn.tnic> <20181004190221.GA17667@zn.tnic> <0d1c112c-37b7-ee9d-b3d6-6d8e3df02d78@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0d1c112c-37b7-ee9d-b3d6-6d8e3df02d78@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: lijiang Cc: thomas.lendacky@amd.com, jroedel@suse.de, brijesh.singh@amd.com, bhe@redhat.com, tiwai@suse.de, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, mingo@redhat.com, baiyaowei@cmss.chinamobile.com, hpa@zytor.com, bhelgaas@google.com, tglx@linutronix.de, dyoung@redhat.com, akpm@linux-foundation.org, dan.j.williams@intel.com T24gRnJpLCBPY3QgMDUsIDIwMTggYXQgMDE6NTI6MjZQTSArMDgwMCwgbGlqaWFuZyB3cm90ZToK PiAgICAgIGIuIGFkZCB0aGUgcGFyYW1ldGVyICJtZW1fZW5jcnlwdD1vbiIgZm9yIGtlcm5lbCBj b21tYW5kLWxpbmUgdG8gZ3J1Yi5jZmcsIGlmCj4gICAgICAgICB0aGlzIG1hY2hpbmUgaGFzIFNN RSBmZWF0dXJlLiBBbmQgYWxzbyBhZGQgY3Jhc2hrZXJuZWw9eHgsIHdoaWNoIHdpbGwgcmVzZXJ2 ZQo+ICAgICAgICAgbWVtb3J5IGZvciBrZHVtcC4KCk9rLCBJJ20gZG9pbmcgdGhlIHNpbXBsZXIg Y3Jhc2hrZXJuZWw9IGNtZGxpbmU6CgpjcmFzaGtlcm5lbD0yNTZNCgpUaGF0IHNheXM6CgpbICAg IDAuMDExOTE4XSBSZXNlcnZpbmcgMjU2TUIgb2YgbWVtb3J5IGF0IDY0ME1CIGZvciBjcmFzaGtl cm5lbCAoU3lzdGVtIFJBTTogMjYyMDMwTUIpCgo+IFN0ZXAgNTogcmVib290LCBhbmQgdGhlbiBs b2FkIHRoZSBjcmFzaCBrZXJuZWwgaW1hZ2UgYW5kIGtkdW1wIGluaXRyYW1mcy4KPiAKPiAgICAg IGE6IFdoZW4gU01FIGlzIGVuYWJsZWQsIGkgdXNlIHRoaXMgY29tbWFuZCB0byBsb2FkIHRoZW06 Cj4gCj4gICAgICAgICAja2V4ZWMgLXAgL2Jvb3Qvdm1saW51ei00LjE5LjAtcmM2KyAtLWluaXRy ZD0vYm9vdC9pbml0cmFtZnMtNC4xOS4wLXJjNitrZHVtcC5pbWcgLS1jb21tYW5kLWxpbmU9InJv b3Q9L2Rldi9tYXBwZXIvcmhlbF9ocC0tZGwzODVnMTAtLTAzLXJvb3Qgcm8gcmQubHZtLmx2PXJo ZWxfaHAtZGwzODVnMTAtMDMvcm9vdCByZC5sdm0ubHY9cmhlbF9ocC1kbDM4NWcxMC0wMy9zd2Fw IG1lbV9lbmNyeXB0PW9uIGNvbnNvbGU9dHR5UzAsMTE1MjAwbjgxIExBTkc9ZW5fVVMuVVRGLTgg ZWFybHlwcmludGs9c2VyaWFsIGRlYnVnIGlycXBvbGwgbnJfY3B1cz0xIHJlc2V0X2RldmljZXMg Y2dyb3VwX2Rpc2FibGU9bWVtb3J5IG1jZT1vZmYgbnVtYT1vZmYgdWRldi5jaGlsZHJlbi1tYXg9 MiBwYW5pYz0xMCByb290ZmxhZ3M9bm9mYWlsIGFjcGlfbm9fbWVtaG90cGx1ZyB0cmFuc3BhcmVu dF9odWdlcGFnZT1uZXZlciBkaXNhYmxlX2NwdV9hcGljaWQ9MCIKCk9rLCBkaWQgdGhhdCwgbXkg Y21kbGluZSBpczoKCn4vYnBldGtvdi9zcmMva2V4ZWMtdG9vbHMvYnVpbGQvc2Jpbi9rZXhlYyAt cCAvYm9vdC92bWxpbnV6LTQuMTkuMC1yYzYrIC0taW5pdHJkPS9ib290L2luaXRyZC00LjE5LjAt cmM2KyAtLWNvbW1hbmQtbGluZT0icm9vdD0vZGV2L21hcHBlci91YnVudHUtLTAxMDIzNjAxMjEz Mi0tdmctbGVhcDE1IHJkLmx2bS5sdj11YnVudHUtLTAxMDIzNjAxMjEzMi0tdmctbGVhcDE1L3Jv b3QgcmQubHZtLmx2PXVidW50dS0tMDEwMjM2MDEyMTMyLS12Zy1sZWFwMTUvc3dhcCBzcGxhc2g9 c2lsZW50IHNob3dvcHRzIGNvbnNvbGU9dHR5UzUsMTE1MjAwIGNvbnNvbGU9dHR5MCBkZWJ1ZyBp Z25vcmVfbG9nbGV2ZWwgbG9nX2J1Zl9sZW49MTZNIG5yX2NwdXM9MSBpcnFwb2xsIG1heGNwdXM9 MSByZXNldF9kZXZpY2VzIHZnYT1ub3JtYWwgbWVtX2VuY3J5cHQ9b24gTEFORz1lbl9VUy5VVEYt OCBlYXJseXByaW50az1zZXJpYWwgY2dyb3VwX2Rpc2FibGU9bWVtb3J5IG1jZT1vZmYgbnVtYT1v ZmYgdWRldi5jaGlsZHJlbi1tYXg9MiBwYW5pYz0xMCByb290ZmxhZ3M9bm9mYWlsIGFjcGlfbm9f bWVtaG90cGx1ZyB0cmFuc3BhcmVudF9odWdlcGFnZT1uZXZlciBkaXNhYmxlX2NwdV9hcGljaWQ9 MCIKClZlcmlmaWVkIGl0IGxvYWRlZCBvazoKCiQgZ3JlcCAuIC9zeXMva2VybmVsL2tleGVjXyoK L3N5cy9rZXJuZWwva2V4ZWNfY3Jhc2hfbG9hZGVkOjEKL3N5cy9rZXJuZWwva2V4ZWNfY3Jhc2hf c2l6ZToyNjg0MzU0NTYKL3N5cy9rZXJuZWwva2V4ZWNfbG9hZGVkOjAKCj4gU3RlcCA2OiB0cmln Z2VyIHBhbmljIGJ5IHN5c3JxCj4gICAgICAgICAjZWNobyBjID4gL3Byb2Mvc3lzcnEtdHJpZ2dl cgoKRGlkIHRoYXQgYW5kIEkgZ290IGludG8gdGhlIGtkdW1wIGtlcm5lbCB3aXRoIFNNRS4gU28g SSdkIGd1ZXNzIHlvdXIga2R1bXAKa2VybmVsIGNvbW1hbmQgbGluZSB3YXMgbmVlZGVkIC0gSSB3 YXMgbWlzc2luZyBhIGJ1bmNoIG9mIHN3aXRjaGVzIGFuZApyZW1vdGUtZGVidWdnaW5nIGEgYm94 IGtleGVjaW5nIGlzIG5vdCBmdW4uCgpTbyB0aGFua3MgYSBsb3QgZm9yIHRoZSBkZXRhaWxlZCBz dGVwcywgSSdtIHB1dHRpbmcgdGhlbSB0byBteSBub3Rlcy4KCi0tIApSZWdhcmRzL0dydXNzLAog ICAgQm9yaXMuCgpTVVNFIExpbnV4IEdtYkgsIEdGOiBGZWxpeCBJbWVuZMO2cmZmZXIsIEphbmUg U21pdGhhcmQsIEdyYWhhbSBOb3J0b24sIEhSQiAyMTI4NCAoQUcgTsO8cm5iZXJnKQoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2V4ZWMgbWFpbGluZyBs aXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBDB0C64EB8 for ; Sat, 6 Oct 2018 09:56:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7903620875 for ; Sat, 6 Oct 2018 09:56:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7903620875 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727761AbeJFQ7O (ORCPT ); Sat, 6 Oct 2018 12:59:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:52594 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726409AbeJFQ7O (ORCPT ); Sat, 6 Oct 2018 12:59:14 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 92538ACD8; Sat, 6 Oct 2018 09:56:34 +0000 (UTC) Date: Sat, 6 Oct 2018 11:56:27 +0200 From: Borislav Petkov To: lijiang Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, akpm@linux-foundation.org, dan.j.williams@intel.com, thomas.lendacky@amd.com, bhelgaas@google.com, baiyaowei@cmss.chinamobile.com, tiwai@suse.de, brijesh.singh@amd.com, dyoung@redhat.com, bhe@redhat.com, jroedel@suse.de Subject: Re: [PATCH v8 RESEND 0/4] Support kdump for AMD secure memory encryption(SME) Message-ID: <20181006095627.GA30555@zn.tnic> References: <20180930031033.22110-1-lijiang@redhat.com> <20181002114012.GB29859@zn.tnic> <43da68b1-fda0-c033-39e1-907d01f13354@redhat.com> <20181003113435.GB4436@zn.tnic> <20181004190221.GA17667@zn.tnic> <0d1c112c-37b7-ee9d-b3d6-6d8e3df02d78@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0d1c112c-37b7-ee9d-b3d6-6d8e3df02d78@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 05, 2018 at 01:52:26PM +0800, lijiang wrote: > b. add the parameter "mem_encrypt=on" for kernel command-line to grub.cfg, if > this machine has SME feature. And also add crashkernel=xx, which will reserve > memory for kdump. Ok, I'm doing the simpler crashkernel= cmdline: crashkernel=256M That says: [ 0.011918] Reserving 256MB of memory at 640MB for crashkernel (System RAM: 262030MB) > Step 5: reboot, and then load the crash kernel image and kdump initramfs. > > a: When SME is enabled, i use this command to load them: > > #kexec -p /boot/vmlinuz-4.19.0-rc6+ --initrd=/boot/initramfs-4.19.0-rc6+kdump.img --command-line="root=/dev/mapper/rhel_hp--dl385g10--03-root ro rd.lvm.lv=rhel_hp-dl385g10-03/root rd.lvm.lv=rhel_hp-dl385g10-03/swap mem_encrypt=on console=ttyS0,115200n81 LANG=en_US.UTF-8 earlyprintk=serial debug irqpoll nr_cpus=1 reset_devices cgroup_disable=memory mce=off numa=off udev.children-max=2 panic=10 rootflags=nofail acpi_no_memhotplug transparent_hugepage=never disable_cpu_apicid=0" Ok, did that, my cmdline is: ~/bpetkov/src/kexec-tools/build/sbin/kexec -p /boot/vmlinuz-4.19.0-rc6+ --initrd=/boot/initrd-4.19.0-rc6+ --command-line="root=/dev/mapper/ubuntu--010236012132--vg-leap15 rd.lvm.lv=ubuntu--010236012132--vg-leap15/root rd.lvm.lv=ubuntu--010236012132--vg-leap15/swap splash=silent showopts console=ttyS5,115200 console=tty0 debug ignore_loglevel log_buf_len=16M nr_cpus=1 irqpoll maxcpus=1 reset_devices vga=normal mem_encrypt=on LANG=en_US.UTF-8 earlyprintk=serial cgroup_disable=memory mce=off numa=off udev.children-max=2 panic=10 rootflags=nofail acpi_no_memhotplug transparent_hugepage=never disable_cpu_apicid=0" Verified it loaded ok: $ grep . /sys/kernel/kexec_* /sys/kernel/kexec_crash_loaded:1 /sys/kernel/kexec_crash_size:268435456 /sys/kernel/kexec_loaded:0 > Step 6: trigger panic by sysrq > #echo c > /proc/sysrq-trigger Did that and I got into the kdump kernel with SME. So I'd guess your kdump kernel command line was needed - I was missing a bunch of switches and remote-debugging a box kexecing is not fun. So thanks a lot for the detailed steps, I'm putting them to my notes. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)