From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, okozina@redhat.com, hch@lst.de
Subject: Re: [RFC PATCH] iomap: Enable alignment check for iomap DIO in holes
Date: Sat, 6 Oct 2018 11:59:51 +0200 [thread overview]
Message-ID: <20181006095951.GA6047@lst.de> (raw)
In-Reply-To: <20181005130316.4869-1-cmaiolino@redhat.com>
On Fri, Oct 05, 2018 at 03:03:16PM +0200, Carlos Maiolino wrote:
> Commit 09230435dffdb13de507e5e40b524b0069fc5c7b refactor iomap_dio_actor
> into two different helpers for bio based IO and hole IO, although, the
> latter doesn't check for IO alignment anymore.
>
> Move the DIO alignment check up into the caller, so all iomap DIO has
> alignment checked.
Why? The only reason to check alignmnet for actual I/O is because we
have to. There is no requirement to align holes.
> Christoph, I tagged this patch as RFC, because I couldn't really identify if you
> intentionally dropped the alignment check for holes and inline actors, if you
> didn't drop the alignment check intentionally, please consider it as a normal
> patch.
The primary intent was to simplify the code and not enforce alignment
for inline data support.
next prev parent reply other threads:[~2018-10-06 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 13:03 [RFC PATCH] iomap: Enable alignment check for iomap DIO in holes Carlos Maiolino
2018-10-06 9:59 ` Christoph Hellwig [this message]
2018-10-08 7:24 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181006095951.GA6047@lst.de \
--to=hch@lst.de \
--cc=cmaiolino@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=okozina@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.