From: Christoph Hellwig <hch@lst.de>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH 06/17] target/core: Use sg_alloc_table() instead of open-coding it
Date: Sat, 06 Oct 2018 11:53:45 +0000 [thread overview]
Message-ID: <20181006115345.GA7696@lst.de> (raw)
In-Reply-To: <20180917213554.987-7-bvanassche@acm.org>
On Fri, Oct 05, 2018 at 06:52:12AM -0700, Bart Van Assche wrote:
> On 10/5/18 12:46 AM, Christoph Hellwig wrote:
>> On Mon, Sep 17, 2018 at 02:35:43PM -0700, Bart Van Assche wrote:
>>> The purpose of sg_alloc_table() is to allocate and initialize an
>>> sg-list. Use that function instead of open-coding it.
>>
>> Hmm. This looks correct, but what is the point if we don't plan
>> on using chained sg-lists?
>
> This patch makes it easier to replace the SCSI target sg-list allocation
> code by (library) code that caches sg-list allocations. I still hope to
> find some time to work on this.
Ok.
> Since the rest of this series does not depend on this patch, I can leave it
> out if you want.
Maybe just update the changelog to explain this better?
next prev parent reply other threads:[~2018-10-06 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 21:35 [PATCH 06/17] target/core: Use sg_alloc_table() instead of open-coding it Bart Van Assche
2018-10-05 7:46 ` Christoph Hellwig
2018-10-05 13:52 ` Bart Van Assche
2018-10-06 11:53 ` Christoph Hellwig [this message]
2018-10-08 16:32 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181006115345.GA7696@lst.de \
--to=hch@lst.de \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.