All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH] iommu: Do physical merging in iommu_map_sg()
Date: Sun, 7 Oct 2018 03:38:02 -0700	[thread overview]
Message-ID: <20181007103802.GA20091@infradead.org> (raw)
In-Reply-To: <13093b94-be59-030d-7176-16dab22bcdce-5wv7dgnIgG8@public.gmane.org>

On Fri, Oct 05, 2018 at 11:57:57AM +0100, Robin Murphy wrote:
> Yeah, I fiddled around for ages trying to find the cleanest approach, but
> really there just doesn't seem to be one - I'd say the worst bit of that
> goto is the even-more-subtle need for the explicit break. FWIW the naive
> diff below is only actually +2 source lines, but the duplication does also
> carry through to the object code (at least for my arm64 GCC7 build). I might
> have a quick hack around to see if I can do any better with a do...while
> loop - of course what I *really* want is nested function definitions, but
> that might just be brain damage from doing too much MATLAB in the past ;)

I much prefer this version, even if it leads to slightly larger object
code.

      parent reply	other threads:[~2018-10-07 10:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 15:47 [PATCH] iommu: Do physical merging in iommu_map_sg() Robin Murphy
     [not found] ` <1be92cab99ba7fc82cc355bdda239f2ddcb92db0.1538667993.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2018-10-05  7:19   ` Christoph Hellwig
     [not found]     ` <20181005071934.GA9238-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2018-10-05 10:57       ` Robin Murphy
     [not found]         ` <13093b94-be59-030d-7176-16dab22bcdce-5wv7dgnIgG8@public.gmane.org>
2018-10-07 10:38           ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181007103802.GA20091@infradead.org \
    --to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.