From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,1/7] dt-bindings: stm32-dma: Add DMA/MDMA chaining support bindings From: Vinod Koul Message-Id: <20181007145722.GY2372@vkoul-mobl> Date: Sun, 7 Oct 2018 20:27:22 +0530 To: Pierre-Yves MORDRET Cc: Rob Herring , Mark Rutland , Alexandre Torgue , Maxime Coquelin , Dan Williams , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-ID: T24gMjgtMDktMTgsIDE1OjAxLCBQaWVycmUtWXZlcyBNT1JEUkVUIHdyb3RlOgo+IEZyb206IE0n Ym91bWJhIENlZHJpYyBNYWRpYW5nYSA8Y2VkcmljLm1hZGlhbmdhQGdtYWlsLmNvbT4KPiAKPiBU aGlzIHBhdGNoIGFkZHMgZG1hIGJpbmRpbmdzIHRvIHN1cHBvcnQgRE1BL01ETUEgY2hhaW5pbmcg dHJhbnNmZXIuCj4gMSBiaXQgaXMgdG8gbWFuYWdlIGJvdGggRE1BIEZJRk8gVGhyZXNob2xkCj4g MSBiaXQgaXMgdG8gbWFuYWdlIERNQS9NRE1BIENoYWluaW5nIGZlYXR1cmVzLgo+IDIgYml0cyBh cmUgdXNlZCB0byBzcGVjaWZ5IFNEUkFNIHNpemUgdG8gdXNlIGZvciBETUEvTURNQSBjaGFpbmlu Zy4KClBsZWFzZSBkbyBtZW50aW9uIHdoaWNoIHNwZWNpZmljIGJpdHM/Cgo+IFRoZSBzaXplIGlu IGJ5dGVzIG9mIGEgY2VydGFpbiBvcmRlciBpcyBnaXZlbiBieSB0aGUgZm9ybXVsYToKPiAgICAg KDIgXiBvcmRlcikgKiBQQUdFX1NJWkUuCj4gVGhlIG9yZGVyIGlzIGdpdmVuIGJ5IHRob3NlIDIg Yml0cy4KPiBGb3IgY3ljbGljLCB3aGV0aGVyIGNoYWluaW5nIGlzIGNob3NlbiwgYW55IHZhbHVl IGFib3ZlIDEgY2FuIGJlIHNldCA6Cj4gU1JBTSBidWZmZXIgc2l6ZSB3aWxsIHJlbHkgb24gcGVy aW9kIHNpemUgYW5kIG5vdCBvbiB0aGlzIERUIHZhbHVlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBp ZXJyZS1ZdmVzIE1PUkRSRVQgPHBpZXJyZS15dmVzLm1vcmRyZXRAc3QuY29tPgo+IC0tLQo+ICAg VmVyc2lvbiBoaXN0b3J5Ogo+ICAgICB2MzoKPiAgICAgdjI6Cj4gICAgICAgICogcmV3b3JrIGNv bnRlbnQKPiAgICAgdjE6Cj4gICAgICAgICogSW5pdGlhbAo+IC0tLQo+IC0tLQo+ICAuLi4vZGV2 aWNldHJlZS9iaW5kaW5ncy9kbWEvc3RtMzItZG1hLnR4dCAgICAgICAgICB8IDI3ICsrKysrKysr KysrKysrKysrKysrKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2RtYS9zdG0zMi1kbWEudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L2RtYS9zdG0zMi1kbWEudHh0Cj4gaW5kZXggYzVmNTE5MC4uMmJhYzhjNyAxMDA2NDQKPiAtLS0g YS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZG1hL3N0bTMyLWRtYS50eHQKPiAr KysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZG1hL3N0bTMyLWRtYS50eHQK PiBAQCAtMTcsNiArMTcsMTIgQEAgT3B0aW9uYWwgcHJvcGVydGllczoKPiAgLSByZXNldHM6IFJl ZmVyZW5jZSB0byBhIHJlc2V0IGNvbnRyb2xsZXIgYXNzZXJ0aW5nIHRoZSBETUEgY29udHJvbGxl cgo+ICAtIHN0LG1lbTJtZW06IGJvb2xlYW47IGlmIGRlZmluZWQsIGl0IGluZGljYXRlcyB0aGF0 IHRoZSBjb250cm9sbGVyIHN1cHBvcnRzCj4gICAgbWVtb3J5LXRvLW1lbW9yeSB0cmFuc2Zlcgo+ ICstIGRtYXM6IEEgbGlzdCBvZiBlaWdodCBkbWEgc3BlY2lmaWVycywgb25lIGZvciBlYWNoIGVu dHJ5IGluIGRtYS1uYW1lcy4KPiArICBSZWZlciB0byBzdG0zMi1tZG1hLnR4dCBmb3IgbW9yZSBk ZXRhaWxzLgo+ICstIGRtYS1uYW1lczogc2hvdWxkIGNvbnRhaW4gImNoMCIsICJjaDEiLCAiY2gy IiwgImNoMyIsICJjaDQiLCAiY2g1IiwgImNoNiIgYW5kCj4gKyAgImNoNyIgYW5kIHJlcHJlc2Vu dHMgZWFjaCBTVE0zMiBETUEgY2hhbm5lbCBjb25uZWN0ZWQgdG8gYSBTVE0zMiBNRE1BIG9uZS4K PiArLSBtZW1vcnktcmVnaW9uIDogcGhhbmRsZSB0byBhIG5vZGUgZGVzY3JpYmluZyBtZW1vcnkg dG8gYmUgdXNlZCBmb3IKPiArICBNMk0gaW50ZXJtZWRpYXRlIHRyYW5zZmVyIGJldHdlZW4gRE1B IGFuZCBNRE1BLgo+ICAKPiAgRXhhbXBsZToKPiAgCj4gQEAgLTM2LDYgKzQyLDE2IEBAIEV4YW1w bGU6Cj4gIAkJc3QsbWVtMm1lbTsKPiAgCQlyZXNldHMgPSA8JnJjYyAxNTA+Owo+ICAJCWRtYS1y ZXF1ZXN0cyA9IDw4PjsKPiArCQlkbWFzID0gPCZtZG1hMSA4IDB4MTAgMHgxMjAwMDAwYSAweDQw MDI2NDA4IDB4MDAwMDAwMjAgMT4sCj4gKwkJICAgICAgIDwmbWRtYTEgOSAweDEwIDB4MTIwMDAw MGEgMHg0MDAyNjQwOCAweDAwMDAwODAwIDE+LAo+ICsJCSAgICAgICA8Jm1kbWExIDEwIDB4MTAg MHgxMjAwMDAwYSAweDQwMDI2NDA4IDB4MDAyMDAwMDAgMT4sCj4gKwkJICAgICAgIDwmbWRtYTEg MTEgMHgxMCAweDEyMDAwMDBhIDB4NDAwMjY0MDggMHgwODAwMDAwMCAxPiwKPiArCQkgICAgICAg PCZtZG1hMSAxMiAweDEwIDB4MTIwMDAwMGEgMHg0MDAyNjQwQyAweDAwMDAwMDIwIDE+LAo+ICsJ CSAgICAgICA8Jm1kbWExIDEzIDB4MTAgMHgxMjAwMDAwYSAweDQwMDI2NDBDIDB4MDAwMDA4MDAg MT4sCj4gKwkJICAgICAgIDwmbWRtYTEgMTQgMHgxMCAweDEyMDAwMDBhIDB4NDAwMjY0MEMgMHgw MDIwMDAwMCAxPiwKPiArCQkgICAgICAgPCZtZG1hMSAxNSAweDEwIDB4MTIwMDAwMGEgMHg0MDAy NjQwQyAweDA4MDAwMDAwIDE+Owo+ICsJCWRtYS1uYW1lcyA9ICJjaDAiLCAiY2gxIiwgImNoMiIs ICJjaDMiLCAiY2g0IiwgImNoNSIsICJjaDYiLCAiY2g3IjsKPiArCQltZW1vcnktcmVnaW9uID0g PCZzcmFtX2RtYXBvb2w+Owo+ICAJfTsKPiAgCj4gICogRE1BIGNsaWVudAo+IEBAIC02OCw3ICs4 NCwxNiBAQCBjaGFubmVsOiBhIHBoYW5kbGUgdG8gdGhlIERNQSBjb250cm9sbGVyIHBsdXMgdGhl IGZvbGxvd2luZyBmb3VyIGludGVnZXIgY2VsbHM6Cj4gIAkweDE6IDEvMiBmdWxsIEZJRk8KPiAg CTB4MjogMy80IGZ1bGwgRklGTwo+ICAJMHgzOiBmdWxsIEZJRk8KPiAtCj4gKyAtYml0IDI6IElu dGVybWVkaWF0ZSBNMk0gdHJhbnNmZXIgZnJvbS90byBERFIgdG8vZnJvbSBTUkFNIHRocm91Z2hv dXQgTURNQQo+ICsJMDogTURNQSBub3QgdXNlZCB0byBnZW5lcmF0ZSBhbiBpbnRlcm1lZGlhdGUg TTJNIHRyYW5zZmVyCj4gKwkxOiBNRE1BIHVzZWQgdG8gZ2VuZXJhdGUgYW4gaW50ZXJtZWRpYXRl IE0yTSB0cmFuc2Zlci4KPiArIC1iaXQgMy00OiBpbmRpY2F0ZWQgU1JBTSBCdWZmZXIgc2l6ZSBp biAoMl5vcmRlcikqUEFHRV9TSVpFLgo+ICsJUEFHRV9TSVpFIGlzIGdpdmVuIGJ5IExpbnV4IGF0 IDRLaUI6IGluY2x1ZGUvYXNtLWdlbmVyaWMvcGFnZS5oLgo+ICsJT3JkZXIgaXMgZ2l2ZW4gYnkg dGhvc2UgMiBiaXRzIHN0YXJ0aW5nIGF0IDAuCj4gKwlWYWxpZCBvbmx5IHdoZXRoZXIgSW50ZXJt ZWRpYXRlIE0yTSB0cmFuc2ZlciBpcyBzZXQuCgp3aHkgZG8gd2UgbmVlZCB0aGlzIGFzIGEgcHJv cGVydHk/Cgo+ICsJRm9yIGN5Y2xpYywgd2hldGhlciBJbnRlcm1lZGlhdGUgTTJNIHRyYW5zZmVy IGlzIGNob3NlbiwgYW55IHZhbHVlIGNhbgo+ICsJYmUgc2V0OiBTUkFNIGJ1ZmZlciBzaXplIHdp bGwgcmVseSBvbiBwZXJpb2Qgc2l6ZSBhbmQgbm90IG9uIHRoaXMgRFQKPiArCXZhbHVlLgo+ICAK PiAgRXhhbXBsZToKPiAgCj4gLS0gCj4gMi43LjQK From mboxrd@z Thu Jan 1 00:00:00 1970 From: vkoul@kernel.org (Vinod) Date: Sun, 7 Oct 2018 20:27:22 +0530 Subject: [PATCH v3 1/7] dt-bindings: stm32-dma: Add DMA/MDMA chaining support bindings In-Reply-To: <1538139715-24406-2-git-send-email-pierre-yves.mordret@st.com> References: <1538139715-24406-1-git-send-email-pierre-yves.mordret@st.com> <1538139715-24406-2-git-send-email-pierre-yves.mordret@st.com> Message-ID: <20181007145722.GY2372@vkoul-mobl> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 28-09-18, 15:01, Pierre-Yves MORDRET wrote: > From: M'boumba Cedric Madianga > > This patch adds dma bindings to support DMA/MDMA chaining transfer. > 1 bit is to manage both DMA FIFO Threshold > 1 bit is to manage DMA/MDMA Chaining features. > 2 bits are used to specify SDRAM size to use for DMA/MDMA chaining. Please do mention which specific bits? > The size in bytes of a certain order is given by the formula: > (2 ^ order) * PAGE_SIZE. > The order is given by those 2 bits. > For cyclic, whether chaining is chosen, any value above 1 can be set : > SRAM buffer size will rely on period size and not on this DT value. > > Signed-off-by: Pierre-Yves MORDRET > --- > Version history: > v3: > v2: > * rework content > v1: > * Initial > --- > --- > .../devicetree/bindings/dma/stm32-dma.txt | 27 +++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/dma/stm32-dma.txt b/Documentation/devicetree/bindings/dma/stm32-dma.txt > index c5f5190..2bac8c7 100644 > --- a/Documentation/devicetree/bindings/dma/stm32-dma.txt > +++ b/Documentation/devicetree/bindings/dma/stm32-dma.txt > @@ -17,6 +17,12 @@ Optional properties: > - resets: Reference to a reset controller asserting the DMA controller > - st,mem2mem: boolean; if defined, it indicates that the controller supports > memory-to-memory transfer > +- dmas: A list of eight dma specifiers, one for each entry in dma-names. > + Refer to stm32-mdma.txt for more details. > +- dma-names: should contain "ch0", "ch1", "ch2", "ch3", "ch4", "ch5", "ch6" and > + "ch7" and represents each STM32 DMA channel connected to a STM32 MDMA one. > +- memory-region : phandle to a node describing memory to be used for > + M2M intermediate transfer between DMA and MDMA. > > Example: > > @@ -36,6 +42,16 @@ Example: > st,mem2mem; > resets = <&rcc 150>; > dma-requests = <8>; > + dmas = <&mdma1 8 0x10 0x1200000a 0x40026408 0x00000020 1>, > + <&mdma1 9 0x10 0x1200000a 0x40026408 0x00000800 1>, > + <&mdma1 10 0x10 0x1200000a 0x40026408 0x00200000 1>, > + <&mdma1 11 0x10 0x1200000a 0x40026408 0x08000000 1>, > + <&mdma1 12 0x10 0x1200000a 0x4002640C 0x00000020 1>, > + <&mdma1 13 0x10 0x1200000a 0x4002640C 0x00000800 1>, > + <&mdma1 14 0x10 0x1200000a 0x4002640C 0x00200000 1>, > + <&mdma1 15 0x10 0x1200000a 0x4002640C 0x08000000 1>; > + dma-names = "ch0", "ch1", "ch2", "ch3", "ch4", "ch5", "ch6", "ch7"; > + memory-region = <&sram_dmapool>; > }; > > * DMA client > @@ -68,7 +84,16 @@ channel: a phandle to the DMA controller plus the following four integer cells: > 0x1: 1/2 full FIFO > 0x2: 3/4 full FIFO > 0x3: full FIFO > - > + -bit 2: Intermediate M2M transfer from/to DDR to/from SRAM throughout MDMA > + 0: MDMA not used to generate an intermediate M2M transfer > + 1: MDMA used to generate an intermediate M2M transfer. > + -bit 3-4: indicated SRAM Buffer size in (2^order)*PAGE_SIZE. > + PAGE_SIZE is given by Linux at 4KiB: include/asm-generic/page.h. > + Order is given by those 2 bits starting at 0. > + Valid only whether Intermediate M2M transfer is set. why do we need this as a property? > + For cyclic, whether Intermediate M2M transfer is chosen, any value can > + be set: SRAM buffer size will rely on period size and not on this DT > + value. > > Example: > > -- > 2.7.4 -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Subject: Re: [PATCH v3 1/7] dt-bindings: stm32-dma: Add DMA/MDMA chaining support bindings Date: Sun, 7 Oct 2018 20:27:22 +0530 Message-ID: <20181007145722.GY2372@vkoul-mobl> References: <1538139715-24406-1-git-send-email-pierre-yves.mordret@st.com> <1538139715-24406-2-git-send-email-pierre-yves.mordret@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1538139715-24406-2-git-send-email-pierre-yves.mordret@st.com> Sender: linux-kernel-owner@vger.kernel.org To: Pierre-Yves MORDRET Cc: Rob Herring , Mark Rutland , Alexandre Torgue , Maxime Coquelin , Dan Williams , devicetree@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On 28-09-18, 15:01, Pierre-Yves MORDRET wrote: > From: M'boumba Cedric Madianga > > This patch adds dma bindings to support DMA/MDMA chaining transfer. > 1 bit is to manage both DMA FIFO Threshold > 1 bit is to manage DMA/MDMA Chaining features. > 2 bits are used to specify SDRAM size to use for DMA/MDMA chaining. Please do mention which specific bits? > The size in bytes of a certain order is given by the formula: > (2 ^ order) * PAGE_SIZE. > The order is given by those 2 bits. > For cyclic, whether chaining is chosen, any value above 1 can be set : > SRAM buffer size will rely on period size and not on this DT value. > > Signed-off-by: Pierre-Yves MORDRET > --- > Version history: > v3: > v2: > * rework content > v1: > * Initial > --- > --- > .../devicetree/bindings/dma/stm32-dma.txt | 27 +++++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/dma/stm32-dma.txt b/Documentation/devicetree/bindings/dma/stm32-dma.txt > index c5f5190..2bac8c7 100644 > --- a/Documentation/devicetree/bindings/dma/stm32-dma.txt > +++ b/Documentation/devicetree/bindings/dma/stm32-dma.txt > @@ -17,6 +17,12 @@ Optional properties: > - resets: Reference to a reset controller asserting the DMA controller > - st,mem2mem: boolean; if defined, it indicates that the controller supports > memory-to-memory transfer > +- dmas: A list of eight dma specifiers, one for each entry in dma-names. > + Refer to stm32-mdma.txt for more details. > +- dma-names: should contain "ch0", "ch1", "ch2", "ch3", "ch4", "ch5", "ch6" and > + "ch7" and represents each STM32 DMA channel connected to a STM32 MDMA one. > +- memory-region : phandle to a node describing memory to be used for > + M2M intermediate transfer between DMA and MDMA. > > Example: > > @@ -36,6 +42,16 @@ Example: > st,mem2mem; > resets = <&rcc 150>; > dma-requests = <8>; > + dmas = <&mdma1 8 0x10 0x1200000a 0x40026408 0x00000020 1>, > + <&mdma1 9 0x10 0x1200000a 0x40026408 0x00000800 1>, > + <&mdma1 10 0x10 0x1200000a 0x40026408 0x00200000 1>, > + <&mdma1 11 0x10 0x1200000a 0x40026408 0x08000000 1>, > + <&mdma1 12 0x10 0x1200000a 0x4002640C 0x00000020 1>, > + <&mdma1 13 0x10 0x1200000a 0x4002640C 0x00000800 1>, > + <&mdma1 14 0x10 0x1200000a 0x4002640C 0x00200000 1>, > + <&mdma1 15 0x10 0x1200000a 0x4002640C 0x08000000 1>; > + dma-names = "ch0", "ch1", "ch2", "ch3", "ch4", "ch5", "ch6", "ch7"; > + memory-region = <&sram_dmapool>; > }; > > * DMA client > @@ -68,7 +84,16 @@ channel: a phandle to the DMA controller plus the following four integer cells: > 0x1: 1/2 full FIFO > 0x2: 3/4 full FIFO > 0x3: full FIFO > - > + -bit 2: Intermediate M2M transfer from/to DDR to/from SRAM throughout MDMA > + 0: MDMA not used to generate an intermediate M2M transfer > + 1: MDMA used to generate an intermediate M2M transfer. > + -bit 3-4: indicated SRAM Buffer size in (2^order)*PAGE_SIZE. > + PAGE_SIZE is given by Linux at 4KiB: include/asm-generic/page.h. > + Order is given by those 2 bits starting at 0. > + Valid only whether Intermediate M2M transfer is set. why do we need this as a property? > + For cyclic, whether Intermediate M2M transfer is chosen, any value can > + be set: SRAM buffer size will rely on period size and not on this DT > + value. > > Example: > > -- > 2.7.4 -- ~Vinod