From: Al Viro <viro@ZenIV.linux.org.uk>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ovl: untangle copy up call chain
Date: Sun, 7 Oct 2018 17:06:49 +0100 [thread overview]
Message-ID: <20181007160648.GY32577@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20181006041531.30246-1-amir73il@gmail.com>
On Sat, Oct 06, 2018 at 07:15:31AM +0300, Amir Goldstein wrote:
> +static int ovl_link_tmpfile(struct ovl_copy_up_ctx *c, struct dentry *temp,
> + struct dentry **newdentry)
> +{
> + int err;
> + struct dentry *upper = NULL;
> + struct inode *udir = d_inode(c->destdir);
> +
> + inode_lock_nested(udir, I_MUTEX_PARENT);
> + upper = lookup_one_len(c->destname.name, c->destdir, c->destname.len);
> + err = PTR_ERR(upper);
> + if (IS_ERR(upper))
> + goto out;
dput(ERR_PTR(something)) will immediately oops on you...
next prev parent reply other threads:[~2018-10-07 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-06 4:15 [PATCH] ovl: untangle copy up call chain Amir Goldstein
2018-10-07 16:06 ` Al Viro [this message]
2018-10-08 3:16 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181007160648.GY32577@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.