All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com
Subject: Re: [PATCH] staging: iio: ad2s1210: fix 'assignment operator' style checks
Date: Sun, 7 Oct 2018 17:42:14 +0100	[thread overview]
Message-ID: <20181007174214.2ecf61ee@archlinux> (raw)
In-Reply-To: <CAHd-oW7Xpr-+1SuxsjduFhrRqh7TcGTqmJ22A7W7Oqk8o2E1Kg@mail.gmail.com>

On Fri, 5 Oct 2018 22:24:26 -0300
Matheus Tavares Bernardino <matheus.bernardino@usp.br> wrote:

> This patch fixes all "Assignment operator '=' should be on the previous
> line" checks found in ad2s1210.c by checkpatch.pl.
> 
> Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br>
Hi Matheus,

Good change, but unfortunately your email client as converted
tabs into spaces so it cannot be applied.   Try git am 
with this email and you'll see what I mean.
See Documentation/process/email-clients.rst for some hints on this.

Looking forward to V2 with that fixed!

Thanks,

Jonathan
> ---
>  drivers/staging/iio/resolver/ad2s1210.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c
> b/drivers/staging/iio/resolver/ad2s1210.c
> index ac13b99bd9cb..d4b1c2c010f2 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -301,8 +301,8 @@ static ssize_t ad2s1210_store_control(struct device *dev,
>              "ad2s1210: write control register fail\n");
>          goto error_ret;
>      }
> -    st->resolution
> -        = ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
> +    st->resolution =
> +        ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
>      if (st->pdata->gpioin) {
>          data = ad2s1210_read_resolution_pin(st);
>          if (data != st->resolution)
> @@ -363,8 +363,8 @@ static ssize_t ad2s1210_store_resolution(struct device *dev,
>          dev_err(dev, "ad2s1210: setting resolution fail\n");
>          goto error_ret;
>      }
> -    st->resolution
> -        = ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
> +    st->resolution =
> +        ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION];
>      if (st->pdata->gpioin) {
>          data = ad2s1210_read_resolution_pin(st);
>          if (data != st->resolution)

  reply	other threads:[~2018-10-07 23:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-06  1:24 [PATCH] staging: iio: ad2s1210: fix 'assignment operator' style checks Matheus Tavares Bernardino
2018-10-07 16:42 ` Jonathan Cameron [this message]
2018-10-07 17:40 ` Himanshu Jha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181007174214.2ecf61ee@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-usp@googlegroups.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matheus.bernardino@usp.br \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.