From: Fam Zheng <famz@redhat.com>
To: yuchenlin <yuchenlin@synology.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] vmdk: align end of file to a sector boundary
Date: Mon, 8 Oct 2018 10:38:22 +0800 [thread overview]
Message-ID: <20181008023523.GA13536@magic> (raw)
In-Reply-To: <4e0dfed2afdc5a551f37ecbcbf5f4ade@synology.com>
On Fri, 10/05 10:00, yuchenlin wrote:
> Ping?
Hi,
This was merged as 51b3c6b73acae1e3fd3c7d441fc86dd17356695f.
Fam
>
> On 2018-09-13 16:34, Fam Zheng wrote:
> > On Thu, 09/13 16:29, yuchenlin@synology.com wrote:
> > > From: yuchenlin <yuchenlin@synology.com>
> > >
> > > There is a rare case which the size of last compressed cluster
> > > is larger than the cluster size, which will cause the file is
> > > not aligned at the sector boundary.
> > >
> > > There are three reasons to do it. First, if vmdk doesn't align at
> > > the sector boundary, there may be many undefined behaviors,
> > > such as, in vbox it will show VMDK: Compressed image is corrupted
> > > 'syno-vm-disk1.vmdk' (VERR_ZIP_CORRUPTED) when we try to import an
> > > ova with unaligned vmdk. Second, all the cluster_sector is aligned
> > > to sector, the last one should be like this, too. Third, it ease
> > > reading with sector based I/Os.
> > >
> > > Signed-off-by: yuchenlin <yuchenlin@synology.com>
> >
> > Reviewed-by: Fam Zheng <famz@redhat.com>
>
next prev parent reply other threads:[~2018-10-08 2:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 8:29 [Qemu-devel] [PATCH v3] vmdk: align end of file to a sector boundary yuchenlin
2018-09-13 8:34 ` Fam Zheng
2018-10-05 2:00 ` yuchenlin
2018-10-08 2:38 ` Fam Zheng [this message]
2018-10-08 3:15 ` yuchenlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008023523.GA13536@magic \
--to=famz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=yuchenlin@synology.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.