From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] utils/get-developers: add -e flag to only list email addresses for git send-email
Date: Mon, 8 Oct 2018 09:43:33 +0200 [thread overview]
Message-ID: <20181008074333.1582-1-peter@korsgaard.com> (raw)
When called with a list of patches, get-developers prints the entire git
send-email invocation line:
./utils/get-developers 0001-git-security-bump-to-version-2.16.5.patch
git send-email --to buildroot at buildroot.org --cc "Matt Weber <matthew.weber@rockwellcollins.com>"
This may be handy when creating an entire patch series and editing a cover
letter, but it does mean that this has to be explicitly executed and
get-developers cannot be used directly by the --cc-cmd option of git
send-email to automatically CC affected developers.
So add an -e flag to only let get-developers print the email addresses of
the affected developers in the one-email-per-line format expected by git
send-email, similar to how get_maintainer.pl works in the Linux kernel.
With this and a suitable git configuration:
git config sendemail.to buildroot at buildroot.org
git config sendemail.ccCmd "$(pwd)/utils/get-developers -e"
You can simply do:
git send-email master
To automatically mail the buildroot list and CC affected developers on
patches.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
utils/get-developers | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/utils/get-developers b/utils/get-developers
index f525ff2226..9135b41662 100755
--- a/utils/get-developers
+++ b/utils/get-developers
@@ -18,6 +18,8 @@ def parse_args():
help='find developers in charge of these files')
parser.add_argument('-c', dest='check', action='store_const',
const=True, help='list files not handled by any developer')
+ parser.add_argument('-e', dest='email', action='store_const',
+ const=True, help='only list affected developer email addresses')
return parser.parse_args()
@@ -90,12 +92,16 @@ def __main__():
if i in dev.infras:
matching_devs.add(dev.name)
- result = "--to buildroot at buildroot.org"
- for dev in matching_devs:
- result += " --cc \"%s\"" % dev
+ if args.email:
+ for dev in matching_devs:
+ print dev
+ else:
+ result = "--to buildroot at buildroot.org"
+ for dev in matching_devs:
+ result += " --cc \"%s\"" % dev
- if result != "":
- print("git send-email %s" % result)
+ if result != "":
+ print("git send-email %s" % result)
__main__()
--
2.11.0
next reply other threads:[~2018-10-08 7:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 7:43 Peter Korsgaard [this message]
2018-10-08 7:46 ` [Buildroot] [PATCH] utils/get-developers: add -e flag to only list email addresses for git send-email Thomas Petazzoni
2018-10-08 15:47 ` Thomas Petazzoni
2018-10-08 16:11 ` Arnout Vandecappelle
2018-10-09 8:29 ` Peter Korsgaard
2018-10-21 12:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008074333.1582-1-peter@korsgaard.com \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.