From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Stefan Lengfeld <contact@stefanchrist.eu>
Cc: wsa+renesas@sang-engineering.com, linux-i2c@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, preid@electromag.com.au,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.or,
j-keerthy@ti.com, t-kristo@ti.com, grygorii.strashko@ti.com
Subject: Re: [RFC PATCH 2/3] watchdog: da9062: avoid regmap in restart handler
Date: Mon, 8 Oct 2018 13:07:44 +0300 [thread overview]
Message-ID: <20181008100744.GY15943@smile.fi.intel.com> (raw)
In-Reply-To: <20181007153937.16787-3-contact@stefanchrist.eu>
On Sun, Oct 07, 2018 at 05:39:36PM +0200, Stefan Lengfeld wrote:
> Using i2c_transfer() directly to set the shutdown bit is more reliable
> than using regmap in atomic contexts, because calls to 'schedule()' or
> 'sleep()' must be avoided in call code paths.
> #include <linux/platform_device.h>
> #include <linux/uaccess.h>
> #include <linux/slab.h>
> +#include <linux/i2c.h>
> #include <linux/delay.h>
> #include <linux/jiffies.h>
> #include <linux/mfd/da9062/registers.h>
The rule of thumb when extending a header inclusion block is that try to
squeeze the new inclusion in the longest sorted part of the list.
Rationale behind is easy maintenance.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-10-08 17:19 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 16:14 [RFC PATCH 0/4] i2c: core: introduce master_xfer_irqless Wolfram Sang
2018-09-20 16:14 ` Wolfram Sang
2018-09-20 16:14 ` Wolfram Sang
2018-09-20 16:14 ` [RFC PATCH 1/4] i2c: core: remove outdated DEBUG output Wolfram Sang
2018-09-20 16:14 ` Wolfram Sang
2018-09-20 16:14 ` Wolfram Sang
2018-09-20 17:23 ` Peter Rosin
2018-09-20 17:23 ` Peter Rosin
2018-09-20 17:23 ` Peter Rosin
2018-10-05 16:14 ` Wolfram Sang
2018-10-05 16:14 ` Wolfram Sang
2018-10-05 16:14 ` Wolfram Sang
2018-09-20 16:14 ` [RFC PATCH 2/4] i2c: core: remove level of indentation in i2c_transfer Wolfram Sang
2018-09-20 16:14 ` Wolfram Sang
2018-09-20 16:14 ` Wolfram Sang
2018-09-20 17:26 ` Peter Rosin
2018-09-20 17:26 ` Peter Rosin
2018-09-20 17:26 ` Peter Rosin
2018-09-20 22:46 ` Wolfram Sang
2018-09-20 22:46 ` Wolfram Sang
2018-09-20 22:46 ` Wolfram Sang
2018-10-05 16:15 ` Wolfram Sang
2018-10-05 16:15 ` Wolfram Sang
2018-10-05 16:15 ` Wolfram Sang
2018-09-20 16:14 ` [RFC PATCH 3/4] i2c: core: use I2C locking behaviour also for SMBUS Wolfram Sang
2018-09-20 16:14 ` Wolfram Sang
2018-09-20 16:14 ` Wolfram Sang
2018-09-20 17:31 ` Peter Rosin
2018-09-20 17:31 ` Peter Rosin
2018-09-20 17:31 ` Peter Rosin
2018-09-20 22:48 ` Wolfram Sang
2018-09-20 22:48 ` Wolfram Sang
2018-09-20 22:48 ` Wolfram Sang
2018-09-20 16:14 ` [RFC PATCH 4/4] i2c: core: introduce master_xfer_irqless callback Wolfram Sang
2018-09-20 16:14 ` Wolfram Sang
2018-09-20 16:14 ` Wolfram Sang
2018-09-20 17:41 ` Peter Rosin
2018-09-20 17:41 ` Peter Rosin
2018-09-20 17:41 ` Peter Rosin
2018-09-20 22:55 ` Wolfram Sang
2018-09-20 22:55 ` Wolfram Sang
2018-09-20 22:55 ` Wolfram Sang
2018-10-18 10:44 ` Russell King - ARM Linux
2018-10-18 10:44 ` Russell King - ARM Linux
2018-10-18 10:44 ` Russell King - ARM Linux
2019-02-09 18:03 ` Wolfram Sang
2019-02-09 18:03 ` Wolfram Sang
2018-09-20 22:02 ` [RFC PATCH 0/4] i2c: core: introduce master_xfer_irqless Tony Lindgren
2018-09-20 22:02 ` Tony Lindgren
2018-09-20 22:02 ` Tony Lindgren
2018-09-20 22:56 ` Wolfram Sang
2018-09-20 22:56 ` Wolfram Sang
2018-09-20 22:56 ` Wolfram Sang
2018-10-18 10:35 ` Keerthy
2018-10-18 10:35 ` Keerthy
2018-10-18 10:35 ` Keerthy
2018-09-20 23:01 ` Wolfram Sang
2018-09-20 23:01 ` Wolfram Sang
2018-09-20 23:01 ` Wolfram Sang
2018-09-23 20:20 ` Stefan Lengfeld
2018-09-23 20:20 ` Stefan Lengfeld
2018-09-23 20:20 ` Stefan Lengfeld
2018-10-07 15:39 ` [RFC PATCH 0/3] " Stefan Lengfeld
2018-10-07 15:39 ` [RFC PATCH 1/3] i2c: imx: implement master_xfer_irqless callback Stefan Lengfeld
2018-10-08 10:06 ` Andy Shevchenko
2018-10-07 15:39 ` [RFC PATCH 2/3] watchdog: da9062: avoid regmap in restart handler Stefan Lengfeld
2018-10-08 10:07 ` Andy Shevchenko [this message]
2018-10-07 15:39 ` [RFC PATCH 3/3] ARM: dts: phyboard-mira-dl: rely on PMIC for reboot and watchdog Stefan Lengfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008100744.GY15943@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=contact@stefanchrist.eu \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.or \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=preid@electromag.com.au \
--cc=t-kristo@ti.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.