From: Niklas Cassel <niklas.cassel@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Taniya Das <tdas@codeaurora.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
devicetree@vger.kernel.org, robh@kernel.org,
skannan@codeaurora.org, linux-arm-msm@vger.kernel.org,
amit.kucheria@linaro.org, evgreen@google.com
Subject: Re: [PATCH v8 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver
Date: Mon, 8 Oct 2018 12:38:56 +0200 [thread overview]
Message-ID: <20181008103856.GA10890@centauri.lan> (raw)
In-Reply-To: <20181008095952.gl7di2tnuv3jwew6@vireshk-i7>
On Mon, Oct 08, 2018 at 03:29:52PM +0530, Viresh Kumar wrote:
> On 08-10-18, 10:40, Niklas Cassel wrote:
> > > + ret = of_parse_phandle_with_args(cpu_np, "qcom,freq-domain",
> > > + "#freq-domain-cells", 0, &args);
> >
> > Hello Taniya,
> >
> > in your DT binding, you use
> >
> > #freq-domains-cells = <1>
> >
> > Yet here you parse for "#freq-domain-cells".
>
> And what is the problem with that ? Or are you suggesting her to call
> of_parse_phandle_with_fixed_args() ?
Hello Viresh,
#freq-domain-cells != #freq-domains-cells
The code should parse for the exact same property name as stated in the
DT binding.
Kind regards,
Niklas
next prev parent reply other threads:[~2018-10-08 10:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 10:33 [PATCH v8 0/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver Taniya Das
2018-09-23 10:33 ` [PATCH v8 1/2] dt-bindings: cpufreq: Introduce QCOM CPUFREQ Firmware bindings Taniya Das
2018-09-27 15:31 ` Rob Herring
2018-10-11 10:31 ` Taniya Das
2018-10-21 20:06 ` Bjorn Andersson
2018-09-23 10:33 ` [PATCH v8 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver Taniya Das
2018-10-04 21:04 ` Niklas Cassel
2018-10-11 11:15 ` Taniya Das
2018-10-11 12:43 ` Niklas Cassel
2018-10-11 12:43 ` Niklas Cassel
2018-10-05 10:55 ` Viresh Kumar
2018-10-11 11:19 ` Taniya Das
2018-10-08 8:40 ` Niklas Cassel
2018-10-08 9:59 ` Viresh Kumar
2018-10-08 10:38 ` Niklas Cassel [this message]
2018-10-08 10:40 ` Viresh Kumar
2018-10-08 10:59 ` Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008103856.GA10890@centauri.lan \
--to=niklas.cassel@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@google.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=skannan@codeaurora.org \
--cc=tdas@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.