All of lore.kernel.org
 help / color / mirror / Atom feed
From: Coly Li <colyli@suse.de>
To: axboe@kernel.dk
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
	Ben Peddell <klightspeed@killerwolves.net>,
	Coly Li <colyli@suse.de>
Subject: [PATCH 07/15] bcache: Populate writeback_rate_minimum attribute
Date: Mon,  8 Oct 2018 20:41:13 +0800	[thread overview]
Message-ID: <20181008124121.20192-8-colyli@suse.de> (raw)
In-Reply-To: <20181008124121.20192-1-colyli@suse.de>

From: Ben Peddell <klightspeed@killerwolves.net>

Forgot to include the maintainers with my first email.

Somewhere between Michael Lyle's original
"bcache: PI controller for writeback rate V2" patch dated 07 Sep 2017
and 1d316e6 bcache: implement PI controller for writeback rate,
the mapping of the writeback_rate_minimum attribute was dropped.

Re-add the missing sysfs writeback_rate_minimum attribute mapping to
"allow the user to specify a minimum rate at which dirty blocks are
retired."

Fixes: 1d316e6 bcache: implement PI controller for writeback rate
Signed-off-by: Ben Peddell <klightspeed@killerwolves.net>
Signed-off-by: Coly Li <colyli@suse.de>
---
 drivers/md/bcache/sysfs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
index 150cf4f4cf74..26f035a0c5b9 100644
--- a/drivers/md/bcache/sysfs.c
+++ b/drivers/md/bcache/sysfs.c
@@ -285,6 +285,7 @@ STORE(__cached_dev)
 			    1, WRITEBACK_RATE_UPDATE_SECS_MAX);
 	d_strtoul(writeback_rate_i_term_inverse);
 	d_strtoul_nonzero(writeback_rate_p_term_inverse);
+	d_strtoul_nonzero(writeback_rate_minimum);
 
 	sysfs_strtoul_clamp(io_error_limit, dc->error_limit, 0, INT_MAX);
 
@@ -412,6 +413,7 @@ static struct attribute *bch_cached_dev_files[] = {
 	&sysfs_writeback_rate_update_seconds,
 	&sysfs_writeback_rate_i_term_inverse,
 	&sysfs_writeback_rate_p_term_inverse,
+	&sysfs_writeback_rate_minimum,
 	&sysfs_writeback_rate_debug,
 	&sysfs_errors,
 	&sysfs_io_error_limit,
-- 
2.19.0

  parent reply	other threads:[~2018-10-08 12:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 12:41 [PATCH 00/15] bcache patches for 4.20 Coly Li
2018-10-08 12:41 ` [PATCH 01/15] bcache: account size of buckets used in uuid write to ca->meta_sectors_written Coly Li
2018-10-08 12:41 ` [PATCH 02/15] bcache: trace missed reading by cache_missed Coly Li
2018-10-08 12:41 ` [PATCH 03/15] bcache: use REQ_PRIO to indicate bio for metadata Coly Li
2018-10-08 12:41 ` [PATCH 04/15] bcache: fix ioctl in flash device Coly Li
2018-10-08 12:41 ` [PATCH 05/15] bcache: fix typo in code comments of closure_return_with_destructor() Coly Li
2018-10-08 12:41 ` [PATCH 06/15] bcache: correct dirty data statistics Coly Li
2018-10-08 12:41 ` Coly Li [this message]
2018-10-08 14:19   ` [PATCH 07/15] bcache: Populate writeback_rate_minimum attribute Jens Axboe
2018-10-08 15:02     ` Coly Li
2018-10-08 15:22       ` Jens Axboe
2018-10-08 12:41 ` [PATCH 08/15] bcache: fix miss key refill->end in writeback Coly Li
2018-10-08 12:41 ` [PATCH 09/15] bcache: recal cached_dev_sectors on detach Coly Li
2018-10-08 12:41 ` [PATCH 10/15] bcache: remove unused bch_passthrough_cache Coly Li
2018-10-08 12:41 ` [PATCH 11/15] bcache: remove useless parameter of bch_debug_init() Coly Li
2018-10-08 12:41 ` [PATCH 12/15] bcache: replace hard coded number with BUCKET_GC_GEN_MAX Coly Li
2018-10-08 12:41 ` [PATCH 13/15] bcache: use MAX_CACHES_PER_SET instead of magic number 8 in __bch_bucket_alloc_set Coly Li
2018-10-08 12:41 ` [PATCH 14/15] bcache: split combined if-condition code into separate ones Coly Li
2018-10-08 12:41 ` [PATCH 15/15] bcache: panic fix for making cache device Coly Li
2018-10-08 14:20 ` [PATCH 00/15] bcache patches for 4.20 Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181008124121.20192-8-colyli@suse.de \
    --to=colyli@suse.de \
    --cc=axboe@kernel.dk \
    --cc=klightspeed@killerwolves.net \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.