From: Greg KH <greg@kroah.com>
To: Dafna Hirschfeld <dafna3@gmail.com>
Cc: isely@pobox.com, mchehab@kernel.org, helen.koike@collabora.com,
hverkuil@xs4all.nl, outreachy-kernel@googlegroups.com,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [Outreachy kernel] [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`
Date: Mon, 8 Oct 2018 15:07:19 +0200 [thread overview]
Message-ID: <20181008130719.GA20351@kroah.com> (raw)
In-Reply-To: <20181008120647.10271-1-dafna3@gmail.com>
On Mon, Oct 08, 2018 at 03:06:47PM +0300, Dafna Hirschfeld wrote:
> Replace calls to `printk` with the appropriate `pr_*`
> macro.
>
> Signed-off-by: Dafna Hirschfeld <dafna3@gmail.com>
> ---
> drivers/media/usb/pvrusb2/pvrusb2-debug.h | 2 +-
> drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8 +++---
> drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c | 28 +++++++++-----------
> drivers/media/usb/pvrusb2/pvrusb2-main.c | 4 +--
> drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 4 +--
> 5 files changed, 22 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-debug.h b/drivers/media/usb/pvrusb2/pvrusb2-debug.h
> index 5cd16292e2fa..1323f949f454 100644
> --- a/drivers/media/usb/pvrusb2/pvrusb2-debug.h
> +++ b/drivers/media/usb/pvrusb2/pvrusb2-debug.h
> @@ -17,7 +17,7 @@
>
> extern int pvrusb2_debug;
>
> -#define pvr2_trace(msk, fmt, arg...) do {if(msk & pvrusb2_debug) printk(KERN_INFO "pvrusb2: " fmt "\n", ##arg); } while (0)
> +#define pvr2_trace(msk, fmt, arg...) do {if (msk & pvrusb2_debug) pr_info("pvrusb2: " fmt "\n", ##arg); } while (0)
You should not need prefixes for pr_info() calls.
>
> /* These are listed in *rough* order of decreasing usefulness and
> increasing noise level. */
> diff --git a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> index a8519da0020b..7702285c1519 100644
> --- a/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> +++ b/drivers/media/usb/pvrusb2/pvrusb2-hdw.c
> @@ -3293,12 +3293,12 @@ void pvr2_hdw_trigger_module_log(struct pvr2_hdw *hdw)
> int nr = pvr2_hdw_get_unit_number(hdw);
> LOCK_TAKE(hdw->big_lock);
> do {
> - printk(KERN_INFO "pvrusb2: ================= START STATUS CARD #%d =================\n", nr);
> + pr_info("pvrusb2: ================= START STATUS CARD #%d =================\n", nr);
A driver should be using dev_info(), not pr_*.
Also, for the outreachy application process, I can not accept patches
outside of drivers/staging/.
sorry,
greg k-h
next prev parent reply other threads:[~2018-10-08 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 12:06 [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*` Dafna Hirschfeld
2018-10-08 13:07 ` Greg KH [this message]
2018-10-08 13:29 ` [Outreachy kernel] " Hans Verkuil
2018-10-08 13:52 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2018-10-06 19:21 Dafna Hirschfeld
2018-10-06 23:03 ` [Outreachy kernel] " Sasha Levin
2018-10-07 8:27 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008130719.GA20351@kroah.com \
--to=greg@kroah.com \
--cc=dafna3@gmail.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=isely@pobox.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.