diff for duplicates of <20181008143416.GR3587@dragon> diff --git a/a/1.txt b/N1/1.txt index 23030c3..73b3f1e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -46,7 +46,7 @@ On Fri, Sep 28, 2018 at 12:18:31AM +0200, Lukasz Majewski wrote: > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2018 -> + * Lukasz Majewski, DENX Software Engineering, lukma at denx.de +> + * Lukasz Majewski, DENX Software Engineering, lukma@denx.de > + */ > + > +/dts-v1/; @@ -60,7 +60,7 @@ On Fri, Sep 28, 2018 at 12:18:31AM +0200, Lukasz Majewski wrote: > + stdout-path = &uart1; > + }; > + -> + memory at 80000000 { +> + memory@80000000 { > + reg = <0x80000000 0x8000000>; > + }; > + @@ -143,7 +143,7 @@ In this case, naming it regulator-vcc3v3mcu looks good to me. > + bus-num = <0>; > + status = "okay"; > + -> + spidev0 at 0 { +> + spidev0@0 { > + compatible = "lwn,bk4"; > + spi-max-frequency = <30000000>; > + reg = <0>; @@ -159,7 +159,7 @@ In this case, naming it regulator-vcc3v3mcu looks good to me. > + status = "okay"; > + spi-slave; > + -> + slave at 0 { +> + slave@0 { > + compatible = "lwn,bk4"; > + spi-max-frequency = <30000000>; > + reg = <0>; @@ -195,7 +195,7 @@ In this case, naming it regulator-vcc3v3mcu looks good to me. Please have a newline between properties and child node. -> + ethphy0: ethernet-phy at 1 { +> + ethphy0: ethernet-phy@1 { > + reg = <1>; > + clocks = <&clks VF610_CLK_ENET_50M>; > + clock-names = "rmii-ref"; @@ -216,7 +216,7 @@ Please have a newline between properties and child node. Ditto -> + ethphy1: ethernet-phy at 1 { +> + ethphy1: ethernet-phy@1 { > + reg = <1>; > + clocks = <&clks VF610_CLK_ENET_50M>; > + clock-names = "rmii-ref"; @@ -230,7 +230,7 @@ Ditto > + pinctrl-0 = <&pinctrl_i2c2>; > + status = "okay"; > + -> + eeprom: eeprom at 50 { +> + eeprom: eeprom@50 { It might be better to label the node with model name as below. @@ -240,7 +240,7 @@ It might be better to label the node with model name as below. > + reg = <0x50>; > + }; > + -> + rtc: rtc at 68 { +> + rtc: rtc@68 { m41t62: rtc @@ -256,7 +256,7 @@ It might be better to label the node with model name as below. > + pinctrl-0 = <&pinctrl_nfc>; > + status = "okay"; > + -> + nand at 0 { +> + nand@0 { > + compatible = "fsl,vf610-nfc-nandcs"; > + reg = <0>; > + #address-cells = <1>; @@ -274,11 +274,11 @@ It might be better to label the node with model name as below. > + pinctrl-0 = <&pinctrl_qspi0>; > + status = "okay"; > + -> + flash0: n25q128a13 at 0 { +> + flash0: n25q128a13@0 { Node name should be generic and label name should be specific. - n25q128a13_0: flash at 0 + n25q128a13_0: flash@0 > + compatible = "n25q128a13", "jedec,spi-nor"; > + #address-cells = <1>; @@ -288,9 +288,9 @@ Node name should be generic and label name should be specific. > + reg = <0>; > + }; > + -> + flash1: n25q128a13 at 1 { +> + flash1: n25q128a13@1 { - n25q128a13_1: flash at 1 + n25q128a13_1: flash@1 > + compatible = "n25q128a13", "jedec,spi-nor"; > + #address-cells = <1>; diff --git a/a/content_digest b/N1/content_digest index cb98dc1..049c2bb 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,19 @@ "ref\020180921152726.31742-1-lukma@denx.de\0" "ref\020180927221831.23659-1-lukma@denx.de\0" - "From\0shawnguo@kernel.org (Shawn Guo)\0" - "Subject\0[PATCH v2] ARM: dts: Add support for Liebherr's BK4 device (vf610 based)\0" + "From\0Shawn Guo <shawnguo@kernel.org>\0" + "Subject\0Re: [PATCH v2] ARM: dts: Add support for Liebherr's BK4 device (vf610 based)\0" "Date\0Mon, 8 Oct 2018 22:34:20 +0800\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Lukasz Majewski <lukma@denx.de>\0" + "Cc\0Rob Herring <robh+dt@kernel.org>" + Mark Rutland <mark.rutland@arm.com> + Sascha Hauer <s.hauer@pengutronix.de> + devicetree@vger.kernel.org + linux-kernel@vger.kernel.org + linux-arm-kernel@lists.infradead.org + Pengutronix Kernel Team <kernel@pengutronix.de> + Stefan Agner <stefan@agner.ch> + Fabio Estevam <festevam@gmail.com> + " Fabio Estevam <fabio.estevam@nxp.com>\0" "\00:1\0" "b\0" "On Fri, Sep 28, 2018 at 12:18:31AM +0200, Lukasz Majewski wrote:\n" @@ -54,7 +64,7 @@ "> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)\n" "> +/*\n" "> + * Copyright 2018\n" - "> + * Lukasz Majewski, DENX Software Engineering, lukma at denx.de\n" + "> + * Lukasz Majewski, DENX Software Engineering, lukma@denx.de\n" "> + */\n" "> +\n" "> +/dts-v1/;\n" @@ -68,7 +78,7 @@ "> +\t\tstdout-path = &uart1;\n" "> +\t};\n" "> +\n" - "> +\tmemory at 80000000 {\n" + "> +\tmemory@80000000 {\n" "> +\t\treg = <0x80000000 0x8000000>;\n" "> +\t};\n" "> +\n" @@ -151,7 +161,7 @@ "> +\tbus-num = <0>;\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\tspidev0 at 0 {\n" + "> +\tspidev0@0 {\n" "> +\t\tcompatible = \"lwn,bk4\";\n" "> +\t\tspi-max-frequency = <30000000>;\n" "> +\t\treg = <0>;\n" @@ -167,7 +177,7 @@ "> +\tstatus = \"okay\";\n" "> +\tspi-slave;\n" "> +\n" - "> +\tslave at 0 {\n" + "> +\tslave@0 {\n" "> +\t\tcompatible = \"lwn,bk4\";\n" "> +\t\tspi-max-frequency = <30000000>;\n" "> +\t\treg = <0>;\n" @@ -203,7 +213,7 @@ "\n" "Please have a newline between properties and child node.\n" "\n" - "> +\t\tethphy0: ethernet-phy at 1 {\n" + "> +\t\tethphy0: ethernet-phy@1 {\n" "> +\t\t\treg = <1>;\n" "> +\t\t\tclocks = <&clks VF610_CLK_ENET_50M>;\n" "> +\t\t\tclock-names = \"rmii-ref\";\n" @@ -224,7 +234,7 @@ "\n" "Ditto\n" "\n" - "> +\t\tethphy1: ethernet-phy at 1 {\n" + "> +\t\tethphy1: ethernet-phy@1 {\n" "> +\t\t\treg = <1>;\n" "> +\t\t\tclocks = <&clks VF610_CLK_ENET_50M>;\n" "> +\t\t\tclock-names = \"rmii-ref\";\n" @@ -238,7 +248,7 @@ "> +\tpinctrl-0 = <&pinctrl_i2c2>;\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\teeprom: eeprom at 50 {\n" + "> +\teeprom: eeprom@50 {\n" "\n" "It might be better to label the node with model name as below.\n" "\n" @@ -248,7 +258,7 @@ "> +\t\treg = <0x50>;\n" "> +\t};\n" "> +\n" - "> +\trtc: rtc at 68 {\n" + "> +\trtc: rtc@68 {\n" "\n" "\tm41t62: rtc\n" "\n" @@ -264,7 +274,7 @@ "> +\tpinctrl-0 = <&pinctrl_nfc>;\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\tnand at 0 {\n" + "> +\tnand@0 {\n" "> +\t\tcompatible = \"fsl,vf610-nfc-nandcs\";\n" "> +\t\treg = <0>;\n" "> +\t\t#address-cells = <1>;\n" @@ -282,11 +292,11 @@ "> +\tpinctrl-0 = <&pinctrl_qspi0>;\n" "> +\tstatus = \"okay\";\n" "> +\n" - "> +\tflash0: n25q128a13 at 0 {\n" + "> +\tflash0: n25q128a13@0 {\n" "\n" "Node name should be generic and label name should be specific.\n" "\n" - "\tn25q128a13_0: flash at 0\n" + "\tn25q128a13_0: flash@0\n" "\n" "> +\t\tcompatible = \"n25q128a13\", \"jedec,spi-nor\";\n" "> +\t\t#address-cells = <1>;\n" @@ -296,9 +306,9 @@ "> +\t\treg = <0>;\n" "> +\t};\n" "> +\n" - "> +\tflash1: n25q128a13 at 1 {\n" + "> +\tflash1: n25q128a13@1 {\n" "\n" - "\tn25q128a13_1: flash at 1\n" + "\tn25q128a13_1: flash@1\n" "\n" "> +\t\tcompatible = \"n25q128a13\", \"jedec,spi-nor\";\n" "> +\t\t#address-cells = <1>;\n" @@ -588,4 +598,4 @@ "> 2.11.0\n" > -3f0cf8f575488e6039df6229770939b4e181206c5de75a31a8e48dea62c4afc1 +86cabb7b47799dac2e0415387646676fef328a613bbb977b15545bb0d59a81ae
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.