All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
	Tzvetomir Stoyanov <tstoyanov@vmware.com>,
	Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] tools/lib/traceevent, tools/perf: Move struct tep_handler definition in a local header file
Date: Mon, 8 Oct 2018 14:32:24 -0300	[thread overview]
Message-ID: <20181008173224.GP3541@kernel.org> (raw)
In-Reply-To: <20181005122846.4b974dbd@gandalf.local.home>

Em Fri, Oct 05, 2018 at 12:28:46PM -0400, Steven Rostedt escreveu:
> On Fri, 5 Oct 2018 12:22:25 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > +/**
> > + * tep_get_first_event - returns the first event in the events array
> > + * @tep: a handle to the tep_handle
> > + *
> > + * This returns pointer to the first element of the events array
> > + * If @tep is NULL, NULL is returned.
> > + */
> > +struct tep_event_format *tep_get_first_event(struct tep_handle *tep)
> > +{
> > +	if(tep && tep->events)
> > +		return tep->events[0];
> > +
> > +	return NULL;
> > +}
> > +
> 
> Hold off on pulling this in. This patch has some whitespace issues that
> need to be cleaned up.

Ah, that if( thing? ?I can fix it here, holler if there is more than
that.

  reply	other threads:[~2018-10-09  0:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 16:22 [PATCH] tools/lib/traceevent, tools/perf: Move struct tep_handler definition in a local header file Steven Rostedt
2018-10-05 16:28 ` Steven Rostedt
2018-10-08 17:32   ` Arnaldo Carvalho de Melo [this message]
2018-10-08 19:54     ` Steven Rostedt
2018-10-08 19:54       ` Steven Rostedt
2018-10-08 17:31 ` Arnaldo Carvalho de Melo
2018-10-09  5:33 ` [tip:perf/core] tools lib traceevent, perf tools: " tip-bot for Tzvetomir Stoyanov
2019-07-26  3:58 ` [PATCH] tools/lib/traceevent, tools/perf: " Andres Freund
2019-07-26  8:25   ` Tzvetomir Stoyanov
2019-07-26 13:12   ` Steven Rostedt
2019-07-26 20:55     ` Andres Freund
2019-07-26 21:00       ` Steven Rostedt
2019-08-01 14:09       ` Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2018-08-13 15:06 Tzvetomir Stoyanov (VMware)
2018-10-03  0:05 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181008173224.GP3541@kernel.org \
    --to=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tstoyanov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.