From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhenyu Wang Subject: Re: [RFC 01/10] drm/i915/gvt: add module parameter enable_pvmmio Date: Tue, 9 Oct 2018 10:26:04 +0800 Message-ID: <20181009022604.GC14570@zhen-hp.sh.intel.com> References: <1538066275-52932-1-git-send-email-xiaolin.zhang@intel.com> <1538066275-52932-2-git-send-email-xiaolin.zhang@intel.com> <153804617343.12651.4159948067110231534@jlahtine-desk.ger.corp.intel.com> <073732E20AE4C540AE91DBC3F07D44607C17933C@SHSMSX101.ccr.corp.intel.com> Reply-To: Zhenyu Wang Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1223372646==" Return-path: In-Reply-To: <073732E20AE4C540AE91DBC3F07D44607C17933C@SHSMSX101.ccr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Zhang, Xiaolin" Cc: "intel-gfx@lists.freedesktop.org" , "Yuan, Hang" , "Lahtinen, Joonas" , "Jiang, Fei" , "intel-gvt-dev@lists.freedesktop.org" , "Lv, Zhiyuan" List-Id: intel-gfx@lists.freedesktop.org --===============1223372646== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+nBD6E3TurpgldQp" Content-Disposition: inline --+nBD6E3TurpgldQp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2018.09.28 14:09:45 +0800, Zhang, Xiaolin wrote: > On 09/27/2018 07:03 PM, Joonas Lahtinen wrote: > > Quoting Xiaolin Zhang (2018-09-27 19:37:46) > >> This int type module parameter is used to control the different > >> level pvmmio feature for MMIO emulation in GVT. > >> > >> This parameter is default zero, no pvmmio feature enabled. > >> > >> Its permission type is 0400 which means user could only change its > >> value through the cmdline, this is to prevent the dynamic modification > >> during runtime which would break the pvmmio internal logic. > >> > >> Signed-off-by: Xiaolin Zhang > > This shouldn't really be a module parameter. We should detect the > > capability from the vGPU device and use it always when possible. > > > > Regards, Joonas > > > for pv optimization, we should touch both guest driver and GVTg. this > parameter is used for >=20 > guest pv capability because GVTg with pv capability will support both pv > and non pv capability guest. >=20 That's the purpose of 'vgt_caps' in PVINFO to do capability check between host/guest. You need a new cap bit definition for PVMMIO and maybe another field for different PVMMIO level capability check. New parameter is not use= ful here. Thanks --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --+nBD6E3TurpgldQp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCW7wRvAAKCRCxBBozTXgY J1AmAKCVvzefs8xOX9+Lg1Bw5HHdiNx6iACggBr2AhsFQjUYlNTHmxERx/cDweQ= =MbFl -----END PGP SIGNATURE----- --+nBD6E3TurpgldQp-- --===============1223372646== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1223372646==--