From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 1/4] drm/i915/dp: Link train Fallback on eDP only if fallback link BW can fit panel's native mode Date: Tue, 9 Oct 2018 16:00:22 +0300 Message-ID: <20181009130022.GF9144@intel.com> References: <20180912225719.17574-1-manasi.d.navare@intel.com> <20181001160352.GK9144@intel.com> <20181008192331.GA15898@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id D54D86E31E for ; Tue, 9 Oct 2018 13:00:42 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181008192331.GA15898@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMDgsIDIwMTggYXQgMTI6MjM6MzJQTSAtMDcwMCwgTWFuYXNpIE5hdmFyZSB3 cm90ZToKPiBPbiBNb24sIE9jdCAwMSwgMjAxOCBhdCAwNzowMzo1MlBNICswMzAwLCBWaWxsZSBT eXJqw6Rsw6Qgd3JvdGU6Cj4gPiBPbiBXZWQsIFNlcCAxMiwgMjAxOCBhdCAwMzo1NzoxNlBNIC0w NzAwLCBNYW5hc2kgTmF2YXJlIHdyb3RlOgo+ID4gPiBUaGlzIHBhdGNoIGZpeGVzIHRoZSBvcmln aW5hbCBjb21taXQgYzBjZmIxMGQ5ZTFkZTQ5ICgiZHJtL2k5MTUvZWRwOgo+ID4gPiBEbyBub3Qg ZG8gbGluayB0cmFpbmluZyBmYWxsYmFjayBvciBwcnVuZSBtb2RlcyBvbiBFRFAiKSB0aGF0IGNh dXNlcwo+ID4gPiBhIGJsYW5rIHNjcmVlbiBpbiBjYXNlIG9mIGNlcnRhaW4gZURQIHBhbmVscyAo RWc6IHNlZW4gb24gRGVsbCBYUFMxMyA5MzUwKQo+ID4gPiB3aGVyZSBmaXJzdCBsaW5rIHRyYWlu aW5nIGZhaWxzIGFuZCBhIHJldHJhaW5pbmcgaXMgcmVxdWlyZWQgYnkgZmFsbGluZwo+ID4gPiBi YWNrIHRvIGxvd2VyIGxpbmsgcmF0ZS9sYW5lIGNvdW50Lgo+ID4gPiBJbiBjYXNlIG9mIHNvbWUg cGFuZWxzIHRoZXkgYWR2ZXJ0aXNlIGhpZ2hlciBsaW5rIHJhdGUvbGFuZSBjb3VudAo+ID4gPiB0 aGFuIHdoYXRzIHJlcXVpcmVkIGZvciBzdXBwb3J0aW5nIHRoZSBwYW5lbCdzIG5hdGl2ZSBtb2Rl Lgo+ID4gPiBCdXQgd2UgYWx3YXlzIGxpbmsgdHJhaW4gYXQgaGlnaGVzdCBsaW5rIHJhdGUvbGFu ZSBjb3VudCBmb3IgZURQCj4gPiA+IGFuZCBpZiB0aGF0IGZhaWxzIHdlIGNhbiBzdGlsbCBmYWxs YmFjayB0byBsb3dlciBsaW5rIHJhdGUvbGFuZSBjb3VudAo+ID4gPiBhcyBsb25nIGFzIHRoZSBm YWxsYmFjayBsaW5rIEJXIHN0aWxsIGZpdHMgdGhlIG5hdGl2ZSBtb2RlIHRvIGF2b2lkCj4gPiA+ IHBydW5pbmcgdGhlIHBhbmVsJ3MgbmF0aXZlIG1vZGUgeWV0IHJldHJhaW5pbmcgYXQgZmFsbGJh Y2sgdmFsdWVzCj4gPiA+IHRvIHJlY292ZXIgZnJvbSBhIGJsYW5rIHNjcmVlbi4KPiA+ID4gCj4g PiA+IHYyOgo+ID4gPiAqIFNlbmQgdWV2ZW50IGlmIGxpbmsgZmFpbHVyZSBvbiBlRFAgdW5jb25k aXRpb25hbGx5Cj4gPiA+IAo+ID4gPiBDYzogQ2xpbnRvbiBUYXlsb3IgPGNsaW50b24uYS50YXls b3JAaW50ZWwuY29tPgo+ID4gPiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4Lmlu dGVsLmNvbT4KPiA+ID4gQ2M6IFZpbGxlIFN5cmphbGEgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgo+ID4gPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4K PiA+ID4gQ2M6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVtYXJjaGlAaW50ZWwuY29tPgo+ID4g PiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA3NDg5Cj4gPiA+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3df YnVnLmNnaT9pZD0xMDUzMzgKPiA+ID4gU2lnbmVkLW9mZi1ieTogTWFuYXNpIE5hdmFyZSA8bWFu YXNpLmQubmF2YXJlQGludGVsLmNvbT4KPiA+ID4gVGVzdGVkLWJ5OiBBbGV4YW5kZXIgV2lsc29u IDxhbGV4YW5kZXIud2lsc29uQG5jZi5lZHU+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHAuYyAgICAgICAgICAgICAgIHwgMjkgKysrKysrKysrKysrKysrKysr Kwo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5jIHwg MjYgKysrKysrLS0tLS0tLS0tLS0KPiA+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMzggaW5zZXJ0aW9u cygrKSwgMTcgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMK PiA+ID4gaW5kZXggNDM2YzIyZGUzM2I2Li5lNGRlNTI1N2NkODcgMTAwNjQ0Cj4gPiA+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gPiBAQCAtNTU3LDYgKzU1NywyMSBAQCBzdGF0aWMgYm9v bCBpbnRlbF9kcF9saW5rX3BhcmFtc192YWxpZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCBp bnQgbGlua19yYXRlLAo+ID4gPiAgCXJldHVybiB0cnVlOwo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+ ICtzdGF0aWMgYm9vbCBpbnRlbF9kcF9jYW5fbGlua190cmFpbl9mYWxsYmFja19mb3JfZWRwKHN0 cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gPiA+ICsJCQkJCQkgICAgIGludCBsaW5rX3JhdGUs Cj4gPiA+ICsJCQkJCQkgICAgIHVpbnQ4X3QgbGFuZV9jb3VudCkKPiA+ID4gK3sKPiA+ID4gKwlz dHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqZml4ZWRfbW9kZSA9IGludGVsX2RwLT5hdHRhY2hlZF9j b25uZWN0b3ItPnBhbmVsLmZpeGVkX21vZGU7Cj4gPiAKPiA+IGNvbnN0Cj4gPgo+IAo+IFdpbGwg YWRkIGNvbnN0IHRvIHRoZSBmaXhlZF9tb2RlLgo+ICAKPiA+ID4gKwlpbnQgbW9kZV9yYXRlLCBt YXhfcmF0ZTsKPiA+ID4gKwo+ID4gPiArCW1vZGVfcmF0ZSA9IGludGVsX2RwX2xpbmtfcmVxdWly ZWQoZml4ZWRfbW9kZS0+Y2xvY2ssIDE4KTsKPiA+ID4gKwltYXhfcmF0ZSA9IGludGVsX2RwX21h eF9kYXRhX3JhdGUobGlua19yYXRlLCBsYW5lX2NvdW50KTsKPiA+ID4gKwlpZiAobW9kZV9yYXRl ID4gbWF4X3JhdGUpCj4gPiA+ICsJCXJldHVybiBmYWxzZTsKPiA+IAo+ID4gSSB3b25kZXIgaWYg d2Ugc2hvdWxkIGV4dHJhY3QgdGhpcyBpbnRvIGEgaGVscGVyIGFuZCBzaGFyZSB3aXRoCj4gPiBt b2RlX3ZhbGlkKCkuIFRoZW4gYWdhaW4sIGl0J3MganVzdCBhIGZldyBsaW5lcyBzbyBtYXliZSBu b3Qgd29ydGggaXQuCj4gPiAKPiA+ID4gKwo+ID4gPiArCXJldHVybiB0cnVlOwo+ID4gPiArfQo+ ID4gPiArCj4gPiA+ICBpbnQgaW50ZWxfZHBfZ2V0X2xpbmtfdHJhaW5fZmFsbGJhY2tfdmFsdWVz KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gPiA+ICAJCQkJCSAgICBpbnQgbGlua19yYXRl LCB1aW50OF90IGxhbmVfY291bnQpCj4gPiA+ICB7Cj4gPiA+IEBAIC01NjYsOSArNTgxLDIzIEBA IGludCBpbnRlbF9kcF9nZXRfbGlua190cmFpbl9mYWxsYmFja192YWx1ZXMoc3RydWN0IGludGVs X2RwICppbnRlbF9kcCwKPiA+ID4gIAkJCQkgICAgaW50ZWxfZHAtPm51bV9jb21tb25fcmF0ZXMs Cj4gPiA+ICAJCQkJICAgIGxpbmtfcmF0ZSk7Cj4gPiA+ICAJaWYgKGluZGV4ID4gMCkgewo+ID4g PiArCQlpZiAoaW50ZWxfZHBfaXNfZWRwKGludGVsX2RwKSAmJgo+ID4gPiArCQkgICAgIWludGVs X2RwX2Nhbl9saW5rX3RyYWluX2ZhbGxiYWNrX2Zvcl9lZHAoaW50ZWxfZHAsCj4gPiA+ICsJCQkJ CQkJICAgICAgaW50ZWxfZHAtPmNvbW1vbl9yYXRlc1tpbmRleCAtIDFdLAo+ID4gPiArCQkJCQkJ CSAgICAgIGxhbmVfY291bnQpKSB7Cj4gPiA+ICsJCQlEUk1fREVCVUdfS01TKCJSZXRyeWluZyBM aW5rIHRyYWluaW5nIGZvciBlRFAgd2l0aCBzYW1lIHBhcmFtZXRlcnNcbiIpOwo+ID4gPiArCQkJ cmV0dXJuIDA7Cj4gPiA+ICsJCX0KPiA+ID4gIAkJaW50ZWxfZHAtPm1heF9saW5rX3JhdGUgPSBp bnRlbF9kcC0+Y29tbW9uX3JhdGVzW2luZGV4IC0gMV07Cj4gPiA+ICAJCWludGVsX2RwLT5tYXhf bGlua19sYW5lX2NvdW50ID0gbGFuZV9jb3VudDsKPiA+ID4gIAl9IGVsc2UgaWYgKGxhbmVfY291 bnQgPiAxKSB7Cj4gPiA+ICsJCWlmIChpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHApICYmCj4gPiA+ ICsJCSAgICAhaW50ZWxfZHBfY2FuX2xpbmtfdHJhaW5fZmFsbGJhY2tfZm9yX2VkcChpbnRlbF9k cCwKPiA+ID4gKwkJCQkJCQkgICAgICBpbnRlbF9kcF9tYXhfY29tbW9uX3JhdGUoaW50ZWxfZHAp LAo+ID4gPiArCQkJCQkJCSAgICAgIGxhbmVfY291bnQgPj4gMSkpIHsKPiA+ID4gKwkJCURSTV9E RUJVR19LTVMoIlJldHJ5aW5nIExpbmsgdHJhaW5pbmcgZm9yIGVEUCB3aXRoIHNhbWUgcGFyYW1l dGVyc1xuIik7Cj4gPiA+ICsJCQlyZXR1cm4gMDsKPiA+ID4gKwkJfQo+ID4gPiAgCQlpbnRlbF9k cC0+bWF4X2xpbmtfcmF0ZSA9IGludGVsX2RwX21heF9jb21tb25fcmF0ZShpbnRlbF9kcCk7Cj4g PiA+ICAJCWludGVsX2RwLT5tYXhfbGlua19sYW5lX2NvdW50ID0gbGFuZV9jb3VudCA+PiAxOwo+ ID4gCj4gPiBUaGlzIHdob2xlIHRoaW5nIGlzIGdldHRpbmcgYSBiaXQgbWVzc3kuIEkgdGhpbmsg aXQgd291bGQgd29ydGh3aWxlIHRvCj4gPiByZXdyaXRlIHRoaXMgYXMgc29tZXRoaW5nIGxpa2U6 Cj4gPiAKPiA+IGludGVsX2RwX3VwZGF0ZV9saW5rX3RyYWluX2ZhbGxiYWNrX3ZhbHVlcyhpbnRl bF9kcCkKPiA+IHsKPiA+IAlpbnQgbGlua19yYXRlID0gaW50ZWxfZHAtPmxpbmtfcmF0ZTsKPiA+ IAlpbnQgbGFuZV9jb3VudCA9IGludGVsX2RwLT5sYW5lX2NvdW50Owo+ID4gCj4gPiAJaWYgKGlu dGVsX2RwX2dldF9saW5rX3RyYWluX2ZhbGxiYWNrX3ZhbHVlcyhpbnRlbF9kcCwgJmxpbmtfcmF0 ZSwgJmxhbmVfY291bnQpKQo+ID4gCQlyZXR1cm4gLTE7Cj4gPiAKPiA+IAlpZiAoaXNfZWRwKCkg JiYgIWVkcF9jYW5fbGlua190cmFpbl90aGluZyhsaW5rX3JhdGUsIGxhbmVfY291bnQpKSB7Cj4g PiAJCURSTV9ERUJVR19LTVMoIi4uLiIpOwo+ID4gCQlyZXR1cm4gMDsKPiA+IAl9Cj4gPiAKPiA+ IAlpbnRlbF9kcC0+bWF4X2xpbmtfcmF0ZSA9IGxpbmtfcmF0ZTsKPiA+IAlpbnRlbF9kcC0+bWF4 X2xpbmtfbGFuZV9jb3VudCA9IGxhbmVfY291bnQ7Cj4gPiAKPiA+IAlyZXR1cm4gMDsKPiA+IH0K PiA+IAo+ID4gQnV0IHRoYXQgY2FuIGJlIGRvbmUgbGF0ZXIuIFdpdGggdGhlIG1pc3NpbmcgY29u c3QgYWRkZWQgdGhpcyBwYXRjaCBpcwo+ID4gUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPgo+IAo+IFllcyB0aGlzIGNhbiBiZSBy ZWZhY3RvcmVkL3Jlb3JnYW5pemVkIGFzIGEgZm9sbG93IHVwIHBhdGNoLCBhbHNvIHdoZW4gZG93 bmNsb2NrIG1vZGUKPiBjaGVja3MgZ2V0IGluLgo+IFNvIHVudGlsIHRoZW4gdGhzaSBmaXggaXMg Z29vZCB0byBiZSBtZXJnZWQgcmlnaHQ/CgpZZXMuCgo+IAo+IE1hbmFzaQo+ICAKPiA+ID4gIAl9 IGVsc2Ugewo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBf bGlua190cmFpbmluZy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFp bmluZy5jCj4gPiA+IGluZGV4IGE5ZjQwOTg1YTYyMS4uMzBiZTBlMzliZDVmIDEwMDY0NAo+ID4g PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9saW5rX3RyYWluaW5nLmMKPiA+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBfbGlua190cmFpbmluZy5jCj4g PiA+IEBAIC0zNjcsMjIgKzM2NywxNCBAQCBpbnRlbF9kcF9zdGFydF9saW5rX3RyYWluKHN0cnVj dCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gPiA+ICAJcmV0dXJuOwo+ID4gPiAgCj4gPiA+ICAgZmFp bHVyZV9oYW5kbGluZzoKPiA+ID4gLQkvKiBEb250IGZhbGxiYWNrIGFuZCBwcnVuZSBtb2RlcyBp ZiBpdHMgZURQICovCj4gPiA+IC0JaWYgKCFpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHApKSB7Cj4g PiA+IC0JCURSTV9ERUJVR19LTVMoIltDT05ORUNUT1I6JWQ6JXNdIExpbmsgVHJhaW5pbmcgZmFp bGVkIGF0IGxpbmsgcmF0ZSA9ICVkLCBsYW5lIGNvdW50ID0gJWQiLAo+ID4gPiAtCQkJICAgICAg aW50ZWxfY29ubmVjdG9yLT5iYXNlLmJhc2UuaWQsCj4gPiA+IC0JCQkgICAgICBpbnRlbF9jb25u ZWN0b3ItPmJhc2UubmFtZSwKPiA+ID4gLQkJCSAgICAgIGludGVsX2RwLT5saW5rX3JhdGUsIGlu dGVsX2RwLT5sYW5lX2NvdW50KTsKPiA+ID4gLQkJaWYgKCFpbnRlbF9kcF9nZXRfbGlua190cmFp bl9mYWxsYmFja192YWx1ZXMoaW50ZWxfZHAsCj4gPiA+IC0JCQkJCQkJICAgICBpbnRlbF9kcC0+ bGlua19yYXRlLAo+ID4gPiAtCQkJCQkJCSAgICAgaW50ZWxfZHAtPmxhbmVfY291bnQpKQo+ID4g PiAtCQkJLyogU2NoZWR1bGUgYSBIb3RwbHVnIFVldmVudCB0byB1c2Vyc3BhY2UgdG8gc3RhcnQg bW9kZXNldCAqLwo+ID4gPiAtCQkJc2NoZWR1bGVfd29yaygmaW50ZWxfY29ubmVjdG9yLT5tb2Rl c2V0X3JldHJ5X3dvcmspOwo+ID4gPiAtCX0gZWxzZSB7Cj4gPiA+IC0JCURSTV9FUlJPUigiW0NP Tk5FQ1RPUjolZDolc10gTGluayBUcmFpbmluZyBmYWlsZWQgYXQgbGluayByYXRlID0gJWQsIGxh bmUgY291bnQgPSAlZCIsCj4gPiA+IC0JCQkgIGludGVsX2Nvbm5lY3Rvci0+YmFzZS5iYXNlLmlk LAo+ID4gPiAtCQkJICBpbnRlbF9jb25uZWN0b3ItPmJhc2UubmFtZSwKPiA+ID4gLQkJCSAgaW50 ZWxfZHAtPmxpbmtfcmF0ZSwgaW50ZWxfZHAtPmxhbmVfY291bnQpOwo+ID4gPiAtCX0KPiA+ID4g KwlEUk1fREVCVUdfS01TKCJbQ09OTkVDVE9SOiVkOiVzXSBMaW5rIFRyYWluaW5nIGZhaWxlZCBh dCBsaW5rIHJhdGUgPSAlZCwgbGFuZSBjb3VudCA9ICVkIiwKPiA+ID4gKwkJICAgICAgaW50ZWxf Y29ubmVjdG9yLT5iYXNlLmJhc2UuaWQsCj4gPiA+ICsJCSAgICAgIGludGVsX2Nvbm5lY3Rvci0+ YmFzZS5uYW1lLAo+ID4gPiArCQkgICAgICBpbnRlbF9kcC0+bGlua19yYXRlLCBpbnRlbF9kcC0+ bGFuZV9jb3VudCk7Cj4gPiA+ICsJaWYgKCFpbnRlbF9kcF9nZXRfbGlua190cmFpbl9mYWxsYmFj a192YWx1ZXMoaW50ZWxfZHAsCj4gPiA+ICsJCQkJCQkgICAgIGludGVsX2RwLT5saW5rX3JhdGUs Cj4gPiA+ICsJCQkJCQkgICAgIGludGVsX2RwLT5sYW5lX2NvdW50KSkKPiA+ID4gKwkJLyogU2No ZWR1bGUgYSBIb3RwbHVnIFVldmVudCB0byB1c2Vyc3BhY2UgdG8gc3RhcnQgbW9kZXNldCAqLwo+ ID4gPiArCQlzY2hlZHVsZV93b3JrKCZpbnRlbF9jb25uZWN0b3ItPm1vZGVzZXRfcmV0cnlfd29y ayk7Cj4gPiA+ICAJcmV0dXJuOwo+ID4gPiAgfQo+ID4gPiAtLSAKPiA+ID4gMi4xOC4wCj4gPiAK PiA+IC0tIAo+ID4gVmlsbGUgU3lyasOkbMOkCj4gPiBJbnRlbAoKLS0gClZpbGxlIFN5cmrDpGzD pApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK