From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/fsetxattr02.c: Fix missing ramdisk module error
Date: Tue, 9 Oct 2018 16:17:25 +0200 [thread overview]
Message-ID: <20181009141725.GD16630@rei> (raw)
In-Reply-To: <20181008154620.25237-1-rafael.tinoco@linaro.org>
Hi!
> +#define DRVRAMDISK "brd"
I find it a bit silly to define a macro for a string that is used
exactly once. Why can't we just write "brd", in the needed_drivers?
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-10-09 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 10:09 [LTP] LTP master: arm64 : fsetxattr02.c:214: open(mntpoint/fsetxattr02blk, 0, 00) failed: ENXIO Naresh Kamboju
2018-09-16 19:46 ` Rafael Tinoco
2018-09-17 8:44 ` Cyril Hrubis
2018-09-17 15:37 ` Rafael David Tinoco
2018-10-08 15:46 ` [LTP] [PATCH] syscalls/fsetxattr02.c: Fix missing ramdisk module error Rafael David Tinoco
2018-10-09 14:17 ` Cyril Hrubis [this message]
2018-10-09 14:25 ` Rafael David Tinoco
2018-10-09 14:26 ` Cyril Hrubis
2018-10-19 13:06 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009141725.GD16630@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.