From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Subject: [net-next,07/19] net: usb: aqc111: Add support for getting and setting of MAC address
From: Andrew Lunn <andrew@lunn.ch>
Message-Id: <20181009144623.GW4730@lunn.ch>
Date: Tue, 9 Oct 2018 16:46:23 +0200
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc: "David S . Miller" <davem@davemloft.net>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
List-ID: <linux-usb.vger.kernel.org>

T24gVHVlLCBPY3QgMDksIDIwMTggYXQgMDI6MzQ6MzZQTSArMDAwMCwgSWdvciBSdXNza2lraCB3
cm90ZToKPiBIaSBBbmRyZXcsCj4gCj4gPj4gKwlpZiAocmV0IDwgMCkKPiA+PiArCQlnb3RvIG91
dDsKPiA+PiArCj4gPj4gKwltZW1jcHkoZGV2LT5uZXQtPmRldl9hZGRyLCBidWYsIEVUSF9BTEVO
KTsKPiA+PiArCW1lbWNweShkZXYtPm5ldC0+cGVybV9hZGRyLCBkZXYtPm5ldC0+ZGV2X2FkZHIs
IEVUSF9BTEVOKTsKPiA+IAo+ID4gSXMgdGhpcyByZWFsbHkgdGhlIHBlcm1hbmVudCBhZGRyZXNz
PyBJZiBpIGNhbGwgYXFjMTExX3NldF9tYWNfYWRkcigpCj4gPiBmb2xsb3dlZCBieSBhcWMxMTFf
Z2V0X21hYygpIGkgc3RpbGwgZ2V0IHdoYXQgaXMgaW4gdGhlIE9UUCBFRVBST00/Cj4gCj4gVGhh
dHMgYWN0dWFsbHkgYSBjb25mdXNpb24gd2l0aCBmdW5jdGlvbiBuYW1lIGhlcmUuCj4gVGhpbmsg
aXRzIGJldHRlciB0byBuYW1lIGl0IGFxYzExMV9pbml0X21hYygpIHNpbmNlIGl0IGdldHMgY2Fs
bGVkCj4gb25seSBvbmNlIG9uIGJpbmQuCgpIaSBJZ29yCgpPciBhcWMxMTFfZ2V0X290cF9tYWMo
KT8KCiAgIEFuZHJldwo=

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 07/19] net: usb: aqc111: Add support for getting
 and setting of MAC address
Date: Tue, 9 Oct 2018 16:46:23 +0200
Message-ID: <20181009144623.GW4730@lunn.ch>
References: <cover.1538734658.git.igor.russkikh@aquantia.com>
 <9ab691fa129ceb7a8947fde6f307fbd855d085cf.1538734658.git.igor.russkikh@aquantia.com>
 <20181006010346.GA32455@lunn.ch>
 <082aefef-5927-181e-e505-685c1ca51492@aquantia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "David S . Miller" <davem@davemloft.net>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:58274 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726563AbeJIWDo (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 9 Oct 2018 18:03:44 -0400
Content-Disposition: inline
In-Reply-To: <082aefef-5927-181e-e505-685c1ca51492@aquantia.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Oct 09, 2018 at 02:34:36PM +0000, Igor Russkikh wrote:
> Hi Andrew,
> 
> >> +	if (ret < 0)
> >> +		goto out;
> >> +
> >> +	memcpy(dev->net->dev_addr, buf, ETH_ALEN);
> >> +	memcpy(dev->net->perm_addr, dev->net->dev_addr, ETH_ALEN);
> > 
> > Is this really the permanent address? If i call aqc111_set_mac_addr()
> > followed by aqc111_get_mac() i still get what is in the OTP EEPROM?
> 
> Thats actually a confusion with function name here.
> Think its better to name it aqc111_init_mac() since it gets called
> only once on bind.

Hi Igor

Or aqc111_get_otp_mac()?

   Andrew