From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 3/4] drm/v3d: Add some better documentation of the in_sync arguments. Date: Tue, 9 Oct 2018 15:27:07 +0200 Message-ID: <20181009152707.4220a7d5@bbrezillon> References: <20180928232126.4332-1-eric@anholt.net> <20180928232126.4332-3-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id CEC636E332 for ; Tue, 9 Oct 2018 13:27:08 +0000 (UTC) In-Reply-To: <20180928232126.4332-3-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyOCBTZXAgMjAxOCAxNjoyMToyNSAtMDcwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PiB3cm90ZToKCj4gU2luY2UgdGhpcyBpcyBVQVBJLCBpdCdzIGdvb2QgdG8gZG9jdW1l bnQgd2hhdCBleGFjdGx5IHRoZSBndWFyYW50ZWVzCj4gd2UncmUgcHJvdmlkaW5nIGFyZS4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBFcmljIEFuaG9sdCA8ZXJpY0BhbmhvbHQubmV0PgoKUmV2aWV3ZWQt Ynk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29tPgoKPiAtLS0K PiAgaW5jbHVkZS91YXBpL2RybS92M2RfZHJtLmggfCAxMCArKysrKysrKysrCj4gIDEgZmlsZSBj aGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvdWFwaS9k cm0vdjNkX2RybS5oIGIvaW5jbHVkZS91YXBpL2RybS92M2RfZHJtLmgKPiBpbmRleCA3YjY2Mjc3 ODM2MDguLmY0NDY2NTZkMDBiMSAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL3VhcGkvZHJtL3YzZF9k cm0uaAo+ICsrKyBiL2luY2x1ZGUvdWFwaS9kcm0vdjNkX2RybS5oCj4gQEAgLTU4LDYgKzU4LDEx IEBAIHN0cnVjdCBkcm1fdjNkX3N1Ym1pdF9jbCB7Cj4gIAkgKiBjb29yZGluYXRlIHNoYWRlciB0 byBkZXRlcm1pbmUgd2hlcmUgcHJpbWl0aXZlcyBsYW5kIG9uIHRoZSBzY3JlZW4sCj4gIAkgKiB0 aGVuIHdyaXRlcyBvdXQgdGhlIHN0YXRlIHVwZGF0ZXMgYW5kIGRyYXcgY2FsbHMgbmVjZXNzYXJ5 IHBlciB0aWxlCj4gIAkgKiB0byB0aGUgdGlsZSBhbGxvY2F0aW9uIEJPLgo+ICsJICoKPiArCSAq IFRoaXMgQkNMIHdpbGwgYmxvY2sgb24gYW55IHByZXZpb3VzIEJDTCBzdWJtaXR0ZWQgb24gdGhl Cj4gKwkgKiBzYW1lIEZELCBidXQgbm90IG9uIGFueSBSQ0wgb3IgQkNMcyBzdWJtaXR0ZWQgYnkg b3RoZXIKPiArCSAqIGNsaWVudHMgLS0gdGhhdCBpcyBsZWZ0IHVwIHRvIHRoZSBzdWJtaXR0ZXIg dG8gY29udHJvbAo+ICsJICogdXNpbmcgaW5fc3luY19iY2wgaWYgbmVjZXNzYXJ5Lgo+ICAJICov Cj4gIAlfX3UzMiBiY2xfc3RhcnQ7Cj4gIAo+IEBAIC02OSw2ICs3NCwxMSBAQCBzdHJ1Y3QgZHJt X3YzZF9zdWJtaXRfY2wgewo+ICAJICogVGhpcyBpcyB0aGUgc2Vjb25kIHNldCBvZiBjb21tYW5k cyBleGVjdXRlZCwgd2hpY2ggd2lsbCBlaXRoZXIKPiAgCSAqIGV4ZWN1dGUgdGhlIHRpbGVzIHRo YXQgaGF2ZSBiZWVuIHNldCB1cCBieSB0aGUgQkNMLCBvciBhIGZpeGVkIHNldAo+ICAJICogb2Yg dGlsZXMgKGluIHRoZSBjYXNlIG9mIFJDTC1vbmx5IGJsaXRzKS4KPiArCSAqCj4gKwkgKiBUaGlz IFJDTCB3aWxsIGJsb2NrIG9uIHRoaXMgc3VibWl0J3MgQkNMLCBhbmQgYW55IHByZXZpb3VzCj4g KwkgKiBSQ0wgc3VibWl0dGVkIG9uIHRoZSBzYW1lIEZELCBidXQgbm90IG9uIGFueSBSQ0wgb3Ig QkNMcwo+ICsJICogc3VibWl0dGVkIGJ5IG90aGVyIGNsaWVudHMgLS0gdGhhdCBpcyBsZWZ0IHVw IHRvIHRoZQo+ICsJICogc3VibWl0dGVyIHRvIGNvbnRyb2wgdXNpbmcgaW5fc3luY19yY2wgaWYg bmVjZXNzYXJ5Lgo+ICAJICovCj4gIAlfX3UzMiByY2xfc3RhcnQ7Cj4gIAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C298FC64EB8 for ; Tue, 9 Oct 2018 13:27:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FE1C2087D for ; Tue, 9 Oct 2018 13:27:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FE1C2087D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728083AbeJIUoF (ORCPT ); Tue, 9 Oct 2018 16:44:05 -0400 Received: from mail.bootlin.com ([62.4.15.54]:51045 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726656AbeJIUoF (ORCPT ); Tue, 9 Oct 2018 16:44:05 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 0ACBE207C3; Tue, 9 Oct 2018 15:27:07 +0200 (CEST) Received: from bbrezillon (AAubervilliers-681-1-28-153.w90-88.abo.wanadoo.fr [90.88.148.153]) by mail.bootlin.com (Postfix) with ESMTPSA id CB43720712; Tue, 9 Oct 2018 15:27:06 +0200 (CEST) Date: Tue, 9 Oct 2018 15:27:07 +0200 From: Boris Brezillon To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] drm/v3d: Add some better documentation of the in_sync arguments. Message-ID: <20181009152707.4220a7d5@bbrezillon> In-Reply-To: <20180928232126.4332-3-eric@anholt.net> References: <20180928232126.4332-1-eric@anholt.net> <20180928232126.4332-3-eric@anholt.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Sep 2018 16:21:25 -0700 Eric Anholt wrote: > Since this is UAPI, it's good to document what exactly the guarantees > we're providing are. > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > include/uapi/drm/v3d_drm.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/uapi/drm/v3d_drm.h b/include/uapi/drm/v3d_drm.h > index 7b6627783608..f446656d00b1 100644 > --- a/include/uapi/drm/v3d_drm.h > +++ b/include/uapi/drm/v3d_drm.h > @@ -58,6 +58,11 @@ struct drm_v3d_submit_cl { > * coordinate shader to determine where primitives land on the screen, > * then writes out the state updates and draw calls necessary per tile > * to the tile allocation BO. > + * > + * This BCL will block on any previous BCL submitted on the > + * same FD, but not on any RCL or BCLs submitted by other > + * clients -- that is left up to the submitter to control > + * using in_sync_bcl if necessary. > */ > __u32 bcl_start; > > @@ -69,6 +74,11 @@ struct drm_v3d_submit_cl { > * This is the second set of commands executed, which will either > * execute the tiles that have been set up by the BCL, or a fixed set > * of tiles (in the case of RCL-only blits). > + * > + * This RCL will block on this submit's BCL, and any previous > + * RCL submitted on the same FD, but not on any RCL or BCLs > + * submitted by other clients -- that is left up to the > + * submitter to control using in_sync_rcl if necessary. > */ > __u32 rcl_start; >