From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 4/4] drm/v3d: Skip debugfs dumping GCA on platforms without GCA. Date: Tue, 9 Oct 2018 15:30:18 +0200 Message-ID: <20181009153018.03867fea@bbrezillon> References: <20180928232126.4332-1-eric@anholt.net> <20180928232126.4332-4-eric@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CC7D892D4 for ; Tue, 9 Oct 2018 13:30:20 +0000 (UTC) In-Reply-To: <20180928232126.4332-4-eric@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyOCBTZXAgMjAxOCAxNjoyMToyNiAtMDcwMApFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PiB3cm90ZToKCj4gRml4ZXMgYW4gb29wcyByZWFkaW5nIHRoaXMgZGVidWdmcyBlbnRy eSBvbiBCQ003Mjc4Lgo+IAoKWW91IHByb2JhYmx5IHdhbnQgdG8gYWRkOgoKRml4ZXM6IDU3Njky Yzk0ZGNiZSAoImRybS92M2Q6IEludHJvZHVjZSBhIG5ldyBEUk0gZHJpdmVyIGZvciBCcm9hZGNv bSBWM0QgVjMueCsiKQpDYzogPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+Cgo+IFNpZ25lZC1vZmYt Ynk6IEVyaWMgQW5ob2x0IDxlcmljQGFuaG9sdC5uZXQ+CgpJbiBhbnkgY2FzZSwgdGhpcyBpcwoK UmV2aWV3ZWQtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29t PgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfZGVidWdmcy5jIHwgMTEgKysrKysr Ky0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfZGVidWdmcy5jIGIvZHJp dmVycy9ncHUvZHJtL3YzZC92M2RfZGVidWdmcy5jCj4gaW5kZXggZDQ4MDA4YWRiMDg1Li5lYjJi MmQyZjg1NTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfZGVidWdmcy5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3YzZC92M2RfZGVidWdmcy5jCj4gQEAgLTcxLDEwICs3 MSwxMyBAQCBzdGF0aWMgaW50IHYzZF92M2RfZGVidWdmc19yZWdzKHN0cnVjdCBzZXFfZmlsZSAq bSwgdm9pZCAqdW51c2VkKQo+ICAJCQkgICBWM0RfUkVBRCh2M2RfaHViX3JlZ19kZWZzW2ldLnJl ZykpOwo+ICAJfQo+ICAKPiAtCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKHYzZF9nY2FfcmVn X2RlZnMpOyBpKyspIHsKPiAtCQlzZXFfcHJpbnRmKG0sICIlcyAoMHglMDR4KTogMHglMDh4XG4i LAo+IC0JCQkgICB2M2RfZ2NhX3JlZ19kZWZzW2ldLm5hbWUsIHYzZF9nY2FfcmVnX2RlZnNbaV0u cmVnLAo+IC0JCQkgICBWM0RfR0NBX1JFQUQodjNkX2djYV9yZWdfZGVmc1tpXS5yZWcpKTsKPiAr CWlmICh2M2QtPnZlciA8IDQxKSB7Cj4gKwkJZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUodjNk X2djYV9yZWdfZGVmcyk7IGkrKykgewo+ICsJCQlzZXFfcHJpbnRmKG0sICIlcyAoMHglMDR4KTog MHglMDh4XG4iLAo+ICsJCQkJICAgdjNkX2djYV9yZWdfZGVmc1tpXS5uYW1lLAo+ICsJCQkJICAg djNkX2djYV9yZWdfZGVmc1tpXS5yZWcsCj4gKwkJCQkgICBWM0RfR0NBX1JFQUQodjNkX2djYV9y ZWdfZGVmc1tpXS5yZWcpKTsKPiArCQl9Cj4gIAl9Cj4gIAo+ICAJZm9yIChjb3JlID0gMDsgY29y ZSA8IHYzZC0+Y29yZXM7IGNvcmUrKykgewoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07113C64EB8 for ; Tue, 9 Oct 2018 13:30:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA0C52087D for ; Tue, 9 Oct 2018 13:30:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA0C52087D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727537AbeJIUrT (ORCPT ); Tue, 9 Oct 2018 16:47:19 -0400 Received: from mail.bootlin.com ([62.4.15.54]:51149 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbeJIUrS (ORCPT ); Tue, 9 Oct 2018 16:47:18 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 5924E207C3; Tue, 9 Oct 2018 15:30:18 +0200 (CEST) Received: from bbrezillon (AAubervilliers-681-1-28-153.w90-88.abo.wanadoo.fr [90.88.148.153]) by mail.bootlin.com (Postfix) with ESMTPSA id 261AE20712; Tue, 9 Oct 2018 15:30:18 +0200 (CEST) Date: Tue, 9 Oct 2018 15:30:18 +0200 From: Boris Brezillon To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] drm/v3d: Skip debugfs dumping GCA on platforms without GCA. Message-ID: <20181009153018.03867fea@bbrezillon> In-Reply-To: <20180928232126.4332-4-eric@anholt.net> References: <20180928232126.4332-1-eric@anholt.net> <20180928232126.4332-4-eric@anholt.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Sep 2018 16:21:26 -0700 Eric Anholt wrote: > Fixes an oops reading this debugfs entry on BCM7278. > You probably want to add: Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+") Cc: > Signed-off-by: Eric Anholt In any case, this is Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/v3d/v3d_debugfs.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/v3d/v3d_debugfs.c b/drivers/gpu/drm/v3d/v3d_debugfs.c > index d48008adb085..eb2b2d2f8553 100644 > --- a/drivers/gpu/drm/v3d/v3d_debugfs.c > +++ b/drivers/gpu/drm/v3d/v3d_debugfs.c > @@ -71,10 +71,13 @@ static int v3d_v3d_debugfs_regs(struct seq_file *m, void *unused) > V3D_READ(v3d_hub_reg_defs[i].reg)); > } > > - for (i = 0; i < ARRAY_SIZE(v3d_gca_reg_defs); i++) { > - seq_printf(m, "%s (0x%04x): 0x%08x\n", > - v3d_gca_reg_defs[i].name, v3d_gca_reg_defs[i].reg, > - V3D_GCA_READ(v3d_gca_reg_defs[i].reg)); > + if (v3d->ver < 41) { > + for (i = 0; i < ARRAY_SIZE(v3d_gca_reg_defs); i++) { > + seq_printf(m, "%s (0x%04x): 0x%08x\n", > + v3d_gca_reg_defs[i].name, > + v3d_gca_reg_defs[i].reg, > + V3D_GCA_READ(v3d_gca_reg_defs[i].reg)); > + } > } > > for (core = 0; core < v3d->cores; core++) {