From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Subject: Re: [PATCH] ethdev: add action to swap source and
 destination MAC to flow API
Date: Wed, 10 Oct 2018 00:04:30 +0530
Message-ID: <20181009183425.GA17233@chelsio.com>
References: <1537777765-16798-1-git-send-email-rahul.lakkireddy@chelsio.com>
 <0093e5e2-2187-ff9e-53f6-041af4074018@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>, Indranil Choudhury <indranil@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>,
 Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])
 by dpdk.org (Postfix) with ESMTP id C79431B57C
 for <dev@dpdk.org>; Tue,  9 Oct 2018 20:34:53 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <0093e5e2-2187-ff9e-53f6-041af4074018@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tuesday, October 10/09/18, 2018 at 20:19:54 +0530, Ferruh Yigit wrote:
> On 9/24/2018 9:29 AM, Rahul Lakkireddy wrote:
> > This action is useful for offloading loopback mode, where the hardware
> > will swap source and destination MAC addresses in the outermost Ethernet
> > header before looping back the packet. This action can be used in
> > conjunction with other rewrite actions to achieve MAC layer transparent
> > NAT where the MAC addresses are swapped before either the source or
> > destination MAC address is rewritten and NAT is performed.
> > 
> > Must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern item.
> > Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error should be returned by the
> > PMDs.
> > 
> > Original work by Shagun Agrawal
> 
> Do you consider adding his sign off too, that is more formal way we do?
> 
> If would like to update we can do it on the next-net before it get pulled.
> 

Shagun is no longer working for Chelsio. He had done the original
implementation and I've re-spun the series incorporating review
comments. I couldn't add his Signed-off-by without his permission on
the later revision series. Hence, the reason for "Original work by"
line above.

> > 
> > Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> 
> 

Thanks,
Rahul