From: Guenter Roeck <linux@roeck-us.net>
To: Pascal PAILLET-LME <p.paillet@st.com>
Cc: kbuild-all@01.org,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"benjamin.gaignard@linaro.org" <benjamin.gaignard@linaro.org>,
"eballetbo@gmail.com" <eballetbo@gmail.com>
Subject: Re: [PATCH v3 8/8] watchdog: stpmic1: add stpmic1 watchdog driver
Date: Tue, 9 Oct 2018 14:44:50 -0700 [thread overview]
Message-ID: <20181009214450.GA13702@roeck-us.net> (raw)
In-Reply-To: <201810090846.it9ed9td%fengguang.wu@intel.com>
On Tue, Oct 09, 2018 at 08:47:26AM +0800, kbuild test robot wrote:
> Hi pascal,
>
> Thank you for the patch! Perhaps something to improve:
>
[ ... ]
> 42
> 43 static int pmic_wdt_stop(struct watchdog_device *wdd)
> 44 {
> 45 struct stpmic1_wdt *wdt = watchdog_get_drvdata(wdd);
> 46
> 47 return regmap_update_bits(wdt->pmic->regmap,
> > 48 WCHDG_CR, WDT_START_MASK, ~WDT_START);
Maybe use
#define WDT_STOP 0
instead, or just write 0. ~WDT_START may be convenient but not really correct.
Guenter
prev parent reply other threads:[~2018-10-09 21:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 16:29 [PATCH v3 0/8] Introduce STPMIC1 PMIC Driver Pascal PAILLET-LME
2018-10-08 16:29 ` [PATCH v3 1/8] dt-bindings: mfd: document stpmic1 Pascal PAILLET-LME
2018-10-12 15:28 ` Rob Herring
2018-10-08 16:29 ` [PATCH v3 2/8] mfd: stpmic1: add stpmic1 driver Pascal PAILLET-LME
2018-10-08 16:29 ` [PATCH v3 3/8] dt-bindings: regulator: document stpmic1 pmic regulators Pascal PAILLET-LME
2018-10-12 15:32 ` Rob Herring
2018-10-12 15:32 ` Rob Herring
2018-10-08 16:29 ` [PATCH v3 4/8] regulator: stpmic1: add stpmic1 regulator driver Pascal PAILLET-LME
2018-10-08 16:29 ` [PATCH v3 5/8] dt-bindings: input: document stpmic1 pmic onkey Pascal PAILLET-LME
2018-10-09 13:52 ` Pascal PAILLET-LME
2018-10-12 15:33 ` Rob Herring
2018-10-08 16:29 ` [PATCH v3 7/8] dt-bindings: watchdog: document stpmic1 pmic watchdog Pascal PAILLET-LME
2018-10-08 16:29 ` [PATCH v3 6/8] input: stpmic1: add stpmic1 onkey driver Pascal PAILLET-LME
2018-10-15 22:32 ` dmitry.torokhov
2018-10-08 16:29 ` [PATCH v3 8/8] watchdog: stpmic1: add stpmic1 watchdog driver Pascal PAILLET-LME
2018-10-08 16:35 ` Randy Dunlap
2018-10-09 0:47 ` kbuild test robot
2018-10-09 0:47 ` kbuild test robot
2018-10-09 21:44 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009214450.GA13702@roeck-us.net \
--to=linux@roeck-us.net \
--cc=benjamin.gaignard@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@gmail.com \
--cc=kbuild-all@01.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=p.paillet@st.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.