From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] meson: Use AR via wrapper
Date: Tue, 9 Oct 2018 23:13:46 +0200 [thread overview]
Message-ID: <20181009231346.156ddb0d@gmx.net> (raw)
In-Reply-To: <20181009203406.GM2869@scaer>
Hello Alexey,
On Tue, 9 Oct 2018 22:34:06 +0200, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Alexey, All,
>
> On 2018-10-09 22:24 +0300, Alexey Brodkin spake thusly:
> > If building with LTO enabled we need to use GCC wrapper for AR otherwise
> > archives get created improperly and we see a lot of unresolved symbols
> > on finla linkage.
From quick review another minor nit: s/finla/final/
Will try to test the patch the next days...
Regards,
Peter
> >
> > In particular this allows to build SystemD with LTO.
>
> This is just 'systemd', not SystemD, or any other case-mangling on it
> https://www.freedesktop.org/wiki/Software/systemd/ ;-)
>
> There, I'm done with the nit-picking. ;-) Now read on, for the real
> review lies below...
>
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> > Cc: Mark Corbin <mark.corbin@embecosm.com>
> > Cc: Peter Korsgaard <peter@korsgaard.com>
> > Cc: Peter Seiderer <ps.report@gmx.net>
> > ---
> > package/meson/cross-compilation.conf.in | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/meson/cross-compilation.conf.in b/package/meson/cross-compilation.conf.in
> > index 0eec74087b..de4600cc58 100644
> > --- a/package/meson/cross-compilation.conf.in
> > +++ b/package/meson/cross-compilation.conf.in
> > @@ -6,7 +6,7 @@
> > [binaries]
> > c = '@TARGET_CROSS at gcc'
> > cpp = '@TARGET_CROSS at g++'
> > -ar = '@TARGET_CROSS at ar'
> > +ar = '@TARGET_CROSS at gcc-ar'
>
> I was curioous as to see for how long gcc provided that wrapper. It
> turns out that at least 4.9 did.
>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Regards,
> Yann E. MORIN.
>
> > strip = '@TARGET_CROSS at strip'
> > pkgconfig = '@HOST_DIR@/usr/bin/pkg-config'
> >
> > --
> > 2.16.2
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
next prev parent reply other threads:[~2018-10-09 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 19:24 [Buildroot] [PATCH] meson: Use AR via wrapper Alexey Brodkin
2018-10-09 20:34 ` Yann E. MORIN
2018-10-09 21:13 ` Peter Seiderer [this message]
2018-10-10 6:43 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009231346.156ddb0d@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.