From mboxrd@z Thu Jan 1 00:00:00 1970 From: AKASHI, Takahiro Date: Wed, 10 Oct 2018 09:54:15 +0900 Subject: [U-Boot] [PATCH 02/11] efi_loader: Initial HII protocols In-Reply-To: References: <20171010122309.25313-1-robdclark@gmail.com> <20171010122309.25313-3-robdclark@gmail.com> <1ba39d81-92e5-d9d6-f756-67139ce796e6@suse.de> <20181003073908.GI32578@linaro.org> <20181005094915.tdc5nazvxrjghnb7@bivouac.eciton.net> <31a68fdc-d29f-29fb-3b06-68f3922b149d@suse.de> <20181009072445.GQ32578@linaro.org> Message-ID: <20181010005414.GT32578@linaro.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Heinrich, On Tue, Oct 09, 2018 at 07:19:58PM +0200, Heinrich Schuchardt wrote: > On 10/09/2018 09:24 AM, AKASHI, Takahiro wrote: > > Do you have any specific idea about what is really missing > > in Leif's/Rob's HII patch? > > (My original question.) > > > > -Takahiro Akashi > > Please, see https://patchwork.ozlabs.org/patch/823807/ Thanks, I didn't notice this thread. > Open topics were: > - usage of bitfields > - incorrect determination of string lengths > - too deep nesting of of loops and ifs Okay, those seem to be easily fixable at a glance. > - incomplete implementation of the protocols That is a matter I'm concerned about. There's no consensus yet about what should be in an "initial" port. BTW, you said there were some missing protocols to run i386 version of Shell: EFI HII font protocol and EFI HII Image protocol. Do you still believe so even after Alex's comment? Thanks, -Takahiro Akashi > As other protocols are based on the HII database protocol we should > start with this protocol in a separate patch. We should have a unit test > in lib/efi_selftest/ for all methods of the protocol. > > Best regards > > Heinrich