From: Andrew Lunn <andrew@lunn.ch>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>
Cc: "David S . Miller" <davem@davemloft.net>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Subject: [net-next,05/19] net: usb: aqc111: Introduce PHY access
Date: Wed, 10 Oct 2018 02:58:52 +0200 [thread overview]
Message-ID: <20181010005852.GA20147@lunn.ch> (raw)
On Mon, Oct 08, 2018 at 09:09:54AM +0000, Igor Russkikh wrote:
> Hi Andrew,
>
> >>
> >> + struct aqc111_data *aqc111_data = (struct aqc111_data *)dev->data[0];
> >
> > Having to do this cast all the time is quiet ugly. It seems like some
> > other usb_net drivers use netdev_priv().
>
> As I see most of usb usbnet based devices use the same theme with accessing
> private data via dev->data.
Hi Igor
I just discovered driver_priv.
https://elixir.bootlin.com/linux/v4.19-rc7/source/include/linux/usb/usbnet.h#L33
It would be good to use that, to avoid the casts.
Andrew
next reply other threads:[~2018-10-10 0:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 0:58 Andrew Lunn [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-10 7:54 [net-next,05/19] net: usb: aqc111: Introduce PHY access Igor Russkikh
2018-10-08 14:24 Oliver Neukum
2018-10-08 14:10 Igor Russkikh
2018-10-08 14:07 Igor Russkikh
2018-10-08 13:52 Oliver Neukum
2018-10-08 12:17 Andrew Lunn
2018-10-08 9:09 Igor Russkikh
2018-10-05 22:04 Andrew Lunn
2018-10-05 10:24 Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010005852.GA20147@lunn.ch \
--to=andrew@lunn.ch \
--cc=Dmitry.Bezrukov@aquantia.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=davem@davemloft.net \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.