From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 10/16] nvmet-fcloop: Suppress a compiler warning
Date: Wed, 10 Oct 2018 15:18:10 +0200 [thread overview]
Message-ID: <20181010131810.GA22031@lst.de> (raw)
In-Reply-To: <20181008212854.68310-11-bvanassche@acm.org>
On Mon, Oct 08, 2018@02:28:48PM -0700, Bart Van Assche wrote:
> Building with W=1 enables the compiler warning -Wimplicit-fallthrough=3. That
> option does not recognize the fall-through comment in the fcloop driver. Hence
> relax that compiler option. This patch avoids that the compiler reports the
> following warning when building with W=1:
>
> drivers/nvme/target/fcloop.c:647:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (op == NVMET_FCOP_READDATA)
Can you please just fix up the comments to use normal /* FALLTHRU */
annotation? I rather hate having special compiler flags in drivers.
next prev parent reply other threads:[~2018-10-10 13:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 21:28 [PATCH 00/16] Fixes for issues detected by static analyzers Bart Van Assche
2018-10-08 21:28 ` [PATCH 01/16] nvme-core: Declare local symbols static Bart Van Assche
2018-10-08 21:51 ` Chaitanya Kulkarni
2018-10-09 11:26 ` Johannes Thumshirn
2018-10-08 21:28 ` [PATCH 02/16] nvme-core: Refuse out-of-range integrity data seeds Bart Van Assche
2018-10-08 21:46 ` Keith Busch
2018-10-08 21:28 ` [PATCH 03/16] nvme-core: Rework a NQN copying operation Bart Van Assche
2018-10-09 11:27 ` Johannes Thumshirn
2018-10-08 21:28 ` [PATCH 04/16] nvme-core: Complain if nvme_init_identify() fails Bart Van Assche
2018-10-08 21:45 ` Chaitanya Kulkarni
2018-10-08 22:16 ` Keith Busch
2018-10-08 22:26 ` Bart Van Assche
2018-10-08 22:54 ` Keith Busch
2018-10-08 21:28 ` [PATCH 05/16] nvme-pci: Fix nvme_suspend_queue() kernel-doc header Bart Van Assche
2018-10-08 21:58 ` Keith Busch
2018-10-08 21:28 ` [PATCH 06/16] nvme-fc: Fix kernel-doc headers Bart Van Assche
2018-10-09 18:30 ` James Smart
2018-10-08 21:28 ` [PATCH 07/16] nvme-fc: Introduce struct nvme_fcp_op_w_sgl Bart Van Assche
2018-10-09 18:38 ` James Smart
2018-10-08 21:28 ` [PATCH 08/16] nvme-fc: Rework the request initialization code Bart Van Assche
2018-10-09 18:41 ` James Smart
2018-10-08 21:28 ` [PATCH 09/16] nvmet-fc: Fix kernel-doc headers Bart Van Assche
2018-10-09 18:43 ` James Smart
2018-10-08 21:28 ` [PATCH 10/16] nvmet-fcloop: Suppress a compiler warning Bart Van Assche
2018-10-09 18:44 ` James Smart
2018-10-10 13:18 ` Christoph Hellwig [this message]
2018-10-08 21:28 ` [PATCH 11/16] nvmet: Use strcmp() instead of strncmp() for subsystem lookup Bart Van Assche
2018-10-08 21:28 ` [PATCH 12/16] nvmet: Remove unreachable code from nvmet_parse_discovery_cmd() Bart Van Assche
2018-10-08 22:02 ` Chaitanya Kulkarni
2018-10-09 1:49 ` Bart Van Assche
2018-10-08 21:28 ` [PATCH 13/16] nvmet: Use strlcpy() instead of strcpy() Bart Van Assche
2018-10-08 22:06 ` Chaitanya Kulkarni
2018-10-08 21:28 ` [PATCH 14/16] nvmet: Avoid integer overflow in the discard code Bart Van Assche
2018-10-08 21:57 ` Chaitanya Kulkarni
2018-10-08 21:28 ` [PATCH 15/16] nvmet-rdma: Declare local symbols static Bart Van Assche
2018-10-08 21:43 ` Chaitanya Kulkarni
2018-10-08 21:28 ` [PATCH 16/16] nvmet-rdma: Check for timeout in nvme_rdma_wait_for_cm() Bart Van Assche
2018-10-09 16:58 ` [PATCH 00/16] Fixes for issues detected by static analyzers Christoph Hellwig
2018-10-10 13:18 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010131810.GA22031@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.