From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 1/1] package/luvi: bump version to 2.8.0
Date: Wed, 10 Oct 2018 15:29:09 +0200 [thread overview]
Message-ID: <20181010152909.2f85fd4c@windsurf> (raw)
In-Reply-To: <3c2105ff5b2fb60820f63e1d7851ddda2ec48355.camel@embedded.rocks>
J?rg, Bernd,
On Tue, 21 Aug 2018 20:52:45 +0200, J?rg Krause wrote:
> > -LUVI_VERSION = v2.7.6
> > -LUVI_SOURCE = luvi-src-$(LUVI_VERSION).tar.gz
> > -LUVI_SITE = https://github.com/luvit/luvi/releases/download/$(LUVI_VERSION)
> > +LUVI_VERSION = v2.8.0
> > +LUVI_SITE = https://github.com/luvit/luvi.git
> > +LUVI_SITE_METHOD = git
> > +LUVI_GIT_SUBMODULES = YES
> > LUVI_LICENSE = Apache-2.0
> > LUVI_LICENSE_FILES = LICENSE.txt
> > LUVI_DEPENDENCIES = libuv luajit luv host-luajit
>
> I am not so happy about the version bump as version 2.8.0 does only
> updates the projects submodules, which we are not using at all.
> Instead, we always build luvi with dependencies provided as packages in
> Buildroot.
>
> Bumping to version 2.8.0 has the drawback that fetching the package
> needs much longer now due to the git submodules than fetching the
> tarball and building against the packages provided by Buildroot.
Should we revert this 2.8.0 bump then ? If you want to do that, could
you send a patch, and made add a comment in luvi.mk that explains why
bumping to 2.8.0 is useless ?
Also, luvi 2.8.0 has been causing a number of build failures:
http://autobuild.buildroot.net/?reason=luvi-v2.8.0. They need to be
fixed, or indeed reverting will be the only solution.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-10-10 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-19 12:02 [Buildroot] [PATCH/next 1/1] package/luvi: bump version to 2.8.0 Bernd Kuhls
2018-08-20 13:23 ` Thomas Petazzoni
2018-08-21 18:52 ` Jörg Krause
2018-10-10 13:29 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010152909.2f85fd4c@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.