From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Milan Broz <gmazyland@gmail.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
jslaby@suse.com, aszlig@nix.build, torvalds@linux-foundation.org,
w@1wt.eu, Daniel Zatovic <daniel.zatovic@gmail.com>
Subject: Re: [PATCH v2 0/2] tty: erase buffers when the kernel is done with it.
Date: Wed, 10 Oct 2018 20:24:21 +0200 [thread overview]
Message-ID: <20181010182421.GA23517@kroah.com> (raw)
In-Reply-To: <c54d108b-729a-5866-53d1-26f2e7d0db2b@gmail.com>
On Wed, Oct 10, 2018 at 08:20:06PM +0200, Milan Broz wrote:
> On 04/10/2018 20:06, Greg Kroah-Hartman wrote:
> > azlig and Milan Broz reported that when the tty layer is done with a
> > buffer, the data can hang around in it for a very long time. That
> > sometimes can "leak" to userspace under some conditions.
> >
> > Because of this, just zero out the data after the tty layer is finished
> > with it, for buffers that we "think" should be zeroed out.
> >
> > v2 - addressed some review comments on the 2/2 patch.
>
> Hello Greg,
>
> together with our intern we re-tested both patches and it fixes the reported problem,
> so, if it helps anything, you can add
>
> Tested-by: Milan Broz <gmazyland@gmail.com>
> Tested-by: Daniel Zatovic <daniel.zatovic@gmail.com>
>
> Do you plan to add this to linux-next?
Yes, I'll queue it up soon, thanks for testing!
greg k-h
prev parent reply other threads:[~2018-10-10 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 18:06 [PATCH v2 0/2] tty: erase buffers when the kernel is done with it Greg Kroah-Hartman
2018-10-04 18:06 ` [PATCH v2 1/2] tty: wipe buffer Greg Kroah-Hartman
2018-10-04 18:06 ` [PATCH v2 2/2] tty: wipe buffer if not echoing data Greg Kroah-Hartman
2018-10-10 18:20 ` [PATCH v2 0/2] tty: erase buffers when the kernel is done with it Milan Broz
2018-10-10 18:24 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010182421.GA23517@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aszlig@nix.build \
--cc=daniel.zatovic@gmail.com \
--cc=gmazyland@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.