From: Dan Carpenter <dan.carpenter@oracle.com>
To: Slawomir Stepien <sst@poczta.fm>
Cc: Gabriel Capella <gabriel@capella.pro>,
devel@driverdev.osuosl.org, Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <michael.hennerich@analog.com>,
linux-iio@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] staging: iio: adc: ad7280a: fix 2 checks
Date: Thu, 11 Oct 2018 10:32:03 +0300 [thread overview]
Message-ID: <20181011073203.iesapekyqkma2cqa@mwanda> (raw)
In-Reply-To: <20181006202542.GC5035@x220.localdomain>
On Sat, Oct 06, 2018 at 10:25:42PM +0200, Slawomir Stepien wrote:
> On paź 06, 2018 13:27, Gabriel Capella wrote:
> > This patch does not change the logic, it only
> > corrects the checkpatch checks.
> >
> > The patch fixes 2 checks of type:
> > "CHECK: spaces preferred around that '-'"
>
> I've made the same mistake few days ago. This change is incorrect.
> Please see: https://lore.kernel.org/patchwork/patch/635994/.
>
You could add a comment. /* do not put spaces around the hyphen. #checkpatch.pl */
These are the only places which use this style and a lot of people
bump into it.
regards,
dan carpenter
next prev parent reply other threads:[~2018-10-11 7:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-06 16:27 [PATCH] staging: iio: adc: ad7280a: fix 2 checks Gabriel Capella
2018-10-06 20:25 ` Slawomir Stepien
2018-10-11 7:32 ` Dan Carpenter [this message]
2018-10-11 15:31 ` Slawomir Stepien
2018-10-15 21:45 ` Gabriel Capella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011073203.iesapekyqkma2cqa@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gabriel@capella.pro \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=pmeerw@pmeerw.net \
--cc=sst@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.