From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] arm64: perf: Move event definitions into perf_event.h
Date: Thu, 11 Oct 2018 10:04:14 +0100 [thread overview]
Message-ID: <20181011090414.GB20836@arm.com> (raw)
In-Reply-To: <7fa991a1-40b2-08cf-11cf-8c41124496d8@arm.com>
On Wed, Oct 10, 2018 at 06:27:04PM +0100, Suzuki K Poulose wrote:
> On 10/10/18 17:31, Will Deacon wrote:
> >+/* Statistical profiling extension microarchitectural events */
> >+#define ARMV8_SPE_PERFCTR_SAMPLE_POP 0x4000
> >+#define ARMV8_SPE_PERFCTR_SAMPLE_FEED 0x4000
> >+#define ARMV8_SPE_PERFCTR_SAMPLE_FILTRATE 0x4000
> >+#define ARMV8_SPE_PERFCTR_SAMPLE_COLLISION 0x4000
>
> This appears to be a mistake of copy-paste. The numbers must be
>
> +#define ARMV8_SPE_PERFCTR_SAMPLE_POP 0x4000
> +#define ARMV8_SPE_PERFCTR_SAMPLE_FEED 0x4001
> +#define ARMV8_SPE_PERFCTR_SAMPLE_FILTRATE 0x4002
> +#define ARMV8_SPE_PERFCTR_SAMPLE_COLLISION 0x4003
>
> Otherwise looks good to me.
Duh. Thanks.
Will
next prev parent reply other threads:[~2018-10-11 9:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 16:31 [PATCH 0/6] PMUv3 event handling improvements Will Deacon
2018-10-10 16:31 ` [PATCH 1/6] arm64: perf: Reject stand-alone CHAIN events for PMUv3 Will Deacon
2018-10-10 16:31 ` Will Deacon
2018-10-10 17:30 ` Suzuki K Poulose
2018-10-10 17:30 ` Suzuki K Poulose
2018-10-11 9:04 ` Will Deacon
2018-10-11 9:04 ` Will Deacon
2018-10-10 16:31 ` [PATCH 2/6] arm64: perf: Terminate PMU assignment statements with semicolons Will Deacon
2018-10-10 16:31 ` [PATCH 3/6] arm64: perf: Add support for Armv8.1 PMCEID register format Will Deacon
2018-10-10 16:31 ` [PATCH 4/6] arm64: perf: Remove duplicate generic cache events Will Deacon
2018-10-10 16:31 ` [PATCH 5/6] arm64: perf: Move event definitions into perf_event.h Will Deacon
2018-10-10 17:27 ` Suzuki K Poulose
2018-10-11 9:04 ` Will Deacon [this message]
2018-10-10 16:31 ` [PATCH 6/6] arm64: perf: Hook up new events Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011090414.GB20836@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.