From: Greg KH <gregkh@linuxfoundation.org>
To: Amit Pundir <amit.pundir@linaro.org>
Cc: Stable <stable@vger.kernel.org>,
Carl Huang <cjhuang@codeaurora.org>,
Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH for-4.14.y 2/4] ath10k: fix use-after-free in ath10k_wmi_cmd_send_nowait
Date: Thu, 11 Oct 2018 11:25:00 +0200 [thread overview]
Message-ID: <20181011092500.GF13455@kroah.com> (raw)
In-Reply-To: <1539163789-32338-2-git-send-email-amit.pundir@linaro.org>
On Wed, Oct 10, 2018 at 02:59:47PM +0530, Amit Pundir wrote:
> From: Carl Huang <cjhuang@codeaurora.org>
>
> commit 9ef0f58ed7b4a55da4a64641d538e0d9e46579ac upstream.
>
> The skb may be freed in tx completion context before
> trace_ath10k_wmi_cmd is called. This can be easily captured when
> KASAN(Kernel Address Sanitizer) is enabled. The fix is to move
> trace_ath10k_wmi_cmd before the send operation. As the ret has no
> meaning in trace_ath10k_wmi_cmd then, so remove this parameter too.
>
> Signed-off-by: Carl Huang <cjhuang@codeaurora.org>
> Tested-by: Brian Norris <briannorris@chromium.org>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
> ---
> To be applied on 4.9.y and 4.4.y as well.
> Build tested on 4.14.74, 4.9.131 and 4.4.159 for ARCH=arm/arm64 allmodconfig.
Applied, thanks.
greg k-h
next prev parent reply other threads:[~2018-10-11 16:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 9:29 [PATCH for-4.14.y 1/4] cgroup/cpuset: remove circular dependency deadlock Amit Pundir
2018-10-10 9:29 ` [PATCH for-4.14.y 2/4] ath10k: fix use-after-free in ath10k_wmi_cmd_send_nowait Amit Pundir
2018-10-11 9:25 ` Greg KH [this message]
2018-10-10 9:29 ` [PATCH for-4.14.y 3/4] ath10k: fix kernel panic issue during pci probe Amit Pundir
2018-10-11 9:28 ` Greg KH
2018-10-10 9:29 ` [PATCH for-4.14.y 4/4] nvme_fc: fix ctrl create failures racing with workq items Amit Pundir
2018-10-11 9:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011092500.GF13455@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amit.pundir@linaro.org \
--cc=cjhuang@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.