All of lore.kernel.org
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: phillip.wood@dunelm.org.uk, git@vger.kernel.org,
	Junio C Hamano <gitster@pobox.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] revert & cherry-pick: run git gc --auto
Date: Thu, 11 Oct 2018 13:24:00 +0200	[thread overview]
Message-ID: <20181011112400.GA19800@szeder.dev> (raw)
In-Reply-To: <87efcwepqc.fsf@evledraar.gmail.com>

On Thu, Oct 11, 2018 at 12:34:35PM +0200, Ævar Arnfjörð Bjarmason wrote:
> I see we define NO_POSIX_GOODIES on Windows/MinGW, so those don't
> demonize "gc", but then I'm confused by this which seems to imply the
> opposite: https://github.com/Microsoft/vscode/issues/29901

I don't think it implies that.

The last comment starts with "Code calls git fetch periodically".  I
presume that it does so in the background (to prevent blocking the UI
until 'git fetch' runs), therefore 'git gc --auto' starts already in
the background.  Furthermore, notice that 'git prune' on that
screenshot has two 'git.exe' parents: I think its parent is 'git gc
--auto' and its grandparent is 'git fetch'.  Now, if that 'git gc
--auto' were to go to the background as a result of our daemonize(),
then the grandparent 'git fetch' would have very likely exited
already.


  reply	other threads:[~2018-10-11 11:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10 19:35 [PATCH] revert & cherry-pick: run git gc --auto Ævar Arnfjörð Bjarmason
2018-10-11  9:23 ` Phillip Wood
2018-10-11 10:08   ` Ævar Arnfjörð Bjarmason
2018-10-11 10:25     ` SZEDER Gábor
2018-10-11 10:34       ` Ævar Arnfjörð Bjarmason
2018-10-11 11:24         ` SZEDER Gábor [this message]
2018-10-11 11:14     ` Phillip Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181011112400.GA19800@szeder.dev \
    --to=szeder.dev@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.