Re: [PATCH 2/2] drm/panel: Add driver for Samsung S6D16D0 panel

From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/2] drm/panel: Add driver for Samsung S6D16D0 panel
Date: Thu, 11 Oct 2018 13:37:04 +0200	[thread overview]
Message-ID: <20181011113704.GA18397@ravnborg.org> (raw)
In-Reply-To: <CACRpkdY4fL9a1wozxSALi7S1Fab3ovV6BognxLHUJvdWur4HWA@mail.gmail.com>

> > > +     if (IS_ERR(s6->supply))
> > > +             return PTR_ERR(s6->supply);
> >
> > This cannot be -EPROBE_DEFER?
> 
> It can and then it bails out here and retries later.
> 
> I don't quite get the question, sorry.
> 
> > > +     if (IS_ERR(s6->reset_gpio)) {
> > > +             ret = PTR_ERR(s6->reset_gpio);
> > > +             if (ret != -EPROBE_DEFER)
> > > +                     dev_err(dev, "failed to request GPIO: %d\n", ret);
> > > +             return ret;
> > > +     }
> >
> > Like this..
> 
> -EPROBE_DEFER is only tested to not produce error prints
> unnecessarily. In the regulator case, the regulator core already
> displays an error.
This was what I missed above (that we only check -EPROBE_DEFER to avoid printing).
So my question was just me confusing things.

Thanks for the explanation.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel