From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 06/10] drm/i915: Remove crtc->config dereferences in intel_sanitize_crtc Date: Thu, 11 Oct 2018 14:57:07 +0300 Message-ID: <20181011115707.GC9144@intel.com> References: <20181011100457.8776-1-maarten.lankhorst@linux.intel.com> <20181011100457.8776-7-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id C559C6E3DF for ; Thu, 11 Oct 2018 11:57:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181011100457.8776-7-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTEsIDIwMTggYXQgMTI6MDQ6NTNQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gV2Uga25vdyB0aGUgY3J0YyBpcyBpZGxlIGJlY2F1c2Ugd2UncmUgYXQgdGhl IGJlZ2lubmluZyBvZiBzYW5pdGl6YXRpb24sCj4gc28ganVzdCBkZXJlZmVyZW5jZSBjcnRjLT5z dGF0ZSBpbnN0ZWFkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFy dGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOk bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDkgKysrKystLS0tCj4gIDEgZmlsZSBjaGFuZ2Vk LCA1IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+IGluZGV4IGVhZjUyMmVmMjkyNy4uMTlkNzcxNGRmMDIxIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xNTU2NSw3ICsxNTU2NSw4IEBA IHN0YXRpYyB2b2lkIGludGVsX3Nhbml0aXplX2NydGMoc3RydWN0IGludGVsX2NydGMgKmNydGMs Cj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNlLmRldjsKPiAgCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAtCWVudW0g dHJhbnNjb2RlciBjcHVfdHJhbnNjb2RlciA9IGNydGMtPmNvbmZpZy0+Y3B1X3RyYW5zY29kZXI7 Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSA9IHRvX2ludGVsX2NydGNf c3RhdGUoY3J0Yy0+YmFzZS5zdGF0ZSk7Cj4gKwllbnVtIHRyYW5zY29kZXIgY3B1X3RyYW5zY29k ZXIgPSBjcnRjX3N0YXRlLT5jcHVfdHJhbnNjb2RlcjsKPiAgCj4gIAkvKiBDbGVhciBhbnkgZnJh bWUgc3RhcnQgZGVsYXlzIHVzZWQgZm9yIGRlYnVnZ2luZyBsZWZ0IGJ5IHRoZSBCSU9TICovCj4g IAlpZiAoY3J0Yy0+YWN0aXZlICYmICF0cmFuc2NvZGVyX2lzX2RzaShjcHVfdHJhbnNjb2Rlcikp IHsKPiBAQCAtMTU1NzUsNyArMTU1NzYsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9zYW5pdGl6ZV9j cnRjKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJCQkgICBJOTE1X1JFQUQocmVnKSAmIH5Q SVBFQ09ORl9GUkFNRV9TVEFSVF9ERUxBWV9NQVNLKTsKPiAgCX0KPiAgCj4gLQlpZiAoY3J0Yy0+ YWN0aXZlKSB7Cj4gKwlpZiAoY3J0Y19zdGF0ZS0+YmFzZS5hY3RpdmUpIHsKPiAgCQlzdHJ1Y3Qg aW50ZWxfcGxhbmUgKnBsYW5lOwo+ICAKPiAgCQkvKiBEaXNhYmxlIGV2ZXJ5dGhpbmcgYnV0IHRo ZSBwcmltYXJ5IHBsYW5lICovCj4gQEAgLTE1NTkxLDEwICsxNTU5MiwxMCBAQCBzdGF0aWMgdm9p ZCBpbnRlbF9zYW5pdGl6ZV9jcnRjKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAKPiAgCS8q IEFkanVzdCB0aGUgc3RhdGUgb2YgdGhlIG91dHB1dCBwaXBlIGFjY29yZGluZyB0byB3aGV0aGVy IHdlCj4gIAkgKiBoYXZlIGFjdGl2ZSBjb25uZWN0b3JzL2VuY29kZXJzLiAqLwo+IC0JaWYgKGNy dGMtPmFjdGl2ZSAmJiAhaW50ZWxfY3J0Y19oYXNfZW5jb2RlcnMoY3J0YykpCj4gKwlpZiAoY3J0 Y19zdGF0ZS0+YmFzZS5hY3RpdmUgJiYgIWludGVsX2NydGNfaGFzX2VuY29kZXJzKGNydGMpKQo+ ICAJCWludGVsX2NydGNfZGlzYWJsZV9ub2F0b21pYygmY3J0Yy0+YmFzZSwgY3R4KTsKPiAgCj4g LQlpZiAoY3J0Yy0+YWN0aXZlIHx8IEhBU19HTUNIX0RJU1BMQVkoZGV2X3ByaXYpKSB7Cj4gKwlp ZiAoY3J0Y19zdGF0ZS0+YmFzZS5hY3RpdmUgfHwgSEFTX0dNQ0hfRElTUExBWShkZXZfcHJpdikp IHsKPiAgCQkvKgo+ICAJCSAqIFdlIHN0YXJ0IG91dCB3aXRoIHVuZGVycnVuIHJlcG9ydGluZyBk aXNhYmxlZCB0byBhdm9pZCByYWNlcy4KPiAgCQkgKiBGb3IgY29ycmVjdCBib29ra2VlcGluZyBt YXJrIHRoaXMgb24gYWN0aXZlIGNydGNzLgo+IC0tIAo+IDIuMTkuMAo+IAo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrD pGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK